Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262316AbUCGUId (ORCPT ); Sun, 7 Mar 2004 15:08:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262322AbUCGUId (ORCPT ); Sun, 7 Mar 2004 15:08:33 -0500 Received: from paja.kn.vutbr.cz ([147.229.191.135]:50437 "EHLO paja.kn.vutbr.cz") by vger.kernel.org with ESMTP id S262316AbUCGUIc (ORCPT ); Sun, 7 Mar 2004 15:08:32 -0500 Message-ID: <404B812F.7000204@stud.feec.vutbr.cz> Date: Sun, 07 Mar 2004 21:08:15 +0100 From: Michal Schmidt User-Agent: Mozilla Thunderbird 0.5 (X11/20040208) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Marcelo Tosatti CC: linux-kernel@vger.kernel.org Subject: Re: Linux 2.4.26-pre2 References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 27 Hello, > : > o Fix vmalloc() error handling > This change has a problem. In __vmalloc_area_pages when pmd_alloc fails, the spinlock will not be released. Maybe the following patch is needed? (only compile tested, I don't have SMP) Michal Schmidt --- linux-2.4.26-pre2/mm/vmalloc.c Sun Mar 7 20:44:27 2004 +++ linux-2.4.26-pre2.mich/mm/vmalloc.c Sun Mar 7 20:54:02 2004 @@ -183,6 +183,7 @@ static inline int __vmalloc_area_pages ( err: if (address > start) vmfree_area_pages((address - start), address - start); + spin_unlock(&init_mm.page_table_lock); return -ENOMEM; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/