Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp1039690ima; Fri, 1 Feb 2019 15:18:09 -0800 (PST) X-Google-Smtp-Source: ALg8bN7pXWSTgVU4/+8G7MaGrSFQkIk6E3aqlTG76WyoupSedIBHg3msgiRek4nOCsT1Rp+F3dpB X-Received: by 2002:a62:2a4b:: with SMTP id q72mr40891589pfq.61.1549063089893; Fri, 01 Feb 2019 15:18:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549063089; cv=none; d=google.com; s=arc-20160816; b=OPmipucSGnqe19dGEZPU3SG4y3H3EMvxeJVT/dK8zUZmfkuzrBhcin9ouna+Qr+mPa Y+0FLsSIv5DHS+favV2QCcZ25LHlG2TNNu2m2it9JqV7IbMph3236oXJpYBBuWLuN+p9 Gtrt+Y9EDrX9Dy+WHJqLOpeONVAfNmc8/P5AVLGykfPz2xCd57BsJ74STL458vbpCLyJ Gi8ueSrAioPRQleyu9Sog2swkHX6sg1rJ0goV9yBUSYvZekQlMD6972sLG6RdlBQyY4R eM36wJiT2dA2HG/ugPL8MLWEaW4yThF81Y2TOJAwZlfFOY67oG591Vy4S7QY+rvcsdJf hurg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hITrKD1UvJBkX8+FdT2WJe0osPPJT9rBZQVOR7anM94=; b=gksg8jZLt0Vc7qPr2U+5g/pBEfZY6YMmBWb3GBRivY4TKKV2oABeOAL3KagKs0Z7z7 M80wq2O8lT23ZIvsfY3b9znwR8QP1qbZHRDypTsRvzXUwJ0Y2O2zLcdtHcyfz09q7sZw 4GHkJryu+46qCE5/T1aOrQqOHirZHzeXdqqcQHWKZDAuVBZxQq8jQ6KLSzRLWLADxlg+ 417UDuq5SL9mFCs+tRMC1YE19gEeC30LC2rNQJHIWeffWpiYd+4nTTuOAuVl6FNaX7/G wT4nw8cCiaCnzhhNm0s2bFbSPDrub4hMCG7SgLmVU1x8T0s6hX36Ia/VwR8kC8siZAxq eYMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="gbZepM/5"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e8si8393477pgn.325.2019.02.01.15.17.54; Fri, 01 Feb 2019 15:18:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="gbZepM/5"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726872AbfBAXQD (ORCPT + 99 others); Fri, 1 Feb 2019 18:16:03 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:32802 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbfBAXQC (ORCPT ); Fri, 1 Feb 2019 18:16:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hITrKD1UvJBkX8+FdT2WJe0osPPJT9rBZQVOR7anM94=; b=gbZepM/5HJBBiMCElsKLTtBvQ vv5WsdK3AMfmm5ew11Uh9hP4id7NTo1KYbk1tN6CBHDkBgNyaaGr4/zDcgBuOwCuNGrD+O8tJPhz4 Ud2qFbVKMV/3wuLMwZeNkvQyqMa2AEaFxetBeRd7sfwyqhfR9CkifpORuQ+tsVnXeq6XTGg9BUO1P pzjXkomLt1+lRpMA8Sv9xf+ALC/wmwuJ8e3bPsHmlsxGXQS7v+yqHWdDa32c0vU6qhcRVGurkKEht PsZJ+5HrH+e0Jf48HdEOeimqRFvmhEKjR16zMDC4JudZ8beVwFYjEqP/1utIggZT/JVS5jpiAYMpL ePR9ycfQg==; Received: from dvhart by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpi2S-0007FR-Vh; Fri, 01 Feb 2019 23:16:00 +0000 Date: Fri, 1 Feb 2019 15:15:59 -0800 From: Darren Hart To: Christoph Hellwig Cc: stuart.w.hayes@gmail.com, andy@infradead.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Mario_Limonciello@Dell.com Subject: Re: [PATCH] dell_rbu: stop abusing the DMA API Message-ID: <20190201231559.GC105752@fedora.eng.vmware.com> References: <20190129073409.7247-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129073409.7247-1-hch@lst.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 29, 2019 at 08:34:09AM +0100, Christoph Hellwig wrote: > For some odd reason dell_rbu actually seems to want the physical and > not a bus address for the allocated buffer. Lets assume that actually > is correct given that it is BIOS-related and that is a good source > of insanity. In that case we should not use dma_alloc_coherent with > a NULL device to allocate memory, but use GFP_DMA32 to stay under > the 32-bit BIOS limit. + Mario re bios related physical address - is Christoph's assumption correct? Christoph, did you observe a failure? If so, we should probably also tag for stable. -- Darren Hart VMware Open Source Technology Center