Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 01 Feb 2019 15:25:26 -0800 (PST)
Message-Id: <20190201.152526.39050131489014224.davem@davemloft.net>
To:     martin.kepplinger@ginzinger.com
Cc:     corbet@lwn.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
        linux-doc@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, manfred.schlaegl@ginzinger.com
Subject: Re: [PATCH v2] ipconfig: add carrier_timeout kernel parameter
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190131101419.3988-1-martin.kepplinger@ginzinger.com>
References: <20190131101419.3988-1-martin.kepplinger@ginzinger.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Date: Thu, 31 Jan 2019 11:14:18 +0100

> commit 3fb72f1e6e61 ("ipconfig wait for carrier") added a
> "wait for carrier" policy, with a fixed worst case maximum wait
> of two minutes.
> 
> Now make the wait for carrier timeout configurable on the kernel
> commandline and use the 120s as the default.
> 
> The timeout messages introduced with
> commit 5e404cd65860 ("ipconfig: add informative timeout messages while
> waiting for carrier") are done in a fixed interval of 20 seconds, just
> like they were before (240/12).
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>

Ok, this seems fine for me.

Applied to net-next, thanks.