Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1548856186.git.shayenneluzmoura@gmail.com>
In-Reply-To: <cover.1548856186.git.shayenneluzmoura@gmail.com>
From:   Shayenne Moura <shayenneluzmoura@gmail.com>
Date:   Fri, 1 Feb 2019 21:25:38 -0200
Message-ID: <CAKkTe8GsZkBhLLE=Z-JaCpErhi5VvcadTmsw3Wh25Kg5U+VbCA@mail.gmail.com>
Subject: Re: [PATCH 0/2] drm/vkms: Bugfix for igt-tests
To:     Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
        Haneen Mohammed <hamohammed.sa@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>
Cc:     dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Daniel Vetter and I were discussing about this solution. We figured out tha=
t
after these patches, tests were passing but when the computer has a heavy
background workload, tests fail.

I tried a new solution. Instead of change the vblank_time variable, make th=
e
`get_vblank_timestamp` return false when is not happening a vblank_irq.

It worked in the same way of our last attempt.

The reason for this change is that, when the timestamp is not accurate,
drm_vblank deals with this correcting timestamp when `get_vblank_timestamp`
returns false. However, this requirement is important when real hardware ha=
s an
error, and could not return the accurate vblank. Now, we need to know if ou=
r
`vkms_get_vblank_timestamp` should return false and when.

Em qua, 30 de jan de 2019 =C3=A0s 14:05, Shayenne Moura
<shayenneluzmoura@gmail.com> escreveu:
>
> This patchset contains patches to fix the extra frame bug on kms_flip
> igt-test. First patch solves the extra vblank frame that breaks many
> tests on kms_flip and second patch solves the race condition caused
> by the solution added in the first one.
>
> Shayenne Moura (2):
>   drm/vkms: Bugfix extra vblank frame
>   drm/vkms: Bugfix racing hrtimer vblank handle
>
>  drivers/gpu/drm/vkms/vkms_crtc.c | 21 +++++++++------------
>  1 file changed, 9 insertions(+), 12 deletions(-)
>
> --
> 2.17.1
>