Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp1119788ima; Fri, 1 Feb 2019 16:59:53 -0800 (PST) X-Google-Smtp-Source: AHgI3IbKiNkHUohk2KmviXW3en+vere9Bs3e8qYq0sWCm6ASsOL2gKZY83dPHlzSFmiEC50wUlIO X-Received: by 2002:a63:be4d:: with SMTP id g13mr4521974pgo.378.1549069193044; Fri, 01 Feb 2019 16:59:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549069193; cv=none; d=google.com; s=arc-20160816; b=kSeoyJudVBmnNeeluIwBuoSBtBkXSZCCFm1TSg35JXcOCYrOBQO98t0zYmIQaIRHtI aobI8RmHaqGDPyR6WGDM+KYZWxxlfAVHZPedLvk8drvz1vlUlm+qPiG+X5vc2Uf3L5m4 XvwOd3VvkpsolRzqd1J0KZgNZ7sruyi+eWZaPlDoUyM6knPGksW49TB7zzx6+cPMI7xC UzscQeW18UVKM/dvCRMeaakiEhGpDTbabiMHqmjdeI3X19MqqQzZGZR2ckZxpzHFP3dj l8cGqGbcEu0LzuysgfGay31kB4/A48YxIco4LHmreNDLOGMv5XmpbX7qbA0oW/Vk/BH9 1JZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HMW/FMkhqaB4zEYchULm6MpORv5yMKsYsiw2e9nQxZA=; b=ZUXmacarU39c/BwuXg9od/GZ4rPpfmRpW+uZzUYDIm1iraqVb57GZiXeMc0UsTSo5X gZysKgk1QJb8+IaTVhkFTmw3cSRnkY/+ZZfRZTsXOImw4hy9/ARF+TbtiSkmAwzHCOlS oznsjIlCcN4dnEbi4bkOAKbw/JtU+oCfob0+mzqVAD9gcUIMG6dJ/2Aqx+4KK4PZj2YP +Ky0GsH3Cxx1eTjw/T4hbpcxbFZSNRts8+hiTM2PHCNT8Cj1Rx6P+OtPWT8/LTTK/m0C hgf/Mii0Z9Yi36g7wYUfZvlMK2tl0qUpP52o4QhgmLsDT5wFI/s2FBX6sNria021ALcW 9Ufw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eRju4zgM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r17si8381725pgh.299.2019.02.01.16.59.37; Fri, 01 Feb 2019 16:59:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eRju4zgM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727417AbfBBA7d (ORCPT + 99 others); Fri, 1 Feb 2019 19:59:33 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:32878 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbfBBA7d (ORCPT ); Fri, 1 Feb 2019 19:59:33 -0500 Received: by mail-pl1-f193.google.com with SMTP id z23so4080381plo.0; Fri, 01 Feb 2019 16:59:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HMW/FMkhqaB4zEYchULm6MpORv5yMKsYsiw2e9nQxZA=; b=eRju4zgM9xFXZyfOwiLeuoAGZx+DaB08Xje1nxEDUvTWOXoqtVrswEabbpDH8WkI+j WAK2wH43J0T0698kLjnrDIMckEqQ75gdhd2JMBRyFbLN+blE8UiDNuHYq/bTZosWlBNH mOVYKSmzcoJRug7V6F9EHXAQL/Sl6ijx88T68T/n7TivJQL2Hd61C+cy7RxgLmWK0BHJ Z3qlVXDoWFceYtWU89T2T16z3BiRW8wtCFGqo9Ov1JakAl5KeqHpQHXAsdLP/RYYP8oz pcIEMfckcd83Z5kF6PfDhig9iseafg22oSbiwNccfF5z/PQTOVHuWlWY+FO2U/EBcnwB vdpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HMW/FMkhqaB4zEYchULm6MpORv5yMKsYsiw2e9nQxZA=; b=DbIDnVQ9u6K6+OXGikzAmPJ1TP0oY22mIOm5hdJdtA++AXMBxskXNm3IbaUL5eDG1P /poo4gKv7+x1W/MecIu9UDvQ3zcSqKh4+hzsNs6wqoyV4H8DsYDFo51OYjPBvc/tDt6N q+n0PLJND2gecLM57li6pk4Cxl1193yuEX15HMCu557VbHgatUMS4QoPBhHsDtbVIK25 61etNpSG10dkhwsll1xltGkahmLYvqKmAV4ZReVsCMmrBWaCrg3ZdpZeomssXF0qOWB9 y7zPfYYF/nRrMhsDTW1TSs1EMA9fVKQwTXcyMrfLm9A8nP03Zid6f9Qytp4Rt0AVRHgq lQQA== X-Gm-Message-State: AJcUukcnSv3GIcJ4rPMPI9E0lRGrBHJxfgQnEjqKoKnOXbasMwzcn/rb P3J+gfO0H56wYHfDWPo/1Yc= X-Received: by 2002:a17:902:5066:: with SMTP id f35mr42177714plh.78.1549069172103; Fri, 01 Feb 2019 16:59:32 -0800 (PST) Received: from localhost (14-202-194-140.static.tpgi.com.au. [14.202.194.140]) by smtp.gmail.com with ESMTPSA id l82sm8592561pfg.127.2019.02.01.16.59.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Feb 2019 16:59:31 -0800 (PST) Date: Sat, 2 Feb 2019 11:59:28 +1100 From: Balbir Singh To: Joe Lawrence Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, live-patching@vger.kernel.org, Jiri Kosina , Josh Poimboeuf , Michael Ellerman , Nicolai Stange , Torsten Duwe Subject: Re: [PATCH 4/4] powerpc/livepatch: return -ERRNO values in save_stack_trace_tsk_reliable() Message-ID: <20190202005928.GM26056@350D> References: <20190122155724.27557-1-joe.lawrence@redhat.com> <20190122155724.27557-5-joe.lawrence@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190122155724.27557-5-joe.lawrence@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2019 at 10:57:24AM -0500, Joe Lawrence wrote: > To match its x86 counterpart, save_stack_trace_tsk_reliable() should > return -EINVAL in cases that it is currently returning 1. No caller is > currently differentiating non-zero error codes, but let's keep the > arch-specific implementations consistent. > > Signed-off-by: Joe Lawrence Seems straight forward Acked-by: Balbir Singh