Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp1387794ima; Fri, 1 Feb 2019 23:12:57 -0800 (PST) X-Google-Smtp-Source: ALg8bN5fra60tunrzFG6FKFrWTlnSzuaGFrkixf5927AutkOdp5xW8/ux1O862d1HkKg9musGZoN X-Received: by 2002:a62:184e:: with SMTP id 75mr41902113pfy.28.1549091576985; Fri, 01 Feb 2019 23:12:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549091576; cv=none; d=google.com; s=arc-20160816; b=GGhaJmrpLTELf0qUgj3SgmIyLp2v+xORLodsPbXnrVOIz46e2wcM5+/wl0fYNf80E3 OAkRu/L1p1nlv3rX7zZR732nJCv3vk27nlD1OO3hhdF6aiwkJWOVMw5si0eaN4wxAQ2F yCDfr0Yv4e6BkcR6cjvCUa2vDY09dteDtn4bJ7fEtexDqU+W29hitp0O1jynNk5OwEOY 5v79QA1EzRMx96v0rwHGCbjfa7FsirziKDcx+388C4bsNAmpYg04BJuoFEsI6jZCowrI G6fauNBSNPA3iuG/Qf247wyVA3xpoAdWmy9gZEPWr4Y5eD9iySucj53+ujgzH95CpzZB ec8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=LDI2SIhmCpm0rllK3PVlY8Ih7Rih0WDZiCuoA9n05EA=; b=Aof7IzrfLXR2wIy3fePxQOxbBJRSRkjnX45kid9HIlgT9jOl8pfSJTrBxPqVvtNgao Z8n1vUvRxj2NlMw8QzOhF8j1H4RgSJx57o8TIln6/OYmkY3SmluCu2ZnZE1n96ziwwH7 7upY7hsovrZW5onRopMX81WplL4lEcpJUAswZ7v3qlXZ7EO1EdrNTH/kIoG/0kpw9iUu MrW7TR6PAP36tCFPAaWVWjhyB25PgrpwlszJYSvPQbnXagsioo+MgAAPteEj0zWfmRnt pWDhqC2VU5MuDotHkNpqRoD6idqiBG6oST8dhdMyGb/CFmrvglTKR60HEOMSLIpCgXy9 P1/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qg4JB9+A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q18si10446984pls.30.2019.02.01.23.12.42; Fri, 01 Feb 2019 23:12:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qg4JB9+A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727703AbfBBHM1 (ORCPT + 99 others); Sat, 2 Feb 2019 02:12:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:33160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726659AbfBBHM0 (ORCPT ); Sat, 2 Feb 2019 02:12:26 -0500 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA4A520863; Sat, 2 Feb 2019 07:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549091545; bh=1Mup6wsAELPhiC4u7D1TximLwIdAuHu1xQPH9DRuJeY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qg4JB9+AmCCK7hfjoFfJ4YFHkGC2dnYt86xFl/L/XjGN0141YAeMzAWCJnyilW+8k rNA5CzdKs+Cf2NKL+nh3AIftptLzj4srQqkqlSAn7pmOWXZWJjJrBJi0lUJOr0O9lF fX/CL83UD/bOh5gRsBMWUeQ6LSbepyeNmmQdUBU8= Date: Sat, 2 Feb 2019 08:12:11 +0100 From: Boris Brezillon To: Cc: , , , , , , , , , , , , Subject: Re: [PATCH v3 04/13] spi: atmel-quadspi: fix naming scheme Message-ID: <20190202081211.51aabc1f@bbrezillon> In-Reply-To: <20190202040653.1217-5-tudor.ambarus@microchip.com> References: <20190202040653.1217-1-tudor.ambarus@microchip.com> <20190202040653.1217-5-tudor.ambarus@microchip.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2 Feb 2019 04:07:22 +0000 wrote: > From: Tudor Ambarus > > Let general names to core drivers. > > Signed-off-by: Tudor Ambarus Reviewed-by: Boris Brezillon > --- > v3: no change > v2: update after the removing of iomem access wrappers > > drivers/spi/atmel-quadspi.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c > index 131374db0db4..47ed751a91e7 100644 > --- a/drivers/spi/atmel-quadspi.c > +++ b/drivers/spi/atmel-quadspi.c > @@ -158,14 +158,14 @@ struct atmel_qspi { > struct completion cmd_completion; > }; > > -struct qspi_mode { > +struct atmel_qspi_mode { > u8 cmd_buswidth; > u8 addr_buswidth; > u8 data_buswidth; > u32 config; > }; > > -static const struct qspi_mode sama5d2_qspi_modes[] = { > +static const struct atmel_qspi_mode sama5d2_qspi_modes[] = { > { 1, 1, 1, QSPI_IFR_WIDTH_SINGLE_BIT_SPI }, > { 1, 1, 2, QSPI_IFR_WIDTH_DUAL_OUTPUT }, > { 1, 1, 4, QSPI_IFR_WIDTH_QUAD_OUTPUT }, > @@ -175,8 +175,8 @@ static const struct qspi_mode sama5d2_qspi_modes[] = { > { 4, 4, 4, QSPI_IFR_WIDTH_QUAD_CMD }, > }; > > -static inline bool is_compatible(const struct spi_mem_op *op, > - const struct qspi_mode *mode) > +static inline bool atmel_qspi_is_compatible(const struct spi_mem_op *op, > + const struct atmel_qspi_mode *mode) > { > if (op->cmd.buswidth != mode->cmd_buswidth) > return false; > @@ -190,12 +190,12 @@ static inline bool is_compatible(const struct spi_mem_op *op, > return true; > } > > -static int find_mode(const struct spi_mem_op *op) > +static int atmel_qspi_find_mode(const struct spi_mem_op *op) > { > u32 i; > > for (i = 0; i < ARRAY_SIZE(sama5d2_qspi_modes); i++) > - if (is_compatible(op, &sama5d2_qspi_modes[i])) > + if (atmel_qspi_is_compatible(op, &sama5d2_qspi_modes[i])) > return i; > > return -1; > @@ -204,7 +204,7 @@ static int find_mode(const struct spi_mem_op *op) > static bool atmel_qspi_supports_op(struct spi_mem *mem, > const struct spi_mem_op *op) > { > - if (find_mode(op) < 0) > + if (atmel_qspi_find_mode(op) < 0) > return false; > > /* special case not supported by hardware */ > @@ -234,7 +234,7 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) > aq->smm = QSPI_MR_SMM; > } > > - mode = find_mode(op); > + mode = atmel_qspi_find_mode(op); > if (mode < 0) > return -ENOTSUPP; >