Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp1389706ima; Fri, 1 Feb 2019 23:15:59 -0800 (PST) X-Google-Smtp-Source: AHgI3IaLHW9IXJwpyYreYxNrptAX1qavryuxzQ6fYNxyltLReEbmyH0mhqjeW4/LWWPz3ZMMgTO5 X-Received: by 2002:a63:bd51:: with SMTP id d17mr5404363pgp.443.1549091759409; Fri, 01 Feb 2019 23:15:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549091759; cv=none; d=google.com; s=arc-20160816; b=ogL0ymQX2M7z3LDs6de25o95C0QxWPVmQ8il8BsD7qDIpJXCaXB3cb+ZDOHqoW5kTh PNKb60oZq03obZl/EiIaaujYJvjqKBF3CQiGhSEcXgMXjEMXgXJdiixAqlcN/ID8ag5f MQ3XkuSHuSySMJ1G+ZHGx2zgJP98jE4RFh5bu8bK7EVwGUYy+N5RgejCFU8hJofiRI7b gHfnr6SFnIZOJyMJjCL24rIpgRRu/hgjIxT/dd9cayYPtf0qH6RQR1YMhsBhwaZT09W8 MmDwmWEqzoEOCDSkyP/8v8TDwi++Q/OVJ9Y+8VMzBA2DgwUL9i/U+vNeoUBdgrMRx1gu FPQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/+QmallpZRP2uzqj3xBXyLZSZ1hwPydCVBalY9rKwss=; b=XmfvOSDlgEnXyKICfRzu8eKAuxjup0vz78EjUtaho6+LwbCQm8TAzQ6rBnowqHyP1u gjWtK/jTy96iG+VvyYV3zrikush9kNQx8p/UGWQPdoQNv6B1R6HV4wYxaBWE7J3A7XEz dzhsaHsomBBpJ9J0Nj9mqRT8yw0JYdcisdg98h3DfZgG8VMHrz4YGqwsehPKJl4mE6ZQ zDjMq2s8Vyd5ITVL2oKuHI1ZnqYhSvA9QVAsFNNawigiDxl7ElrJqRk9gmDO49CUApR9 gPfx6MoN6U7QlB9Nk8ln7Gf1XKj/TCxlwiR1reebG7BebbsPMuLjIskuTFvawaW78t6f pWuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jnC27kdT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q18si10446984pls.30.2019.02.01.23.15.43; Fri, 01 Feb 2019 23:15:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jnC27kdT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727742AbfBBHPQ (ORCPT + 99 others); Sat, 2 Feb 2019 02:15:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:35618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726659AbfBBHPP (ORCPT ); Sat, 2 Feb 2019 02:15:15 -0500 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 868BD20869; Sat, 2 Feb 2019 07:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549091714; bh=pe2Sgi9wB9pgA71g5eSonL3P7g0Axagq1YpMcrCeSnQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jnC27kdTCZew7WT0oAlu50LnVVmsAOemYotBxRSe2wBn3bTK/yf19u3bE9MXcl3J1 Fnt/7o24+6r7qTPoeeoXv0OPuiJzkGhsh+mqsNqWYzaisB6Aecj8jfZgsgT/HdqdJv W43kHzh3aBiHNYvjak75PLtJlFziEhi0uT/F+UdI= Date: Sat, 2 Feb 2019 08:15:02 +0100 From: Boris Brezillon To: Cc: , , , , , , , , , , , , Subject: Re: [PATCH v3 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory Message-ID: <20190202081502.47ca404d@bbrezillon> In-Reply-To: <20190202040653.1217-11-tudor.ambarus@microchip.com> References: <20190202040653.1217-1-tudor.ambarus@microchip.com> <20190202040653.1217-11-tudor.ambarus@microchip.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2 Feb 2019 04:07:39 +0000 wrote: > From: Tudor Ambarus > > Naming clocks is a good practice. Make "pclk" madatory even if > we support unnamed clock in the driver, to be backward compatible > with old DTs. > > Suggested-by: Boris Brezillon > Signed-off-by: Tudor Ambarus > --- > v3: new patch > > Documentation/devicetree/bindings/spi/atmel-quadspi.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt > index e9dae6264d89..1de54e87f5d6 100644 > --- a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt > +++ b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt > @@ -9,6 +9,7 @@ Required properties: > - qspi_mmap: memory mapped address space > - interrupts: Should contain the interrupt for the device. > - clocks: The phandle of the clock needed by the QSPI controller. > +- clock-names: Should contain "pclk" for the peripheral clock. > - #address-cells: Should be <1>. > - #size-cells: Should be <0>. > > @@ -20,6 +21,7 @@ spi@f0020000 { > reg-names = "qspi_base", "qspi_mmap"; > interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>; > clocks = <&pmc PMC_TYPE_PERIPHERAL 52>; > + clock-names = "pclk" Missing semicolon. Once fixed you can add Reviewed-by: Boris Brezillon > #address-cells = <1>; > #size-cells = <0>; > pinctrl-names = "default";