Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp1495858ima; Sat, 2 Feb 2019 01:47:31 -0800 (PST) X-Google-Smtp-Source: ALg8bN4qRZUrphmaQgUJ2avK2cB/fZzstz0U8rbtjJS3P6chwjXmE23nt+3ebDfMSZnXjiQjDE1J X-Received: by 2002:a17:902:346:: with SMTP id 64mr44297449pld.337.1549100851057; Sat, 02 Feb 2019 01:47:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549100851; cv=none; d=google.com; s=arc-20160816; b=w9A/yuGVc114RxunPOVI/H4wfIc+wop8A+5aDoEdbLuO9SboJa41Wd+AxdV25kCC2d GGUO1JWeuM/MH13TueiAfFLA08FEnuDyI85YPq/IPv07NoeVDK+8tLiHgHrFqANen3Ho 8Xm9JjVFxSK42HdToJEAYhQ3vEBnNOp4xosoAHM6wvq/drss/hC5/ZhekKzrF1YVJXbf 738edrkl/kpG4HZszp8xO21wvispRkBvxI13iBXsfUCPRFLFrn5OLM0Bdh2KLvzlKfqY KjbWjCkRIaNsOXoX59QS9ydN17ZPA+dvKJcHyiRAw7soiJBgKnQsEm16Xc8ZaQzwGkNL 80Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date; bh=3cn99Rg9p3IdY+0wytXPNn82ZuJbLWh2CYe1KYhqGJM=; b=IcztG3+8Rdry6ElPdPGNn3javZGpXsar9gkhDoqQubW2sERlTyP9Pjxht2nio9iODL WDP6ovFSwjKlcVHlmy2VPwaYMkww5VUNHpehgbLa9Z5rc+6r8lRZ0Oygqrqb5xoWH0Rq +MRcYiP58COeeHVXrlynLy4tpcWz60ObHwP6+enKxVc75BGslvoVwIsnf+zCnyxe1DHW nB1AYx9PeJPoQ1ZNA8wF62f7UqiWzukQxmW/kZa1ycuM6HWEnCXwv4rtto9qnU8NFWR2 RuW0qnguhu5S0lHT+8duO8sGVU+olK8yviX4h/DQG95POSvcjDmMecYGDLUN5gyq98l3 Y1rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w6si9849840pfb.191.2019.02.02.01.47.14; Sat, 02 Feb 2019 01:47:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727316AbfBBJqy (ORCPT + 99 others); Sat, 2 Feb 2019 04:46:54 -0500 Received: from terminus.zytor.com ([198.137.202.136]:35163 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726757AbfBBJqy (ORCPT ); Sat, 2 Feb 2019 04:46:54 -0500 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x129jxp33715541 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 2 Feb 2019 01:45:59 -0800 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x129juko3715527; Sat, 2 Feb 2019 01:45:56 -0800 Date: Sat, 2 Feb 2019 01:45:56 -0800 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Johannes Weiner Message-ID: Cc: mingo@redhat.com, fenghua.yu@intel.com, kirill.shutemov@linux.intel.com, reinette.chatre@intel.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, peterz@infradead.org, hannes@cmpxchg.org, james.morse@arm.com, puwen@hygon.cn, corbet@lwn.net, hpa@zytor.com, x86@kernel.org, bp@suse.de, mingo@kernel.org, Babu.Moger@amd.com, tglx@linutronix.de Reply-To: Babu.Moger@amd.com, tglx@linutronix.de, x86@kernel.org, mingo@kernel.org, bp@suse.de, puwen@hygon.cn, hpa@zytor.com, corbet@lwn.net, peterz@infradead.org, james.morse@arm.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, reinette.chatre@intel.com, kirill.shutemov@linux.intel.com, fenghua.yu@intel.com, mingo@redhat.com In-Reply-To: <20190130195621.GA30653@cmpxchg.org> References: <20190130195621.GA30653@cmpxchg.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/resctrl: Avoid confusion over the new X86_RESCTRL config Git-Commit-ID: e6d429313ea5c776d2e76b4494df69102e6b7115 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_DATE_IN_FUTURE_96_Q autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: e6d429313ea5c776d2e76b4494df69102e6b7115 Gitweb: https://git.kernel.org/tip/e6d429313ea5c776d2e76b4494df69102e6b7115 Author: Johannes Weiner AuthorDate: Tue, 29 Jan 2019 17:44:36 -0500 Committer: Borislav Petkov CommitDate: Sat, 2 Feb 2019 10:34:52 +0100 x86/resctrl: Avoid confusion over the new X86_RESCTRL config "Resource Control" is a very broad term for this CPU feature, and a term that is also associated with containers, cgroups etc. This can easily cause confusion. Make the user prompt more specific. Match the config symbol name. [ bp: In the future, the corresponding ARM arch-specific code will be under ARM_CPU_RESCTRL and the arch-agnostic bits will be carved out under the CPU_RESCTRL umbrella symbol. ] Signed-off-by: Johannes Weiner Signed-off-by: Borislav Petkov Cc: Babu Moger Cc: Fenghua Yu Cc: "H. Peter Anvin" Cc: Ingo Molnar Cc: James Morse Cc: Jonathan Corbet Cc: "Kirill A. Shutemov" Cc: linux-doc@vger.kernel.org Cc: Peter Zijlstra Cc: Pu Wen Cc: Reinette Chatre Cc: Thomas Gleixner Cc: Tony Luck Cc: x86-ml Link: https://lkml.kernel.org/r/20190130195621.GA30653@cmpxchg.org --- Documentation/x86/resctrl_ui.txt | 2 +- arch/x86/Kconfig | 6 +++--- arch/x86/include/asm/resctrl_sched.h | 4 ++-- arch/x86/kernel/cpu/Makefile | 2 +- arch/x86/kernel/cpu/resctrl/Makefile | 4 ++-- include/linux/sched.h | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Documentation/x86/resctrl_ui.txt b/Documentation/x86/resctrl_ui.txt index e8e8d14d3c4e..c1f95b59e14d 100644 --- a/Documentation/x86/resctrl_ui.txt +++ b/Documentation/x86/resctrl_ui.txt @@ -9,7 +9,7 @@ Fenghua Yu Tony Luck Vikas Shivappa -This feature is enabled by the CONFIG_X86_RESCTRL and the x86 /proc/cpuinfo +This feature is enabled by the CONFIG_X86_CPU_RESCTRL and the x86 /proc/cpuinfo flag bits: RDT (Resource Director Technology) Allocation - "rdt_a" CAT (Cache Allocation Technology) - "cat_l3", "cat_l2" diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 26387c7bf305..68261430fe6e 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -446,12 +446,12 @@ config RETPOLINE branches. Requires a compiler with -mindirect-branch=thunk-extern support for full protection. The kernel may run slower. -config X86_RESCTRL - bool "Resource Control support" +config X86_CPU_RESCTRL + bool "x86 CPU resource control support" depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD) select KERNFS help - Enable Resource Control support. + Enable x86 CPU resource control support. Provide support for the allocation and monitoring of system resources usage by the CPU. diff --git a/arch/x86/include/asm/resctrl_sched.h b/arch/x86/include/asm/resctrl_sched.h index 40ebddde6ac2..f6b7fe2833cc 100644 --- a/arch/x86/include/asm/resctrl_sched.h +++ b/arch/x86/include/asm/resctrl_sched.h @@ -2,7 +2,7 @@ #ifndef _ASM_X86_RESCTRL_SCHED_H #define _ASM_X86_RESCTRL_SCHED_H -#ifdef CONFIG_X86_RESCTRL +#ifdef CONFIG_X86_CPU_RESCTRL #include #include @@ -88,6 +88,6 @@ static inline void resctrl_sched_in(void) static inline void resctrl_sched_in(void) {} -#endif /* CONFIG_X86_RESCTRL */ +#endif /* CONFIG_X86_CPU_RESCTRL */ #endif /* _ASM_X86_RESCTRL_SCHED_H */ diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile index b6fa0869f7aa..cfd24f9f7614 100644 --- a/arch/x86/kernel/cpu/Makefile +++ b/arch/x86/kernel/cpu/Makefile @@ -39,7 +39,7 @@ obj-$(CONFIG_CPU_SUP_UMC_32) += umc.o obj-$(CONFIG_X86_MCE) += mce/ obj-$(CONFIG_MTRR) += mtrr/ obj-$(CONFIG_MICROCODE) += microcode/ -obj-$(CONFIG_X86_RESCTRL) += resctrl/ +obj-$(CONFIG_X86_CPU_RESCTRL) += resctrl/ obj-$(CONFIG_X86_LOCAL_APIC) += perfctr-watchdog.o diff --git a/arch/x86/kernel/cpu/resctrl/Makefile b/arch/x86/kernel/cpu/resctrl/Makefile index 1cabe6fd8e11..4a06c37b9cf1 100644 --- a/arch/x86/kernel/cpu/resctrl/Makefile +++ b/arch/x86/kernel/cpu/resctrl/Makefile @@ -1,4 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_X86_RESCTRL) += core.o rdtgroup.o monitor.o -obj-$(CONFIG_X86_RESCTRL) += ctrlmondata.o pseudo_lock.o +obj-$(CONFIG_X86_CPU_RESCTRL) += core.o rdtgroup.o monitor.o +obj-$(CONFIG_X86_CPU_RESCTRL) += ctrlmondata.o pseudo_lock.o CFLAGS_pseudo_lock.o = -I$(src) diff --git a/include/linux/sched.h b/include/linux/sched.h index 224666226e87..8c328b14c424 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -995,7 +995,7 @@ struct task_struct { /* cg_list protected by css_set_lock and tsk->alloc_lock: */ struct list_head cg_list; #endif -#ifdef CONFIG_X86_RESCTRL +#ifdef CONFIG_X86_CPU_RESCTRL u32 closid; u32 rmid; #endif