Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp1885467ima; Sat, 2 Feb 2019 09:23:01 -0800 (PST) X-Google-Smtp-Source: ALg8bN5dE+VKMQMq46LeRe3kyCYmaLcc6pul2a27WYG1dj7fu6bzfmTKNWyyESAixCT2cTnVd9MD X-Received: by 2002:a17:902:4464:: with SMTP id k91mr45102010pld.13.1549128181318; Sat, 02 Feb 2019 09:23:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549128181; cv=none; d=google.com; s=arc-20160816; b=sLMw7AuOCfNPOhMJL7oS7ViQ+QCAHYLFyo4UtowVJZdxjRJkIyY9qqd6LQfgDo3MGI gpAlxog3tlLmBGKCeFpFvpZMeC2HfEA+3TFXdvC1dSUmwQrNiriCvyN4pHtk1SfEi1mq GgjNqb0LaMS9YQZrfc79S6N3/XBRBIudhtHZtu3oRoOkXlo5GedDMErqy077Lxa2QIqh Zk2qiq6QQqTV74cyRraxlR+JbgvyAdmceM5B/tMEoy4bo+WwaKdRPSbVqbk/0PV+Y+wJ +TbmLYt5WnMPx3N/WfG04+hnYC/TF5JvxJp+pCTmuCaGAbnlaLz8nojoB1tY5KNypku/ X7Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=lcSTAHIXIO6U5/zoDvIpgtcishpq78yT0Kyl0/r+/mc=; b=xRhLGXiaaFoVMrWos4NcreKP8uBrMvJSoL8ClpY/fNqW1ZIHspmVKJyHwehSy4H06F KW4JA8jkRMoG3ccGl7RffAJpeGi4/rdm6l5PPFaH6BvjrnN0MSqm3CSishkJQTJbFqFq UgOiA2zDvUrMLeZGARaQ5V7i+T42PqLRt+zxz3lKaxDj6ZMrBTjKEx5GNOzW+PDGgXJM ooAW6rw8QcZxEfPZjKu3qVP+enJwoLB24IhDI7y18MsqVgf766kb+6lTvyncFJGOZ87k GIuuVGxyXl94hPkGRnQaoagSY7VWf+k4czsYaV5b4tPFdWuMfwpJTvz5b0LpI91HUqqn /1ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3si10800747pld.36.2019.02.02.09.22.45; Sat, 02 Feb 2019 09:23:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726585AbfBBRVY (ORCPT + 99 others); Sat, 2 Feb 2019 12:21:24 -0500 Received: from verein.lst.de ([213.95.11.211]:40557 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbfBBRVX (ORCPT ); Sat, 2 Feb 2019 12:21:23 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 4785368CEB; Sat, 2 Feb 2019 18:21:21 +0100 (CET) Date: Sat, 2 Feb 2019 18:21:21 +0100 From: Christoph Hellwig To: Vinod Koul Cc: Christoph Hellwig , John Crispin , Dmitry Tarnyagin , Nicolas Ferre , Sudip Mukherjee , Felipe Balbi , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH 02/18] dmaengine: imx-sdma: pass struct device to DMA API functions Message-ID: <20190202172121.GA3739@lst.de> References: <20190201084801.10983-1-hch@lst.de> <20190201084801.10983-3-hch@lst.de> <20190202101121.GE4296@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190202101121.GE4296@vkoul-mobl> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 02, 2019 at 03:41:21PM +0530, Vinod Koul wrote: > On 01-02-19, 09:47, Christoph Hellwig wrote: > > The DMA API generally relies on a struct device to work properly, and > > only barely works without one for legacy reasons. Pass the easily > > available struct device from the platform_device to remedy this. > > This looks good to me but fails to apply. Can you please base it on > dmaengine-next or linux-next please and resend commit ceaf52265148d3a5ca24237fd1c709caa5f46184 Author: Andy Duan Date: Fri Jan 11 14:29:49 2019 +0000 dmaengine: imx-sdma: pass ->dev to dma_alloc_coherent() API in linux-next actually is equivalent to this patch, so we can drop this one. > > Thanks > -- > ~Vinod ---end quoted text---