Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp1894132ima; Sat, 2 Feb 2019 09:32:57 -0800 (PST) X-Google-Smtp-Source: AHgI3IYvqyACOV1iGc/lDj0eJHbTTwq0bQ+hIGuHXUDtyLGR5B4/ZzXC8Fydgz4K1REPu9xGha1G X-Received: by 2002:a63:170c:: with SMTP id x12mr6670243pgl.364.1549128777646; Sat, 02 Feb 2019 09:32:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549128777; cv=none; d=google.com; s=arc-20160816; b=LHlDNQ+Di4EpNDrCjpL4OfpCnUQbQPRvNPJnjPX8uo847xPeLLlIz0qurNXiAJ+vJL +bGPefReECnXrmqobWMx50RR/CWpstWRfoHdDYIRBOMUVsjAxlnMCNHXoMrIPmgYB1Hg QvwNb5KeyRhtk3Mye2/X1FJn90118hAIKGicGFn1gllkAJ4Vz1SUBXm1B7ApvNKby92o HGbOfKYzSXRc3OOW+9ttAVZf/H/6LSM9g8uDFg6p6SZliOQexsbMZAw3krIG5GPRK7cs 7L5p2O2s5CnuEXRUyVE23rij1KDQPMPjDGsfLi5NKyL6c1nwzEptr8IuMV+GDbW8wHVO tQMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3xu71e3Cn2CfjZBhaICEDB1igaFLcpFkc5SNMDya+Xg=; b=QzW5WPlWunhQZzTTNyWsgvHIq6DZDGXLzjPFm+M1MO4DZp9emnq1+ikr2CVQpXgOhE GQJkppi00EZupw8mUURBCYrV3h+DhRNHtRHG4y4fSPm0u7jy7aUUkPRJzsKGu9NI68gO jPJwiUwj8+GR5UXSiUFhxZg+aPIwSdxNENEKc6zkooq4QCRhWz/tHVSDn1r8oWghPYvs v5UMYb0Q6rOOhR1ZwjkM1MGc7Wk3DPQt/N0BJ6h0ZNS9BPUJHkcCxc45ZkXABnPbKcfx 6pjlnww3MrqcZyjbHnHZPPIyB8cqg+bJOEBZsxQTQFsjR9smNMx3hJccrDwxIG52cUQR RIiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ECjsgS/g"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y10si7201503plt.406.2019.02.02.09.32.41; Sat, 02 Feb 2019 09:32:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ECjsgS/g"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726449AbfBBRcS (ORCPT + 99 others); Sat, 2 Feb 2019 12:32:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:60236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbfBBRcS (ORCPT ); Sat, 2 Feb 2019 12:32:18 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F3912085A; Sat, 2 Feb 2019 17:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549128737; bh=3xu71e3Cn2CfjZBhaICEDB1igaFLcpFkc5SNMDya+Xg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ECjsgS/gj4MtK2OQZtQJmTB+uajhQAQjqot4NYwczIxBAil53FEfxa2sKhQyLOua2 AknTIXksKBzgzkSXoNe9DmLAtk2a/k+iaCNPkzl7jcD3dNnqxskAE29TD/chyfBxwM AwS+kpoTKuFbcRGY6R1y8oLmSZonyjPcwpT/fLpw= Date: Sat, 2 Feb 2019 12:32:16 -0500 From: Sasha Levin To: Sean Paul Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sean Paul , dri-devel@lists.freedesktop.org Subject: Re: [PATCH AUTOSEL 4.19 083/258] drm: Move drm_mode_setcrtc() local re-init to failure path Message-ID: <20190202173216.GZ3973@sasha-vm> References: <20190128155924.51521-1-sashal@kernel.org> <20190128155924.51521-83-sashal@kernel.org> <20190128210341.GT114153@art_vandelay> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190128210341.GT114153@art_vandelay> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 28, 2019 at 04:03:41PM -0500, Sean Paul wrote: >On Mon, Jan 28, 2019 at 10:56:29AM -0500, Sasha Levin wrote: >> From: Sean Paul >> >> [ Upstream commit c232e9f41b136c141df9938024e521191a7b910d ] >> >> Instead of always re-initializing the variables we need to clean up on >> out, move the re-initialization into the branch that goes back to retry >> label. >> >> This is a lateral move right now, but will allow us to pull out the >> modeset locking into common code. I kept this change separate to make >> things easier to review. >> >> Changes in v2: >> - None >> >> Reviewed-by: Daniel Vetter >> Signed-off-by: Sean Paul >> Link: https://patchwork.freedesktop.org/patch/msgid/20181129150423.239081-2-sean@poorly.run >> Signed-off-by: Sasha Levin > >This probably doesn't need to get pulled back to stable. It was a pre-cursor for >some new helper macros that also don't need to be pulled back. > >(Same comment for the 4.20 version) Now dropped, thank you. -- Thanks, Sasha