Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 2 Feb 2019 14:30:50 -0500
From:   Sasha Levin <sashal@kernel.org>
To:     Reinette Chatre <reinette.chatre@intel.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Babu Moger <Babu.Moger@amd.com>, Borislav Petkov <bp@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Brijesh Singh <brijesh.singh@amd.com>,
        "Chang S. Bae" <chang.seok.bae@intel.com>,
        David Miller <davem@davemloft.net>,
        David Woodhouse <dwmw2@infradead.org>,
        Dmitry Safonov <dima@arista.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
        Jann Horn <jannh@google.com>, Joerg Roedel <jroedel@suse.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        linux-doc@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Pu Wen <puwen@hygon.cn>, qianyue.zj@alibaba-inc.com,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Rian Hunter <rian@alum.mit.edu>,
        Sherry Hurwitz <sherry.hurwitz@amd.com>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Thomas Lendacky <Thomas.Lendacky@amd.com>,
        Tony Luck <tony.luck@intel.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>, xiaochen.shen@intel.com
Subject: Re: [PATCH AUTOSEL 4.19 059/258] x86/resctrl: Fixup the user-visible
 strings
Message-ID: <20190202193050.GA3973@sasha-vm>
References: <20190128155924.51521-1-sashal@kernel.org>
 <20190128155924.51521-59-sashal@kernel.org>
 <c9c45e03-aef3-e1be-2c81-d903a1669499@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <c9c45e03-aef3-e1be-2c81-d903a1669499@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 28, 2019 at 11:07:34AM -0800, Reinette Chatre wrote:
>Hi Sasha,
>
>On 1/28/2019 7:56 AM, Sasha Levin wrote:
>> From: Babu Moger <Babu.Moger@amd.com>
>>
>> [ Upstream commit 723f1a0dd8e26a7523ba068204bee11c95ded38d ]
>>
>> Fix the messages in rdt_last_cmd_printf() and rdt_last_cmd_puts() to
>> make them more meaningful and consistent.
>
>It is not clear to me why this patch is considered for stable since it
>just changes user visible strings to be more consistent.
>
>If user visible string consistency/correctness is of concern and is what
>prompted its consideration then please also consider to include upstream
>commit
>456824896de2b68df40b3ea5777ef49dc6cc8fda "x86/resctrl: Use
>rdt_last_cmd_puts() where possible" that fixes two typos that was
>introduced in this commit. This may introduce difficultly though since
>the file layout changed between the kernel versions these patches are
>found in.

I've dropped it, it shouldn't have been included to begin with.

--
Thanks,
Sasha