Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp2493940ima; Sun, 3 Feb 2019 00:27:36 -0800 (PST) X-Google-Smtp-Source: ALg8bN4jKbepLNJuL546U/fSZDcbgJJ7iqXqqnOmV4ED9LHDkKUeIgTPOQSaBHVHwAlhs43XJlul X-Received: by 2002:a62:cf02:: with SMTP id b2mr48131330pfg.183.1549182456472; Sun, 03 Feb 2019 00:27:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549182456; cv=none; d=google.com; s=arc-20160816; b=C81ePqFEgkUscny1jqAkGIG1AJ8L755h88zI3hCbvPfvMTqP9S5CrRFR+fFhHEuFog 2SW2HIhACSOSLoQr71BJ4viQdYJKaEfDg4MS9qcuMEcFgRBEJgaqtAZ8tHTbiXQSyZem BccrcH6ztO6sqBZCw4qGMKQAIHgvyIi6W+BtIg1/LYoaDohSVR4kI2kDRljV6wtTvcfE fyAxKkjf/eSceQzc6Cn4rPltRaGFX8W5E/0VjzRMzf1upVHlYZ1h3g/NAswgcLMB6Aa9 IE4oAshclmcdaAACaSjRZ8jgLJ1tLhZ5InMd6WZAlf7nbXQy6932SlY3zjxvPO4bRehp 9Dgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=8uCmlSp16gKMDnusLKvVx6IKhoUBCSm96hT9h13dlW4=; b=y6DA51krRFVQ9fLBgoWSbuppcj9zCqe4J3Z6mmunkH37VNMvJ2y0MLFVA0k2a9xCHe fvADPzU9KoUP4Jlfp/RweBSjqOOw/+jPDrA2xqzoFpFK8A9UXwX8l1B7PxdiuyRVZ9Hl Pu9HdEg6q4cWRYanxJidX23kjzK6TtwukwCXN8dV/b7LllI3T2eZ2x+gHX+rfuGq72Xy voDrjsIJ1aaSfYQjMeiKOqNSG4KrUSwjRZagSXu9cpoy1z8+6PgO5yjBdmjpLyc1xZps gYDfK6Bm6q01ZWe9sJiiq220AcnkTxLLrQefc4BLpdn2eA/z62nMg69QWgeHGCeZHscc GOhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RO18rxKk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r138si11817990pgr.58.2019.02.03.00.27.18; Sun, 03 Feb 2019 00:27:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RO18rxKk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727362AbfBCI05 (ORCPT + 99 others); Sun, 3 Feb 2019 03:26:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:56288 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727025AbfBCI05 (ORCPT ); Sun, 3 Feb 2019 03:26:57 -0500 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39E872082F; Sun, 3 Feb 2019 08:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549182416; bh=sPnfI1HNhCXOHLUc8pSc16PhXZwrm6oKPdZf9ZEUWbM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RO18rxKkk+tXgeBB3Qmx0XUEp/h2wGbITtZ4Vkm1Dkl2EQij+Fh65Agjv9AQr9ZqP IrgXD/N6Va0vME2yEJ2/iytGgdhUmCHD7kmmH1Nr5lSB3kNM/IJKyBOHZK6yVGtRyz wfGd5PGfh2LArdn1N0OI+8++gHK2GvzQa6qWOEEA= Date: Sun, 3 Feb 2019 09:26:45 +0100 From: Boris Brezillon To: Liu Jian Cc: , , , , , , , , , Przemyslaw Sobon Subject: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer Message-ID: <20190203092645.18d1495b@bbrezillon> In-Reply-To: <1548977439-318904-1-git-send-email-liujian56@huawei.com> References: <1548977439-318904-1-git-send-email-liujian56@huawei.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Przemyslaw On Fri, 1 Feb 2019 07:30:39 +0800 Liu Jian wrote: > In function do_write_buffer(), in the for loop, there is a case > chip_ready() returns 1 while chip_good() returns 0, so it never > break the loop. > To fix this, chip_good() is enough and it should timeout if it stay > bad for a while. Looks like Przemyslaw reported and fixed the same problem. > > Fixes: dfeae1073583(mtd: cfi_cmdset_0002: Change write buffer to check > correct value) Can you put the Fixes tag on a single, and the format is Fixes: ("message") > Signed-off-by: Yi Huaijie > Signed-off-by: Liu Jian [1]http://patchwork.ozlabs.org/patch/1025566/ > --- > drivers/mtd/chips/cfi_cmdset_0002.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c > index 72428b6..818e94b 100644 > --- a/drivers/mtd/chips/cfi_cmdset_0002.c > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c > @@ -1876,14 +1876,14 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, > continue; > } > > - if (time_after(jiffies, timeo) && !chip_ready(map, adr)) > - break; > - > if (chip_good(map, adr, datum)) { > xip_enable(map, chip, adr); > goto op_done; > } > > + if (time_after(jiffies, timeo)) > + break; > + > /* Latency issues. Drop the lock, wait a while and retry */ > UDELAY(map, chip, adr, 1); > }