Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp2753547ima; Sun, 3 Feb 2019 06:10:23 -0800 (PST) X-Google-Smtp-Source: AHgI3Ia7TI3UwOGqq/QHgs9Fsf3jcsfjhfdh2aZOwwZh2GT8Bb852s/ysQTKim6ZhBnVv+97Ya9L X-Received: by 2002:a63:fd53:: with SMTP id m19mr9672434pgj.340.1549203023282; Sun, 03 Feb 2019 06:10:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549203023; cv=none; d=google.com; s=arc-20160816; b=Zz84p3K4BRSu+OCq1iJVL/LoVwL6JcPgaPYPJRWeKz84o1Rila/WRoyNvXOSf0wOc2 BTLR4QdZ4za9TVqDDAPvkXu8lPqn8PnJTr+CUfdEtO9cM1zf2Hwvvmr3I2KdI4KxkYQG x2uiPgMBY38H9LMryjnD3qTQSoE/KlZEv3M8C4rCXg7ceilaS8PenYX87bIdBzsiTdww B6bGVtCPeJSEN3zaJ/TXCBlQeRqRzHPW00rKWAI1MIxy0rqTsZ1j5bUs+PP2mo187XLz VWXUPVX6kA2+EqHYbZPwD9oRS0Bf8lQfDMbg37aoXSMWLWSe1AR4L+GEXBaBbmrZlYrK Jerg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=7aJMab/u6mtz2hW9K+pDYI/lpLpsYHnOclKMruISOuQ=; b=FWT4UwgMBEuP+JIkYMaZD4433EcybPWevbcaU3LVd6Rwth9RVSXtrKAdDjxH3dasmQ z1GN6MXap9mrFlXbygad9Zo8qRtT83PZyerJ19bAU7TL4aw1ADi7ueBJwDI1HAzGWQVi CFd43mWH17kgdNa7dtwmIU3WvilL3uuL4/9lcvYstBl33A+8gsBawqassI4u3l9NRffb DDfeUv+WnvjfgOnEdwIOv/OrzbWdRfdHgs+L29pXzdLyDRNweFatCf0IXGmqO1KUHXJf pupGo0Z9m4ufTR0hi8AXNLUEzzXTV5FnLsIyWsQeaIg6ij99c9mmdvNbXTqJyfaePvDM LZaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BANXZKK+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12si13016405plt.213.2019.02.03.06.10.06; Sun, 03 Feb 2019 06:10:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BANXZKK+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727904AbfBCOIm (ORCPT + 99 others); Sun, 3 Feb 2019 09:08:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:42864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727800AbfBCOIl (ORCPT ); Sun, 3 Feb 2019 09:08:41 -0500 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E044520823; Sun, 3 Feb 2019 14:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549202921; bh=m578Ap1IUsphbWMvNDrbrmxIuE2xsjsUOTEcjHWuwH4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BANXZKK+cidl6/sTGKBGEB2LRUXnKPhKCYwUENqEkDdcgHVSwFCtZgGkt6fTA/ptF 39En1pB+Q79lBOQEVEJv9BCVt6VVenAz2ve0efFnfQ0F00d8QQvNJYphMK182A/rJ3 u3HTarSmSrrLcVoglAY19VjzeS7q7iH88/FbXcCc= Date: Sun, 3 Feb 2019 15:08:27 +0100 From: Boris Brezillon To: Paul Cercueil Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland , Miquel Raynal , Harvey Hunt , Mathieu Malaterre , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/9] mtd: rawnand: jz4780: Add support for the JZ4740 Message-ID: <20190203150827.401ac31d@bbrezillon> In-Reply-To: <1549202213.1950.1@crapouillou.net> References: <20190202231926.2444-1-paul@crapouillou.net> <20190202231926.2444-5-paul@crapouillou.net> <20190203083151.4fc29c5b@bbrezillon> <1549202213.1950.1@crapouillou.net> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 03 Feb 2019 10:56:53 -0300 Paul Cercueil wrote: > Le dim. 3 f=C3=A9vr. 2019 =C3=A0 4:31, Boris Brezillon =20 > a =C3=A9crit : > > On Sat, 2 Feb 2019 20:19:21 -0300 > > Paul Cercueil wrote: > > =20 > >> Add support for probing the jz4780-nand driver on the JZ4740 SoC=20 > >> from > >> Ingenic. > >>=20 > >> Signed-off-by: Paul Cercueil > >> --- > >>=20 > >> Changes: > >>=20 > >> v2: - Add support for the JZ4740 and not the JZ4725B: they behave=20 > >> the > >> same, and JZ4740 is fully upstream while JZ4725B is not. The > >> JZ4725B devicetree will then simply use the=20 > >> "ingenic,jz4740-nand" > >> compatible string. > >> - Fix the number of bytes for the ECC when the ECC strength is=20 > >> 4. > >> This is needed for the JZ4740, which uses Reed-Solomon=20 > >> instead of > >> BCH. > >>=20 > >> drivers/mtd/nand/raw/ingenic/jz4780_nand.c | 48=20 > >> +++++++++++++++++----- =20 > >=20 > > If we're going to make the driver compatible with jz4740 and jz4725b > > maybe we should rename the source files jz47xx_{nand,bch}.{c,h}. =20 >=20 > I don't know about that. Adding support for new hardware isn't a good=20 > reason to > rename the driver, or so I've been told around here, as you then make=20 > it harder > to review the git history of the driver. You already move files to a sub-directory so that doesn't make a huge difference, history will be hard to follow because of this move anyway.