Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 3 Feb 2019 15:16:04 +0100
From:   Boris Brezillon <bbrezillon@kernel.org>
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Harvey Hunt <harveyhuntnexus@gmail.com>,
        Mathieu Malaterre <malat@debian.org>,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 9/9] mtd: rawnand: jz4780-bch: Add support for the
 JZ4740
Message-ID: <20190203151604.23061e2a@bbrezillon>
In-Reply-To: <1549202293.1950.2@crapouillou.net>
References: <20190202231926.2444-1-paul@crapouillou.net>
        <20190202231926.2444-10-paul@crapouillou.net>
        <20190203083505.4dc52278@bbrezillon>
        <1549202293.1950.2@crapouillou.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 03 Feb 2019 10:58:13 -0300
Paul Cercueil <paul@crapouillou.net> wrote:

> Le dim. 3 f=C3=A9vr. 2019 =C3=A0 4:35, Boris Brezillon <bbrezillon@kernel=
.org>=20
> a =C3=A9crit :
> > On Sat,  2 Feb 2019 20:19:26 -0300
> > Paul Cercueil <paul@crapouillou.net> wrote:
> >  =20
> >>  Add the backend code for the jz4780-bch driver to support the JZ4740
> >>  SoC from Ingenic.
> >>=20
> >>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> >>  ---
> >>=20
> >>  Changes:
> >>=20
> >>  v2: New patch
> >>=20
> >>   drivers/mtd/nand/raw/ingenic/Makefile         |   2 +-
> >>   drivers/mtd/nand/raw/ingenic/jz4740_bch.c     | 173=20
> >> ++++++++++++++++++
> >>   .../mtd/nand/raw/ingenic/jz4780_bch_common.c  |   1 +
> >>   .../nand/raw/ingenic/jz4780_bch_internal.h    |   1 +
> >>   4 files changed, 176 insertions(+), 1 deletion(-)
> >>   create mode 100644 drivers/mtd/nand/raw/ingenic/jz4740_bch.c
> >>=20
> >>  diff --git a/drivers/mtd/nand/raw/ingenic/Makefile=20
> >> b/drivers/mtd/nand/raw/ingenic/Makefile
> >>  index f38b467490cf..d16c96113a93 100644
> >>  --- a/drivers/mtd/nand/raw/ingenic/Makefile
> >>  +++ b/drivers/mtd/nand/raw/ingenic/Makefile
> >>  @@ -1,3 +1,3 @@
> >>   obj-$(CONFIG_MTD_NAND_JZ4740) +=3D jz4740_nand.o
> >>   obj-$(CONFIG_MTD_NAND_JZ4780) +=3D jz4780_nand.o jz4780_bch_common.o=
=20
> >> \
> >>  -				 jz4780_bch.o jz4725b_bch.o
> >>  +				 jz4780_bch.o jz4725b_bch.o jz4740_bch.o =20
> >=20
> > I still don't see the point of the jz4780_bch_common/jz47xxx_bch
> > separation. You seem to always embed all objects anyway, so you can
> > just put the code for both engines in the same source file and decide
> > which one to use based on the compat (which you already do anyway). =20
>=20
> Each SoC has a different set of registers for the BCH hardware. I can=20
> try to
> cram everything into one file, but it won't be that much cleaner.

Then maybe they deserve separate drivers/modules.

BTW, didn't you say that one IP uses Reed-Salomon instead of BCH. I'd
suggest prefixing structs and functions with jz47xx_ecc instead of
jz47xx_bch and naming the common part jz47xx_ecc.c to reflect that.