Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp2769390ima; Sun, 3 Feb 2019 06:26:07 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibr1j4uvWdg0anRTdKB4xUaiH/NXIZ6tF+SWrr19Ua/TMMAV/4o++o2o02P2q7COE/q5zAg X-Received: by 2002:a63:dd15:: with SMTP id t21mr9276607pgg.347.1549203967125; Sun, 03 Feb 2019 06:26:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549203967; cv=none; d=google.com; s=arc-20160816; b=IM28oqNB1oHFKeOIo6s1ZQBY/2fohFiOYYhYCdB041qj3dLPvU+Hr16C7Watim3RVH eqCqcs4We4MXoZ6xj9Ed2mAAZfBruBY61UXi9uyfMzln1VAcctR4X7759XxqcBz4hxZy eTJm8Zj36gSo3LwaIknHCuEs73JBQqye1Up5Nm7e4yFGZVVPEISNA9sQIWA8ELcBUFQl zFdmGm67WBVrxBsCSmx9OchgayanW9j+AO789KYYG3hOcl5Cak3uFQ41O/Y4EIJ9OjxC ubzaTf4iWZjMF6FENB4d2R1NDFmoFREXYP5zmW9DUPkX9cJjtbFDKSUKf3GVzxewNMgs ARbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=r/NZgJEgZrE/Stuj9mL8Wr8FvxpCXNerpWAnWl3ObuA=; b=ydK6AadjVwJCxu+keyys1yQNrlLhdtdqaCff2COQUhvrFW1OOnZc9CtP2enqaZ4y6n V95P6jPI85BvoRz90oWIorthrpZNrYW9OLfPYEl/oD7qaV7V6HagwWe2RJItOL4Po3nS RXceBZvrq+eeCPxfRYhXKAvpGKZrLvP+hR9HUhx+q5J+3HIQUnpuosrtiVtW9Jb1GJU9 8p6Fjb3cjKLlJokIk2ASV+NV12/1c+7087YmKc95985XEmjpC+EqapL2OywOT707rYAd 2WoSuR6IS1XYBKupUbdPpHDD6PYWSVIib8KPLGz1wkOMEZMrye3mBvN0jqrvKGpPlTwR 6nuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hcoRJHeB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f6si4340891pgc.509.2019.02.03.06.25.51; Sun, 03 Feb 2019 06:26:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hcoRJHeB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729725AbfBCOYZ (ORCPT + 99 others); Sun, 3 Feb 2019 09:24:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:50606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730853AbfBCOYV (ORCPT ); Sun, 3 Feb 2019 09:24:21 -0500 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93F102084A; Sun, 3 Feb 2019 14:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549203860; bh=PrXer47KHA40S2YqkSEELxve4hCip8gF445pVwtHm/A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hcoRJHeBfU6/8YFjJ+eMaI36hMnLgWme4GDaDwPLJYkv7Z2//AjQyqgy+16cuzsa7 xZAozvNWZT4Q7s0acQL6qHjJbO68085xsYrXXyomhXx1/ju+gTQxKC6xVesbCkDP/5 WggQQaxTLhHgWd8XA6qeBt7L/nnm9qyqxZFBG5So= Date: Sun, 3 Feb 2019 15:24:08 +0100 From: Boris Brezillon To: Paul Cercueil Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland , Miquel Raynal , Harvey Hunt , Mathieu Malaterre , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/9] mtd: rawnand: jz4780: Add support for the JZ4740 Message-ID: <20190203152408.2795de7e@bbrezillon> In-Reply-To: <1549203050.1950.3@crapouillou.net> References: <20190202231926.2444-1-paul@crapouillou.net> <20190202231926.2444-5-paul@crapouillou.net> <20190203083151.4fc29c5b@bbrezillon> <1549202213.1950.1@crapouillou.net> <20190203150827.401ac31d@bbrezillon> <1549203050.1950.3@crapouillou.net> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 03 Feb 2019 11:10:50 -0300 Paul Cercueil wrote: > Le dim. 3 f=C3=A9vr. 2019 =C3=A0 11:08, Boris Brezillon =20 > a =C3=A9crit : > > On Sun, 03 Feb 2019 10:56:53 -0300 > > Paul Cercueil wrote: > > =20 > >> Le dim. 3 f=C3=A9vr. 2019 =C3=A0 4:31, Boris Brezillon=20 > >> > >> a =C3=A9crit : =20 > >> > On Sat, 2 Feb 2019 20:19:21 -0300 > >> > Paul Cercueil wrote: > >> > =20 > >> >> Add support for probing the jz4780-nand driver on the JZ4740 SoC > >> >> from > >> >> Ingenic. > >> >> > >> >> Signed-off-by: Paul Cercueil > >> >> --- > >> >> > >> >> Changes: > >> >> > >> >> v2: - Add support for the JZ4740 and not the JZ4725B: they =20 > >> behave =20 > >> >> the > >> >> same, and JZ4740 is fully upstream while JZ4725B is not. = =20 > >> The =20 > >> >> JZ4725B devicetree will then simply use the > >> >> "ingenic,jz4740-nand" > >> >> compatible string. > >> >> - Fix the number of bytes for the ECC when the ECC strength = =20 > >> is =20 > >> >> 4. > >> >> This is needed for the JZ4740, which uses Reed-Solomon > >> >> instead of > >> >> BCH. > >> >> > >> >> drivers/mtd/nand/raw/ingenic/jz4780_nand.c | 48 > >> >> +++++++++++++++++----- =20 > >> > > >> > If we're going to make the driver compatible with jz4740 and =20 > >> jz4725b =20 > >> > maybe we should rename the source files jz47xx_{nand,bch}.{c,h}. =20 > >>=20 > >> I don't know about that. Adding support for new hardware isn't a=20 > >> good > >> reason to > >> rename the driver, or so I've been told around here, as you then=20 > >> make > >> it harder > >> to review the git history of the driver. =20 > >=20 > > You already move files to a sub-directory so that doesn't make a huge > > difference, history will be hard to follow because of this move=20 > > anyway. =20 >=20 > Yes, but if I merge the *_bch.c files together, and eventually drop > jz4740-nand.c, does it still make sense to move to a sub-directory? >=20 Still prefer to make things explicit over preserving file names to make git log history linear. And anyway, how hard is it to figure out that the last commit in git log drivers/mtd/nand/raw/.c is moving the file (there might even be an option for that)?