Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 3 Feb 2019 18:57:07 -0200
From:   Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To:     Shayenne Moura <shayenneluzmoura@gmail.com>
Cc:     Haneen Mohammed <hamohammed.sa@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/vkms: Bugfix extra vblank frame
Message-ID: <20190203205707.7pqv6s5xuhbxduqv@smtp.gmail.com>
References: <cover.1548856186.git.shayenneluzmoura@gmail.com>
 <171e6e1c239cbca0c3df7183ed8acdfeeace9cf4.1548856186.git.shayenneluzmoura@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kojcgas5cotmjhuj"
Content-Disposition: inline
In-Reply-To: <171e6e1c239cbca0c3df7183ed8acdfeeace9cf4.1548856186.git.shayenneluzmoura@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--kojcgas5cotmjhuj
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 01/30, Shayenne Moura wrote:
> kms_flip tests are breaking on vkms when simulate vblank because vblank
> event sequence count returns one extra frame after arm vblank event to
> make a page flip.
>=20
> When vblank interrupt happens, userspace processes the vblank event and
> issues the next page flip command. Kernel calls queue_work to call
> commit_planes and arm the new page flip. The next vblank picks up the
> newly armed vblank event and vblank interrupt happens again.
>=20
> The arm and vblank event are asynchronous, then, on the next vblank, we
> receive x+2 from `get_vblank_timestamp`, instead x+1, although timestamp
> and vblank seqno matches.
>=20
> Function `get_vblank_timestamp` is reached by 2 ways:
>=20
>   - from `drm_mode_page_flip_ioctl`: driver is doing one atomic operation
>     to synchronize planes in the same output. There is no vblank simulati=
on,
>     the `drm_crtc_arm_vblank_event` function adds 1 on vblank count, and =
the
>     variable in_vblank_irq is false
>   - from `vkms_vblank_simulate`: since the driver is doing a vblank simul=
ation,
>     the variable in_vblank_irq is true.
>=20
> Fix this problem subtracting one vblank period from vblank_time when
> `get_vblank_timestamp` is called from trace `drm_mode_page_flip_ioctl`,
> i.e., is not a real vblank interrupt, and getting the timestamp and vblank
> seqno when it is a real vblank interrupt.
>=20
> The reason for all this is that get_vblank_timestamp always supplies the
> timestamp for the next vblank event. The hrtimer is the vblank simulator,
> and it needs the correct previous value to present the next vblank. Since
> this is how hw timestamp registers work and what the vblank core expects.
>=20
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>=20
> ---
>  drivers/gpu/drm/vkms/vkms_crtc.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms=
_crtc.c
> index d44bfc392491..23146ff2a25b 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -87,6 +87,9 @@ bool vkms_get_vblank_timestamp(struct drm_device *dev, =
unsigned int pipe,
> =20
>  	*vblank_time =3D output->vblank_hrtimer.node.expires;
> =20
> +	if (!in_vblank_irq)
> +		*vblank_time -=3D output->period_ns;
> +
>  	return true;
>  }
> =20
> --=20
> 2.17.1
>=20

Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>

--=20
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of S=E3o Paulo

--kojcgas5cotmjhuj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE4tZ+ii1mjMCMQbfkWJzP/comvP8FAlxXVaIACgkQWJzP/com
vP/Uow//Vu98UqGq6ZmhdIx+tQ7ZtMhKOXDtACHTqLA1+DKR+DIObYmVl41BkwlR
c8IthbpMsG9bwlmhZH5j9tunZwoysT+iRSLQ3GCih3j8esEyXFITD4zgzEIXK4en
mYx2bCjZvmng6zL/4L3TDnNXZYWCoiCeOMmtRR9cuil4Fm6M938w5O2wCbDj0Ut8
Q3pb9qTDk3uROT7EFRZ7BgGfZ5krK4Gr5MzZUi3VgujhKkDr/nIl0Tkc/LUafrbX
9u7PDNPHF+SASTuL4sY+JdPXCFYjdjq8pzxjwfGvfh4sH8wp/YIspXGaZjG2Ni4M
HewmifLCgC3AT7Da7LmySAORm8pvryMfwT8AmXupMlCw3V531U84/jGGmO4Pk2Q1
scbLO0Lx+xVPhOkc6+kPRb33e4582NwaLu8oMOAh8qbX4FYCslDuJz0JUBiQN7+K
zcqC9iU+SY5h0eoHhO14Y7KfJJukdn/Ro4HhWnDmwdgrJJ2ZyDJaMzBrAYDw6+DP
+hhKtdDttQTL1EwVSvj/IAXipB3JzaCLKtQFKTcUm/AI2ueRkhEoTq4qtc5Dy775
xHvMXqizNcvvyC34UioPWelmU0nORYIXkgGt7P1EYmR0DF9F5h+K7SdpX1YESyHX
JVKJOkNAbZ2vwET9F7wdDpFhQlCBKLsuaR4gE1ILXhhrBqCNcjg=
=MjX9
-----END PGP SIGNATURE-----

--kojcgas5cotmjhuj--