Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp3181692ima; Sun, 3 Feb 2019 15:38:58 -0800 (PST) X-Google-Smtp-Source: AHgI3IYuWF6gCHAewAomkx17cfKEik5vTWoc+EzKj6la5fDIvAtYZdoJo+TqOgN4I/IZ4Ts5fm8B X-Received: by 2002:a63:4706:: with SMTP id u6mr10291371pga.95.1549237138381; Sun, 03 Feb 2019 15:38:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549237138; cv=none; d=google.com; s=arc-20160816; b=XgKs4DUOkF3s08TF1IhnpVbxJet3tO7AHzqf6ZsRV+7LrypK9KVE9+EKM/rAoZkeYn VlfJkPjzvJeivhQgXumhZIY14S2dJMsFy209a9MBTP/8Z30OnlHyOZdvgm9yPX6Ovwk3 JVHMlm3/pbL/UJtq79doO1BT2qZGpFdHl1kOGDDBE/YhCg3f+x989QpyCpFjO0KPzwGK mfsME30K9kY7nRQzbV4rc4Q4a7hDJ03YhLZfN3i45sD6zB1nvDqZWaE0UwAXKeS/Ew03 1jrnBMr2Za7FqiYo411QPX4syqKJKsLTL59K6ZFJfSO0jnRdP63JGu3oT2TAlZmJHni7 PznQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=aoP2mmLS0fFDf6FMYYWWgGtGUnpH6xQLxrW4GZ1ymV8=; b=NFZWDf8GXQUwQnQKxrYU2lPNWHhrR4bXf5uom5Vh29jV/fCgGLWOTlxi/QwY4qGPTp TTLxijlf9a3kNAMaLk5XDXl0dOldx86XxU9jxUsKXOZkRwCv9MhyMTNEzFwZ46+jEf/N TXXvbIyuEMLMR+gii6Seg4ys3EWO1PlDY+VDok8vSrflxIvHf5M/4SKuRTUIow8RX5D5 H7Fs1qLnMt+njaNm/stHZvs7Fv0pK9C4Mmh5j6991ZC4ivCCWokZ7XSNiDbksAUv7W9L uR7YF6k7ZzUxHp4G9/PIHcRx1MjYSkr/UPOmwuCaUjLgNh4s+5JZ/XCrQUhSP0svQh8y 1ESw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm2 header.b=tjW1ZUZl; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=TXHjnFR+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bi2si14484352plb.200.2019.02.03.15.38.16; Sun, 03 Feb 2019 15:38:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm2 header.b=tjW1ZUZl; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=TXHjnFR+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727387AbfBCXfF (ORCPT + 99 others); Sun, 3 Feb 2019 18:35:05 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52241 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727237AbfBCXfF (ORCPT ); Sun, 3 Feb 2019 18:35:05 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4B6BD211EC; Sun, 3 Feb 2019 18:35:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 03 Feb 2019 18:35:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobin.cc; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=aoP2mmLS0fFDf6FMYYWWgGtGUnp H6xQLxrW4GZ1ymV8=; b=tjW1ZUZlm8KjR6ekFNqiWeKR5CEbDh5ZFaO6Ax6QEQ3 X2BZQgoXfnnwZM7N5+ksjVJLOu5r+16BjpoJbqJjfxuKVpKK4ipKYkJpbRlyAzS8 IYsn0OwCQdsTjdOosjJ6Q5QF8ITAnXBf1U/b3Qfl2msC46kzkN7DbcjNZeEib4+U lkkbVeUYooz8F+F8BkMc5nUeCdnd3pJ+5k2T5Fnh7XVZTumYv2sKdtFSM0UbIFyo 3fvVNmhPnVJJef5THh7tY2gea2bZJ/46FuKlaipBwHZRSBDxZ4oFj21ceB8jlF1q oMSIT2RuCJiPYo8BnYXbf0Htl1t3hUUHH0M9rCeu6ng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=aoP2mm LS0fFDf6FMYYWWgGtGUnpH6xQLxrW4GZ1ymV8=; b=TXHjnFR+BCdxaGS6LY3rUl iRVQXI4U+mcXoME0gcYdJa8zMwyHU+sDywLpQkftICc/ZBOxducYWTVOsQEx7LZ8 JpqTjcs3sLsp2rqOmjImYIRLeZ9TshhBt/ef9WsicMdji72mRDsCFAAYx8sfvy1p SJxABSf4UxNE62v/8NEHi/AhMMYTzdm+hYyPOdexxAyvoogCOPRFA5WwJTO9kzBS vBa01nWpSV0M+lCWKlEGbg+E2lwMzSlnikdS8fDUJWTcJvhVBewb8C03ozOIhP++ vVEoVqb69hfT+x6ajBULuhJa0L3Ka+BKlTicVbSoMVG8w55/iOmuJ4mHecsWigkw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrkeefgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmd enucfjughrpeffhffvuffkfhggtggujgfofgesthdtredtofervdenucfhrhhomhepfdfv ohgsihhnucevrdcujfgrrhguihhnghdfuceomhgvsehtohgsihhnrdgttgeqnecukfhppe duvddurdeggedrvddvjedrudehjeenucfrrghrrghmpehmrghilhhfrhhomhepmhgvseht ohgsihhnrdgttgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (ppp121-44-227-157.bras2.syd2.internode.on.net [121.44.227.157]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A94DE44A8; Sun, 3 Feb 2019 18:35:01 -0500 (EST) Date: Mon, 4 Feb 2019 10:34:54 +1100 From: "Tobin C. Harding" To: Joe Perches Cc: "Tobin C. Harding" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slab: Increase width of first /proc/slabinfo column Message-ID: <20190203233454.GB4235@eros.localdomain> References: <20190201004242.7659-1-tobin@kernel.org> <089b1025c5e81410b6b608290becd6f609ca03b4.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <089b1025c5e81410b6b608290becd6f609ca03b4.camel@perches.com> X-Mailer: Mutt 1.11.2 (2019-01-07) User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 01, 2019 at 07:27:24PM -0800, Joe Perches wrote: > On Fri, 2019-02-01 at 11:42 +1100, Tobin C. Harding wrote: > > Increase the width of the first column (cache name) in the output of > > /proc/slabinfo from 17 to 30 characters. > > Do you care if this breaks any parsing of /proc/slabinfo? > > I don't but someone might. Thanks for looking at the patch Joe, Christoph pointed this out also. Solution is going to take a different approach and not touch the column width in /proc/slabinfo for the record, although it does not really matter now, I think that anyone parsing /proc/slabinfo would be using whitespace because the name field is already variable length. Anyways, new patch to come. thanks, Tobin.