Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190203133608.GA26010@jordon-HP-15-Notebook-PC> <22f10cf289b8115fa9e60f89edc24ec2cf0f676d.camel@ndufresne.ca>
In-Reply-To: <22f10cf289b8115fa9e60f89edc24ec2cf0f676d.camel@ndufresne.ca>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Mon, 4 Feb 2019 07:33:37 +0530
Message-ID: <CAFqt6zYZ4y3jPAHaRxdx1pBngo7NoOHnNzZhU_5D5tvKxejUDw@mail.gmail.com>
Subject: Re: [PATCH] media: videobuf2: Return error after allocation failure
To:     Nicolas Dufresne <nicolas@ndufresne.ca>
Cc:     pawel@osciak.com, Marek Szyprowski <m.szyprowski@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>, mchehab@kernel.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
        Brajeswar Ghosh <brajeswar.linux@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 4, 2019 at 3:25 AM Nicolas Dufresne <nicolas@ndufresne.ca> wrot=
e:
>
> Le dimanche 03 f=C3=A9vrier 2019 =C3=A0 19:06 +0530, Souptick Joarder a =
=C3=A9crit :
> > There is no point to continuing assignemnt after memory allocation
>
> assignemnt -> assignment.

Ah, type.
>
> > failed, rather throw error immediately.
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > ---
> >  drivers/media/common/videobuf2/videobuf2-vmalloc.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/media/common/videobuf2/videobuf2-vmalloc.c b/drive=
rs/media/common/videobuf2/videobuf2-vmalloc.c
> > index 6dfbd5b..d3f71e2 100644
> > --- a/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> > +++ b/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> > @@ -46,16 +46,16 @@ static void *vb2_vmalloc_alloc(struct device *dev, =
unsigned long attrs,
> >
> >       buf->size =3D size;
> >       buf->vaddr =3D vmalloc_user(buf->size);
> > -     buf->dma_dir =3D dma_dir;
> > -     buf->handler.refcount =3D &buf->refcount;
> > -     buf->handler.put =3D vb2_vmalloc_put;
> > -     buf->handler.arg =3D buf;
> >
> >       if (!buf->vaddr) {
> >               pr_debug("vmalloc of size %ld failed\n", buf->size);
> >               kfree(buf);
> >               return ERR_PTR(-ENOMEM);
> >       }
> > +     buf->dma_dir =3D dma_dir;
> > +     buf->handler.refcount =3D &buf->refcount;
> > +     buf->handler.put =3D vb2_vmalloc_put;
> > +     buf->handler.arg =3D buf;
> >
> >       refcount_set(&buf->refcount, 1);
> >       return buf;
>