Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp3428077ima; Sun, 3 Feb 2019 22:07:43 -0800 (PST) X-Google-Smtp-Source: AHgI3IaPbewB0kczCf+Oe+k6PIB4GpT5WLjyL4k3+wf34xdLG1KkhJX3glXo2wosg/Ml07bhKOcv X-Received: by 2002:a63:441e:: with SMTP id r30mr11866927pga.128.1549260463117; Sun, 03 Feb 2019 22:07:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549260463; cv=none; d=google.com; s=arc-20160816; b=GVszgPvIOx4n5AyU2KxzcHkhHn8jNTNNEUKcQHRTdBOv1mDNDrB3lxKdeWizL2RFMU ZTfqRgmguyoF4ProWPBpuzqigiT0quq2XABriRi2dkcwIgcJCGLdO7K4Ys3dsC9l3cEn WusFmQ+TuapPzyCpU6fVifNysg2gJvgCf5+N0XcTry0L1VA71qdOMeEWLOhKxzSdAokb ZBQ5slpylQeDjHPqxHCI4bLfPj0vfWxEC+k5HeXeW4C9b15RHbO8p3pHaqqhbmS9GO8T LiYCJGm54V8xROkY0IFY+9BFRqCjtBv7fBKt7Gm5A6BQrmDIV7GJtYpAvJpXgcrR9XiQ IGSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=KG15wM6Jwx9Avl8HGL6Rq2KKwKL64VNzgD6ZPPI8pTY=; b=LO25VDxgMAsulh0Gpd7frKrUZ2bHvPP6UOxwcNxLey9qX1A2Vgh0YL+N7uk7TlwVi7 zhj4GUY3ZZ+n48k9FpKhGtnkUPev8Y5iXiQCl4mYFmH1lkZrZwT5tDYct6Lx69Hn+nm2 QChNp0+DOUTiUgPb0g0QIz/GX5eaAU9OllAiFKdRRtS6o2TJ01fx1sTwg9juV4YsQrsm ZMA9n6c8mQ8lFxdMzm2NOWiOK3o5cyD2mTHJYz2qra//AjJjAmTF5hGa7JGkVf4RMbcF q6meOoLmNihIY4J5Dh5cjw+tEgbflKsQyRQGvcTt6e0lPjWV8mh5cz5y96TpPvAhYrA8 wLGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X2q4F2LN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j17si147329pfd.113.2019.02.03.22.07.25; Sun, 03 Feb 2019 22:07:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=X2q4F2LN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726023AbfBDGHU (ORCPT + 99 others); Mon, 4 Feb 2019 01:07:20 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:46576 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725824AbfBDGHU (ORCPT ); Mon, 4 Feb 2019 01:07:20 -0500 Received: by mail-ua1-f68.google.com with SMTP id v24so4082551uap.13 for ; Sun, 03 Feb 2019 22:07:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KG15wM6Jwx9Avl8HGL6Rq2KKwKL64VNzgD6ZPPI8pTY=; b=X2q4F2LNVwkuzn5p6WpLwB3s2R5YFu7qGAr55eorUXnrm0NoV8nlSzjilmwHg1qcXl DD6qzO39oFADV329MhsvAveYtE/qJWzZIiMgpZ46M+yTGpYmvGL4fp+KV+aoDMRxJP3L ifeZ7aS7tZsRCC4eECwsQwQ31mQRPrsQlY9oI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KG15wM6Jwx9Avl8HGL6Rq2KKwKL64VNzgD6ZPPI8pTY=; b=PxF5a2ctLjhh3p0fAPBuHlL9QVMJWlIDwOtgqg6GeJRgGyczbQe3v85wi5xQiA9fNC dNkL+G0/chvm2VsibcoWtP86zAGAB0/jgDOmcubVG7L3iv0wUprq2ePdpokXaxnUKiFk qaVR5D+6eGdkdQoFRwAJj8TrejvqXzvu8PAWTyIlCIesgVE7O6s4EUwdmbWqpbY7GcNo 2CJqNq3JZK40aXIyI1cu3JiVu2tyqMAIO/jiFj4Pt7/mHM9EBVqa/1lljPI5Tdlu9tam 5b35fl9dsz9NZ5KnzRH33KeAW9L3SiaRD1gYa7zUkHoO2WU4BQrxCR6sxy7+N9e1qgQq /ZAw== X-Gm-Message-State: AJcUukevFBr/gLcy+WlR0Ky79CFoUeU4wOAjQ4JoUd3oDm/JgXaQgUiC GZ+xHdt25T41tybQAv8w0B8xNt6tf6oI1F/WQUwUJQ== X-Received: by 2002:ab0:31d5:: with SMTP id e21mr21397916uan.107.1549260438893; Sun, 03 Feb 2019 22:07:18 -0800 (PST) MIME-Version: 1.0 References: <14a011aa-862f-7132-8741-df5173875f34@hisilicon.com> In-Reply-To: <14a011aa-862f-7132-8741-df5173875f34@hisilicon.com> From: Ulf Hansson Date: Mon, 4 Feb 2019 07:06:41 +0100 Message-ID: Subject: Re: [PATCH v2] arm64: dts: hikey: Give wifi some time after power-on To: Wei Xu Cc: Jan Kiszka , Linux Kernel Mailing List , linux-arm-kernel , Ryan Grachek , John Stultz , linux-wireless@vger.kernel.org, "Reizer, Eyal" , Valentin Schneider , Kalle Valo , Tony Lindgren Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Feb 2019 at 17:34, Wei Xu wrote: > > Hi Jan, > > On 1/24/2019 7:52 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Somewhere along recent changes to power control of the wl1835, power-on > > became very unreliable on the hikey, failing like this: > > > > wl1271_sdio: probe of mmc2:0001:1 failed with error -16 > > wl1271_sdio: probe of mmc2:0001:2 failed with error -16 > > > > After playing with some dt parameters and comparing to other users of > > this chip, it turned out we need some power-on delay to make things > > stable again. In contrast to those other users which define 200 ms, the > > hikey would already be happy with 1 ms. Still, we use the safer 10 ms, > > like on the Ultra96. > > > > Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support") > > Signed-off-by: Jan Kiszka > > Acked-by: Ulf Hansson > > Applied to the hisilicon soc dt tree. Wei, can you please also add a stable tag to it? [...] Thanks and kind regards Uffe