Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp3609438ima; Mon, 4 Feb 2019 02:03:24 -0800 (PST) X-Google-Smtp-Source: ALg8bN6/kZ0ZTIjO+/NgbwEk6FaEw0+ARWrBKGhlKbmGjk/GB/vPUXH1kC4ImFnnEtM8hBs6J+w2 X-Received: by 2002:a17:902:29a7:: with SMTP id h36mr51536867plb.244.1549274604562; Mon, 04 Feb 2019 02:03:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549274604; cv=none; d=google.com; s=arc-20160816; b=PohVhoISTyaDdRTYubbdo6MDQuRpDfwtQh5cJrTcy0aGIkVGkV2zvvc1/ymKytgiah BwZTy1bpJVEFtlKCdV9x9KgCEmxXbe7Xln7FvBNW4jtkNrrGmk7TLGraPPnDljUKElAV Bh76nFGOVLo+eUgRjX+QHNp+Vayp+cLm+HNgFZnbWWOoDs3GyQcOWLCcU2rQ5nvm3/19 Kg3+XFFA9ZEwtPqkSeXkNNWscPEJkwJAAfMcycQMQnbfOxZh2kVLVPKOlNBKNgk6LsKT b01HidDkqxoPJ9Q2u4pa3RLneNkQVVykUriysSDj6UFlPXVXjHBMzCcaXKpY+JSl9pMv dxqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=brRPXCD2jZcrrLhzRAwaT2u92Pni+2Pr+UuI2xoYGXo=; b=IBybOmzrRP/VDTsuOvamhGEf06TWLn0GQgetBq64yqyxFNYF+EzngtDBywDliyPnwr sdgMqI9XA0sCDyKz7fZrLFuv5fM/aA7ughw5K6uat3YLwLcqgUjduG5bdEYOv3lV/rG1 rlKM8JQG6AGGfDsbI3Qwln+6V3zL6xu3EA2Qznb7qOTTlxV1ctgXMz5+mN73vgRRbvNV VY0B8iLUwWP5KNOxZXUqK/P9vwiD0/RhPQUheQJfSGj2llKKs/v7dSMTPIs1PLC1C79h sjthh9bq58xI+omj9s0ykByeuCiTLG9nYgd/oWRxrpTAtsu8Kmlyj7FG4M3o/BPORalW p6bg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r11si14266259pgg.327.2019.02.04.02.03.08; Mon, 04 Feb 2019 02:03:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728390AbfBDJWV (ORCPT + 99 others); Mon, 4 Feb 2019 04:22:21 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:35165 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726928AbfBDJWU (ORCPT ); Mon, 4 Feb 2019 04:22:20 -0500 Received: by mail-lf1-f66.google.com with SMTP id l142so1807732lfe.2; Mon, 04 Feb 2019 01:22:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=brRPXCD2jZcrrLhzRAwaT2u92Pni+2Pr+UuI2xoYGXo=; b=KPrhjc6u2IpI9NzCkmxbP1SmZhnSfYn42E4SpysCs+aEs4CVureY9+94xtgb0WAEVI Dgna7OGSEHo0yfNLFU2eFJH6VPPOgSTTqxHFi/dZuLXOH6vph/SO6ZYPBz1o4XBvhrmh c8GWKG1z+6oDfPGfzOkWr0tCjIb09ZfiFYjrVKl/nK9gioiOYnm3GsTbNGyFA89HPvS0 i0vxn2zLHDH/czivj/xAjcj70f7rsUJ4Setcd6Vz3L6i9u+I+/WgC8VgmAfUboZtg1j4 YUIBeuTfGz2/Tn84nXQQXp0A6+OXHddEFSVj9iA9sRmnP7p+hyHGo8DsksBoddWQRJyb Kk+w== X-Gm-Message-State: AHQUAualVR460Y2SvzCGsY6wefs38khS1ZVZAiq67P79hG7x1xArkWAG n1nyWuz8U7Iv80rl0wNPQYk= X-Received: by 2002:a19:4f0c:: with SMTP id d12mr6253662lfb.121.1549272138787; Mon, 04 Feb 2019 01:22:18 -0800 (PST) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id m63-v6sm2895943lje.81.2019.02.04.01.22.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 01:22:17 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1gqaSG-00054o-8x; Mon, 04 Feb 2019 10:22:16 +0100 Date: Mon, 4 Feb 2019 10:22:16 +0100 From: Johan Hovold To: Myungho Jung Cc: Johan Hovold , Marcel Holtmann , Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Bluetooth: Add NULL check for tiocmget() and tiocmset() Message-ID: <20190204092216.GC4686@localhost> References: <20190130053925.GA26699@myunghoj-Precision-5530> <20190131154000.GU3691@localhost> <20190203063823.GA8228@myunghoj-Precision-5530> <20190203105323.GA4686@localhost> <20190204072859.nrglf7pfj42itzh5@myunghoj-Precision-5530> <20190204090436.GA3711@myunghoj-Precision-5530> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204090436.GA3711@myunghoj-Precision-5530> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 04, 2019 at 01:04:37AM -0800, Myungho Jung wrote: > On Sun, Feb 03, 2019 at 11:29:00PM -0800, Myungho Jung wrote: > > On Sun, Feb 03, 2019 at 11:53:23AM +0100, Johan Hovold wrote: > > > You should add a Fixes tag identifying the commit which introduced each > > > bug and a stable-cc tag. If you want you can indicate the version after > > > a # sign, but that can also be inferred from the fixes tag. > > > > > > For the hci_ldisc fix I think the tags would be: > > > > > > Fixes: 2a973dfada2b ("Bluetooth: hci_uart: Add new line discipline enhancements") > > > Cc: stable # 4.2 > > > > > > You can use git blame to track down the offending commits. > > > > > > This should all be explained here: > > > > > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > I have one more question. The title of new patches should be version 3 like > this? > [PATCH v3] Bluetooth: hci_ath: ... > [PATCH v3] Bluetooth: hci_ldisc: ... > > Or newly start with [PATCH]? You should keep and increment the revision number even if you split a patch (so use v3 for the resend). I suggest you send both patches in a series (as they are related); take a look at git-send-email for a convenient way to do that. And always include a brief changelog (below the cut-off line, "---") when revising patches. Johan