Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp3645050ima; Mon, 4 Feb 2019 02:43:27 -0800 (PST) X-Google-Smtp-Source: ALg8bN4UOd9hWRexKgQFFYizTgNt5Fh/xZEhd16jeRJMna4+2bjoB2wtMWQ1DKf8SwioIJygDHAW X-Received: by 2002:a62:db41:: with SMTP id f62mr51473258pfg.123.1549277007707; Mon, 04 Feb 2019 02:43:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549277007; cv=none; d=google.com; s=arc-20160816; b=Im6T5gvERhOYREkp3gopwX/joAC8xsdxguR0A++bNOTFcRX91ClPR73P+fDpqPBxMb Gzuz8MIELclOkj5OxImnfzlP+9XTSNHzm1EQIpHnH1BnKRkz7ZR9NfCQIibclw6zycPb 0Sc3eBof3qMTWC7AxQCW4JT9+MLv2NH1qNyEF7RbU6iXfY59GePwRZ5cesWGcqp3QJWs 3Ldb4Gu8EmJqab1qm1ijgoYB0ESNHFM4Slo7t13PTQgEOOPaiJ5TdZwawTuC0d9dNlLB plFjh037R8ZhlSD71awVq2deUoSfH5L6Uc2G3rc+6+aZl/TzRd0imRcDnkixhDVI61nE VESw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=AW5qZGx2q6yAfmpqVPdri3UotXMvI15u8PvE8Og2YM8=; b=YpGvDT/aTSreutlxAOtKhPLVNX6DbByDaeR0OajfyfOBTleRQ+BvvRj8vh5WBnZ1vT BREZmMHqrHokytAmWzCaW8YfZN44HWe+g3X4K8ox8YfosHh8Zd4MGOtOjXvqtyvsggiV mEA3UouP8i2mNpcQu3CUsWowcY6LLC00m4MU1R9bpYwPdyUoL+acxoq50cGor0ib08Pf UxPafFVpNz0haZVjvjm4D0n77SvrRDrUFUTP+a9MHYdky8UNwtDLxN1KEY5pOU8N8mo1 ncTFcBSuR5AaKgmNznm5K015AliF7ugqqSm3jFjqfOWeEIrMQG2A9QNLwjkqDt/rl+W3 hfgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=v1j+xm0r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e67si8111340pfa.15.2019.02.04.02.43.12; Mon, 04 Feb 2019 02:43:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=v1j+xm0r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729448AbfBDKlO (ORCPT + 99 others); Mon, 4 Feb 2019 05:41:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:39174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730226AbfBDKlM (ORCPT ); Mon, 4 Feb 2019 05:41:12 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70D6A2070C; Mon, 4 Feb 2019 10:41:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549276871; bh=MHwDGGG1dqi50sT67KrlRXyht4GU1zTgEdTnizjLKDA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v1j+xm0rrH9pHJhyvPoaqdMRVfxkKNbT3sqL+luQkgu1li3N1rVnig2fjZDCMG9il VmnfiFWqNFGs9Bu8W/BzEzpekxjGmMgaozPwT49UFiw549F2Pn7BzYs5wivtLE7Bv1 gseaGjb4I8tAj6obAaf31atcyo7uoA5Eo7wHmsMI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Martin Vuille , Adrian Hunter , David Ahern , Jiri Olsa , Namhyung Kim , Wang Nan , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 4.4 24/65] perf unwind: Unwind with libdw doesnt take symfs into account Date: Mon, 4 Feb 2019 11:36:17 +0100 Message-Id: <20190204103614.762496520@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204103610.583715954@linuxfoundation.org> References: <20190204103610.583715954@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 3d20c6246690219881786de10d2dda93f616d0ac ] Path passed to libdw for unwinding doesn't include symfs path if specified, so unwinding fails because ELF file is not found. Similar to unwinding with libunwind, pass symsrc_filename instead of long_name. If there is no symsrc_filename, fallback to long_name. Signed-off-by: Martin Vuille Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: http://lkml.kernel.org/r/20180211212420.18388-1-jpmv27@aim.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/unwind-libdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c index 60edec383281..880e8db32484 100644 --- a/tools/perf/util/unwind-libdw.c +++ b/tools/perf/util/unwind-libdw.c @@ -47,7 +47,7 @@ static int __report_module(struct addr_location *al, u64 ip, if (!mod) mod = dwfl_report_elf(ui->dwfl, dso->short_name, - dso->long_name, -1, al->map->start, + (dso->symsrc_filename ? dso->symsrc_filename : dso->long_name), -1, al->map->start, false); return mod && dwfl_addrmodule(ui->dwfl, ip) == mod ? 0 : -1; -- 2.19.1