Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp3646182ima; Mon, 4 Feb 2019 02:44:48 -0800 (PST) X-Google-Smtp-Source: AHgI3IZzCySdWU9QX8ZisssSpIz4fFbTzcf6Ir7w5X3+n2C8FpJSmqqbVafsYU/tuyhAsOzhtcln X-Received: by 2002:a63:e516:: with SMTP id r22mr12625236pgh.256.1549277088584; Mon, 04 Feb 2019 02:44:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549277088; cv=none; d=google.com; s=arc-20160816; b=f09k+/YuxvbqrzVV1ftxOw6vUdp6TRDbddChXcO5F3g6xtQYrvmC9KMKQzxFJYm8Jb mFzZXVS8ObpLIAX1z+DBihs9KVEsfj2sa4faEQJPQQd7NPEzVavnL3OeuE19sVuC05Sq hxnlR/unXunEVWHGqBBFDZDcqJv2TNPf9PQz8lRdm62sciEXPaPpOPTE0Qi06qkP1zHe 7sT0qcwREl7GTBXb/j/Mcw/JUWvRJgY5dGRCIk68g0pDk3eH3Au08z4MOlyfptllDcZa ydToxWfwAjqlvjYWZV6dGrpsKCPQ9erCSx4Z01EKWDgh6HY09/ZVcwS/TDetmBiIyiVZ aD4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=yCR1bHRoYBqQpsmT/+IhQAfTCoAmJZ9bn04vRUZiDTg=; b=mWG2KA5mS1sJFQzXx7EpptAocDqn8mp1Y2+IsQFjgfFFlq0y2RMDkzhBV2baALneoN WUkLpSvUcUoSfnOJZfWcbfexITLI1AzoNp/gPE6rlMpbEh71NwaMfpIYVAtIN0FDsDie IjuO9X9AqKCEzgGT1tEe22t3qqvR+oxwli2rW/RD1EFmicJfvqvzA7luskk8A0HEn04O RLDhnk+0gg8/omtPIxXEaBX3KgNkXPYhRTrGq58WUJZf/CblVPa7Qb8Fg5P1edYfPGZ9 8xMFcjXlW3XPiKpfFeh8o9x5qYqT0gqEB6n8lzcOc831YF9vJ6NzMCpNPQof6SqhRCOX Sr/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Rz+IrIor; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e35si3044623pgb.548.2019.02.04.02.44.32; Mon, 04 Feb 2019 02:44:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Rz+IrIor; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729346AbfBDKm0 (ORCPT + 99 others); Mon, 4 Feb 2019 05:42:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:40346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728663AbfBDKmY (ORCPT ); Mon, 4 Feb 2019 05:42:24 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFBB62087C; Mon, 4 Feb 2019 10:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549276944; bh=TlC+UZrcSeqdjaYin2xrLxjp5QqFhbzBtGkaXsFs53o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rz+IrIori0EwfrY32hVlOdQ0vkHm58soXjW9rdGeWAQkPj9pMv/9xz//LSgmGf/aA XfQ071n+t+29sxprN2kpFlbLMcQF8IezLWB31ZwOkSA0CAi2v66TKilFubBVDhmlz+ dZtfOGflxISguhbnOkvNiT9epGIOQbIJ7lLnACkI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Wahren , Adrian Hunter , Ulf Hansson Subject: [PATCH 4.4 49/65] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe Date: Mon, 4 Feb 2019 11:36:42 +0100 Message-Id: <20190204103618.762801605@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204103610.583715954@linuxfoundation.org> References: <20190204103610.583715954@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Wahren commit 2bd44dadd5bfb4135162322fd0b45a174d4ad5bf upstream. We need to handle mmc_of_parse() errors during probe. This finally fixes the wifi regression on Raspberry Pi 3 series. In error case the wifi chip was permanently in reset because of the power sequence depending on the deferred probe of the GPIO expander. Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver") Cc: stable@vger.kernel.org Signed-off-by: Stefan Wahren Acked-by: Adrian Hunter Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/sdhci-iproc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/mmc/host/sdhci-iproc.c +++ b/drivers/mmc/host/sdhci-iproc.c @@ -217,7 +217,10 @@ static int sdhci_iproc_probe(struct plat iproc_host->data = iproc_data; - mmc_of_parse(host->mmc); + ret = mmc_of_parse(host->mmc); + if (ret) + goto err; + sdhci_get_of_property(pdev); /* Enable EMMC 1/8V DDR capable */