Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp3648632ima; Mon, 4 Feb 2019 02:47:37 -0800 (PST) X-Google-Smtp-Source: ALg8bN59O6kkzBAGv/7Ytce4w36cAeqRskKgbXffTZPRvIfGcojn6p2j5Ffp8KRwdEQkRBSTp7q4 X-Received: by 2002:a62:9913:: with SMTP id d19mr50625033pfe.107.1549277257204; Mon, 04 Feb 2019 02:47:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549277257; cv=none; d=google.com; s=arc-20160816; b=Rom4eOO1D9ZNmEH47nbXigNaDoNQ5tX4UxQgjnSsgdkMqUJoAyzBazNey8jhTcCjKB 1ODbJyQdmZoWZ+Szissy09rZYHIwEWg8+IpCHZPWi5GcEBDvdaBJJH3gypCpZsUNd5Dh kQ7+5RZdeohvNqGZ3ADicPcolSSeydVVO2+HK0VAOwYJXL98UT3Ul/aQ4V2ITMBeeXXW CBr20XDOZDDFbqFhFwl+3vhkcysWQxEd3svXIbwv4DnV+Del+UV6LnVGp/BjgORlyG0U ACqs8fwlIplGGcK1H64A3Nj+oLk5naYfPL4F9zT3o7HPdCDKcntrNaO6q3kbpNuaWZUD Lwjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CqfPxKL1p6j1G6vPV16UlkkzSGezrKROgReRQhqbB/0=; b=db41fir7QTeCTOwzT1UId2NmI+YHwzrEnojlaSJcf+RWpKH0wcjsgtTgnYif1hXo86 3j9iTJI5g1snGdFfX554XiMTVn5/8r6yGxv6LETlk5FHc1SXDApA9bEebwlrbf016Krk YL7slIoYHkUV+LGIGYWj7q+Ucyk8bMJv0pYy/slufUAxqUKtx0pUQ6goovM2XgfBz98W D19WlJxQgnSgkL+Vtvni7/BDH+yKY4I9TYyRFbuvg/BAl31gDt8+iNxzTurelMfUAfr1 fDfVSGQ8OecsTrK2Qjz4Zf8T1mo0G67ifi9ds9RyD6VAEYaGPBGEIlrmKfok/+k1miKy 3TXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="slLsB9E/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h20si14727080pgm.366.2019.02.04.02.47.21; Mon, 04 Feb 2019 02:47:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="slLsB9E/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731167AbfBDKpS (ORCPT + 99 others); Mon, 4 Feb 2019 05:45:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:43326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731161AbfBDKpP (ORCPT ); Mon, 4 Feb 2019 05:45:15 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 68F432087C; Mon, 4 Feb 2019 10:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549277114; bh=vO6T1eySXX7YwwhaH09UxqrNDGdmzkhi3vZHuvBfZV4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=slLsB9E/sa0rhogEy/MN3HAfeBrbQmDs7kFUljjrCFQhl76ppoW/Rz7uWFLny4skQ ILMNO++vPHzHvbVSG3EDtirRcRE8+5xRxUSPbaRThcPbdM+jXwIf8ZMurGA+8qwK9v EaAehD8PqsKvl8wBPPIRfu/+tPMqZryF+uqzGVxY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mathias Thore , "David S. Miller" , David Gounaris Subject: [PATCH 4.14 09/46] ucc_geth: Reset BQL queue when stopping device Date: Mon, 4 Feb 2019 11:36:40 +0100 Message-Id: <20190204103610.302047513@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204103608.651205056@linuxfoundation.org> References: <20190204103608.651205056@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mathias Thore [ Upstream commit e15aa3b2b1388c399c1a2ce08550d2cc4f7e3e14 ] After a timeout event caused by for example a broadcast storm, when the MAC and PHY are reset, the BQL TX queue needs to be reset as well. Otherwise, the device will exhibit severe performance issues even after the storm has ended. Co-authored-by: David Gounaris Signed-off-by: Mathias Thore Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/ucc_geth.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/ethernet/freescale/ucc_geth.c +++ b/drivers/net/ethernet/freescale/ucc_geth.c @@ -1888,6 +1888,8 @@ static void ucc_geth_free_tx(struct ucc_ u16 i, j; u8 __iomem *bd; + netdev_reset_queue(ugeth->ndev); + ug_info = ugeth->ug_info; uf_info = &ug_info->uf_info;