Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp3649073ima; Mon, 4 Feb 2019 02:48:07 -0800 (PST) X-Google-Smtp-Source: ALg8bN5IiAR2z57YykMBrZuedRzQQcFSW0CQWfi11MJDxI7R19ExUdZIqgWC4Afwng6ZlM2aQtO2 X-Received: by 2002:a63:4926:: with SMTP id w38mr43926850pga.353.1549277287561; Mon, 04 Feb 2019 02:48:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549277287; cv=none; d=google.com; s=arc-20160816; b=SJTD9f+xMjuwzT58YeuUtAMVJXYKZ45nQPeyM62B5XQPERrxJSrCr3JY5Zp9vGz8L6 f4xxUwPBCWYI25ilRo2z28mxJg4tRHzJIZizYFMyk22yjUGfyZmWyYyf5dMMKVG8gDuL fbyerVwgXJuxbM6oNx+hf0qInsVxCdkzQI3tCCUXenpLWVhfN+Wn0JZROvR+8/jflK9e cNnBZZRotAF5wWJTNqEVgSchslLd1tYovyJvow4DLj16VdwPGH4QpCa3Ds79deaGEEF3 NoRm3v5ZUfjQPp/Q6fgE90oN+1WUUCeRVGkfBW0FCP/snb/Ez7gIub8qKJiIvgmuxg5g 9egA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SS1hBPhC/NcjIwCJQJxW5tgpXTuDeLydOVdQM47YCy4=; b=dtog6Zau9NyZP55n46a8VspROcAT+hDBrvAPZCf9j79IDNDW5ySq7PLjPXR3eeei7I 2yRYPC5TkzYDuwxnIU4SmUGhoWx1gYVcnM3VOTkTRZcqBKAiZL/8aVhV8Xkm9M86cF06 21IB+2pf/MSXYArXH6nT0/9qRzJCe3SQMI6LLeoqb1u202aKtkAGGijwanBVa3miBM4X IH0TQzZTE9giGYHU8qw4iV458HO2cDMaY6ThXj30mw5/I+1OBpPQgOIRBZ1TIy1Arj9o 0v6iaGMSvyaKIA93mQ2YLG3FPfbABkkc0PCSIgCrBERgBEQrdnf0DNwQFICKNDW6JAHC BYHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WdNh8Apl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bj4si6372469plb.119.2019.02.04.02.47.51; Mon, 04 Feb 2019 02:48:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WdNh8Apl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731275AbfBDKpu (ORCPT + 99 others); Mon, 4 Feb 2019 05:45:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:43866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731249AbfBDKpq (ORCPT ); Mon, 4 Feb 2019 05:45:46 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D39E62087C; Mon, 4 Feb 2019 10:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549277145; bh=HAXVgpAyj1CbrHbYlOWYJQ0gmFcWEPTxf44fP8PwUXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WdNh8AplsMZED7j/uHnVq9lPcFlU70KKd22b5OdLjf3ID8J++4801mdsEYafABWAD 9m9h0nZQvKq7WN/itbl/PTwUIK+mXSfxJsHB7i5NbHRiSa9Nhpsjfr8gHH5rR0EJ2K RbdrR6KqbXXjcg7JBe0pX7d9EHQlmrrF78TsT48g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Wahren , Adrian Hunter , Ulf Hansson Subject: [PATCH 4.14 37/46] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe Date: Mon, 4 Feb 2019 11:37:08 +0100 Message-Id: <20190204103615.160418755@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204103608.651205056@linuxfoundation.org> References: <20190204103608.651205056@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Wahren commit 2bd44dadd5bfb4135162322fd0b45a174d4ad5bf upstream. We need to handle mmc_of_parse() errors during probe. This finally fixes the wifi regression on Raspberry Pi 3 series. In error case the wifi chip was permanently in reset because of the power sequence depending on the deferred probe of the GPIO expander. Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver") Cc: stable@vger.kernel.org Signed-off-by: Stefan Wahren Acked-by: Adrian Hunter Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/sdhci-iproc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/mmc/host/sdhci-iproc.c +++ b/drivers/mmc/host/sdhci-iproc.c @@ -278,7 +278,10 @@ static int sdhci_iproc_probe(struct plat iproc_host->data = iproc_data; - mmc_of_parse(host->mmc); + ret = mmc_of_parse(host->mmc); + if (ret) + goto err; + sdhci_get_of_property(pdev); host->mmc->caps |= iproc_host->data->mmc_caps;