Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp3667645ima; Mon, 4 Feb 2019 03:07:41 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib/bZrlu4Yop+OG9wIDGGmsubBzllUWlDMSWTw2dy1wAjC3YruuFbqVtkTHbWtQgwiHsRgD X-Received: by 2002:a17:902:1:: with SMTP id 1mr4999871pla.276.1549278461696; Mon, 04 Feb 2019 03:07:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549278461; cv=none; d=google.com; s=arc-20160816; b=aFc8WYlAVfOwi1OpQUGvb1+Gj9fD+xQypscvdEf2nKuTltZXoW8m/bqMA52eGAdd/2 63IsU9oy7Z7oR5wlYf3Pppc7s2eUeuayDFHPMPPSxfyUjihuUNlEwt95fp91P1g0waQ0 FwO2IvNg1E830BIubhhQ4HgVHd7YzzdzWrFjxunx44PC2vreJ2oU1Co87g6hED0b8+WN HSnDQg2qLNcbE9Pt6WKpSOEXKvw/Ik3zF7lvJi7K8fWB4xZojhgroHfHcUU8uamascGB 1ON3lzg+jZfcw9yYiS2XsBOlNF65cSFQLM+Z1icFTNJ74085AMxonyRxQQz7NYTJLttE tJYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LZDhx6E9r6fSE2pET6iSNJsy+XoXdtOLCh5XnmNa6B8=; b=Fri9cBFSBadipcEqtaFts+L/Yjot0CepujbiFrH29cFW5W/F0ZiKxPR5inchPbhMvj 7H+nlYwiUAld9yTpJCIYTyNxLejR5wk336BW6O1QNo+A5nBLov5nI5zJ+cIK7gajM0oS TW4jLwKO66MrsHjm+YcD0ysfGS7wOh7PTRfDr432sFJ+gv1Gkz9dAOErPMjkbqaIr/uu Sv2zvzt9ASZifQui8WohYU8De5lXZJBnpvmqJQ99InjCKhV/DHneiQTBljYqmIaDEJbh wk85/X81jHNZVDgG1VSOP6b/8KOnaPIJBvVCkcd0Jr1lDJQBg3+8Hsbt4ByzAjqLtSk3 Th4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JBiS+R9a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si4299697plx.383.2019.02.04.03.07.25; Mon, 04 Feb 2019 03:07:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JBiS+R9a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730761AbfBDKne (ORCPT + 99 others); Mon, 4 Feb 2019 05:43:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:41330 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730204AbfBDKna (ORCPT ); Mon, 4 Feb 2019 05:43:30 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A83932070C; Mon, 4 Feb 2019 10:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549277010; bh=jq2RqgrpqFU+pN17kVcFkwrMlv2TG6+B7rNh1P+ye6c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JBiS+R9am3TdBHx8CLCGZ4uY4V5Gt7hns1pxDQomb8RPpBWmZTnbN/z3VbzoVs76K +Q3YcbahKwrd0QiyGAV3cGdvmMyxquw5B99EaO1lm/DxpKSOm0Ky2H69rboQy5s3l4 WEZOGATJ/L+XdiCP9X6UHyc6QwQn8zW1i+a36zOA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Wahren , Adrian Hunter , Ulf Hansson Subject: [PATCH 4.9 22/30] mmc: sdhci-iproc: handle mmc_of_parse() errors during probe Date: Mon, 4 Feb 2019 11:37:00 +0100 Message-Id: <20190204103609.389016883@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204103605.271746870@linuxfoundation.org> References: <20190204103605.271746870@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stefan Wahren commit 2bd44dadd5bfb4135162322fd0b45a174d4ad5bf upstream. We need to handle mmc_of_parse() errors during probe. This finally fixes the wifi regression on Raspberry Pi 3 series. In error case the wifi chip was permanently in reset because of the power sequence depending on the deferred probe of the GPIO expander. Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver") Cc: stable@vger.kernel.org Signed-off-by: Stefan Wahren Acked-by: Adrian Hunter Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/sdhci-iproc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/mmc/host/sdhci-iproc.c +++ b/drivers/mmc/host/sdhci-iproc.c @@ -242,7 +242,10 @@ static int sdhci_iproc_probe(struct plat iproc_host->data = iproc_data; - mmc_of_parse(host->mmc); + ret = mmc_of_parse(host->mmc); + if (ret) + goto err; + sdhci_get_of_property(pdev); host->mmc->caps |= iproc_host->data->mmc_caps;