Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp3674982ima; Mon, 4 Feb 2019 03:14:30 -0800 (PST) X-Google-Smtp-Source: ALg8bN4MKKd2CgqNnLRJ0k4a8pOdLv/v/vHwnTPYo6kmhNl+R6sCLXfuqQjAKLlUQ2sJulAUF/40 X-Received: by 2002:a17:902:930b:: with SMTP id bc11mr52264594plb.17.1549278870722; Mon, 04 Feb 2019 03:14:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549278870; cv=none; d=google.com; s=arc-20160816; b=xCzkGfDrDLKTMWfel6toaLTG8bGldbU8VxQj/bg3TbqjU/4q5rnsaAd4KnZ50bJB7O kNUDYRjvo6i0zquGFfq+I6cIqh5NQ0czKTS8/rTGdADYeM7SdlFM+DB922jGXqxD6YXW TEOqnMFhE7rbLnE2fgxGjAC3q9jy4Ddg0x0i51w3m59qWlZeDn/SJ/v7ug2fi7lBRRUk YR+9aly/dkSANE0v9l4Ijft1gwlHI95t8/30SNEiD36pKt0XAsudHhhpKz9u+xa8U5JI WCO/15secYPSsvHNkDw5E2H1va7hRcpGW3jbRT5NRr10kV/hDJe/BAIApGsr3ZvG0nj2 15tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=tgxXy0W6T+zn9nuvttXh1OLjiMShBqyS7bTOO9sRyQo=; b=QICjiHV5wpd8fnNVHrQZrhCQqga7we2bpzuCYYTyLpPFimW1MCi2mqIaIIxhs5xyEp uRfI4xKuxwQkh8LlQFH6jLU19z8S+TW9b+fRubtDlGdnvlu86/cGRSvDgQkQ6UOFD84M sT5xEEnZIBLFvk6AQ8js3pq+aEcg7xV03BS7R6BXVsTOeA94r/fb/HGvRYAQ/Dq2PHJZ tYMxu5P9nh1k3eZnZFT4ipANzTJt0u/B7I5k4joY+s73CCtaD8MHanQ3dwBC7zCq0cC8 +HtoqJxPQo0J6xD9aNUbT97be+lTQGf21EGWLdW0bkDsmVeSI5p3K5enKyto6+Ef0gqF vsEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d7si15571577pfo.108.2019.02.04.03.14.15; Mon, 04 Feb 2019 03:14:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729857AbfBDLOL (ORCPT + 99 others); Mon, 4 Feb 2019 06:14:11 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:32862 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728605AbfBDLOH (ORCPT ); Mon, 4 Feb 2019 06:14:07 -0500 Received: from LHREML712-CAH.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 16F9EB29205BDD3E156C; Mon, 4 Feb 2019 11:14:06 +0000 (GMT) Received: from [127.0.0.1] (10.202.226.46) by LHREML712-CAH.china.huawei.com (10.201.108.35) with Microsoft SMTP Server id 14.3.408.0; Mon, 4 Feb 2019 11:14:04 +0000 Subject: Re: [PATCH v2] arm64: dts: hikey: Give wifi some time after power-on To: Ulf Hansson CC: Jan Kiszka , Linux Kernel Mailing List , linux-arm-kernel , Ryan Grachek , "John Stultz" , , "Reizer, Eyal" , Valentin Schneider , "Kalle Valo" , Tony Lindgren , "stable #4 . 17+" References: <14a011aa-862f-7132-8741-df5173875f34@hisilicon.com> From: Wei Xu Message-ID: <6f4f342e-0b14-9344-c11b-e81f643cc45b@hisilicon.com> Date: Mon, 4 Feb 2019 11:13:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.46] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ulf, On 2/4/2019 6:06 AM, Ulf Hansson wrote: > On Fri, 1 Feb 2019 at 17:34, Wei Xu wrote: >> >> Hi Jan, >> >> On 1/24/2019 7:52 AM, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Somewhere along recent changes to power control of the wl1835, power-on >>> became very unreliable on the hikey, failing like this: >>> >>> wl1271_sdio: probe of mmc2:0001:1 failed with error -16 >>> wl1271_sdio: probe of mmc2:0001:2 failed with error -16 >>> >>> After playing with some dt parameters and comparing to other users of >>> this chip, it turned out we need some power-on delay to make things >>> stable again. In contrast to those other users which define 200 ms, the >>> hikey would already be happy with 1 ms. Still, we use the safer 10 ms, >>> like on the Ultra96. >>> >>> Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support") >>> Signed-off-by: Jan Kiszka >>> Acked-by: Ulf Hansson >> >> Applied to the hisilicon soc dt tree. > > Wei, can you please also add a stable tag to it? Yes, added below tag into this patch. Cc: #4.12+ Thanks for your kindly reminder :) Best Regards, Wei > > [...] > > Thanks and kind regards > Uffe > > . >