Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp4041704ima; Mon, 4 Feb 2019 09:14:42 -0800 (PST) X-Google-Smtp-Source: AHgI3IbalcWWFEc+RHu8jo8H9eHl46zNlPGR2OeH8NhOG86dfIXwNIR4pbnTb++9ApTmgOTJgV5X X-Received: by 2002:a17:902:ab92:: with SMTP id f18mr379306plr.221.1549300482099; Mon, 04 Feb 2019 09:14:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549300482; cv=none; d=google.com; s=arc-20160816; b=EJEWsNUiLqxGqhwuCrfmbjL2H7L9kzJFwg0pTK0IhVQ0a/hGBMf5AlVoEjIibtOHQg M4OLcjvx+uBJO5Mcm1PfbDRZnbCfdOQGxuqg1a7DFj77XZI0hC4IulxwvskXzmik3flV dZgL3ggEBFHb6whDmMdZZFJX3G5mDakLkualQDftOJkntUPQupZjP8wbWFq8MaPBDCIH oYtAavMI0VWIOAH4gmYxSB1NS5u66zzpX8I4Sm70iD9Xt2FGlLAIfLGNgtUQ7Dfi1vyA ZuniDxL9uBciX9Zj9U5qP/ylUKToJxDiP4h22OshBjIv4aUCG59EwxeC0g+QCV5QTKTi 33Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=F7abaIrci08wJmo9rjYyXR+EBtRm5WS9entGdiIF0RA=; b=NNl2snSip7HWWxMBaJAWIGfAbUQII/GZePJQfakZQ2QSdyfZzietlSbLUbIa+FKQsU A0VYNcUklgFACgJdmsUgSt9Gan5o72tJpeKvmjEospDyylLiMf135LuxNmQC5KD02sV+ 4jyFarWOj5SE6T+IEuTQZjcIp3seVJ855QPspczdXeXldn26xhusfnJccdSTkY/YP6Bs LHuHajooW/82oHWNJpbHSXga/H6IIl8rQ3oUHsj4OpYjhQOW0OGEXV2/zoAJkPctnt2l y8tewd7kPDNSJAE7VLSU7f0p9gbTY0S3IrTrHYrb4xwqYwNe0LEkXraI6ZoenBb2Vf9+ V3PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h75si502959pfj.257.2019.02.04.09.14.25; Mon, 04 Feb 2019 09:14:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729239AbfBDPwo (ORCPT + 99 others); Mon, 4 Feb 2019 10:52:44 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:57406 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728379AbfBDPwo (ORCPT ); Mon, 4 Feb 2019 10:52:44 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B737880D; Mon, 4 Feb 2019 07:52:43 -0800 (PST) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 19B6F3F71E; Mon, 4 Feb 2019 07:52:41 -0800 (PST) Date: Mon, 4 Feb 2019 15:52:39 +0000 From: Sudeep Holla To: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jisheng Zhang , Steve Longerbeam , Eugeniu Rosca , Sudeep Holla , Joshua Frkuska Subject: Re: [RFC PATCH] drivers core: cpu: add hotplug callback to update cpu_dev state to resumed Message-ID: <20190204155239.GB24131@e107155-lin> References: <20190125130701.GA855@vmlxhi-102.adit-jv.com> <20190125150906.27614-1-sudeep.holla@arm.com> <2397404.eE4apdlqQK@aspire.rjw.lan> <20190131160559.GA32759@e107155-lin> <20190204153720.GA24131@e107155-lin> <20190204154421.GA14330@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204154421.GA14330@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 04, 2019 at 04:44:21PM +0100, Greg Kroah-Hartman wrote: > On Mon, Feb 04, 2019 at 03:37:20PM +0000, Sudeep Holla wrote: > > On Thu, Jan 31, 2019 at 04:05:59PM +0000, Sudeep Holla wrote: > > > On Thu, Jan 31, 2019 at 12:48:49AM +0100, Rafael J. Wysocki wrote: > > > > On Friday, January 25, 2019 4:09:06 PM CET Sudeep Holla wrote: > > > > > The sysfs for the cpu caches are managed by adding devices with cpu > > > > > as the parent in cpu_device_create() when secondary cpu is brought > > > > > onlin. Generally when the secondary CPUs are hotplugged back is as part > > > > > of resume from suspend-to-ram, we call cpu_device_create() from the cpu > > > > > hotplug state machine while the cpu device associated with that CPU is > > > > > not yet ready to be resumed as the device_resume() call happens bit later. > > > > > It's not really needed to set the flag is_prepared for cpu devices are > > > > > they are mostly pseudo device and hotplug framework deals with state > > > > > machine and not managed through the cpu device. > > > > > > > > > > This often results in annoying warning when resuming: > > > > > Enabling non-boot CPUs ... > > > > > CPU1: Booted secondary processor > > > > > cache: parent cpu1 should not be sleeping > > > > > CPU1 is up > > > > > CPU2: Booted secondary processor > > > > > cache: parent cpu2 should not be sleeping > > > > > CPU2 is up > > > > > .... and so on. > > > > > > > > > > Just fix the warning by updating the device state quite early. > > > > > > > > > > Cc: "Rafael J. Wysocki" > > > > > Reported-by: Jisheng Zhang > > > > > Reported-by: Steve Longerbeam > > > > > Reported-by: Eugeniu Rosca > > > > > Signed-off-by: Sudeep Holla > > > > > --- > > > > > drivers/base/cpu.c | 20 +++++++++++++++++++- > > > > > include/linux/cpuhotplug.h | 1 + > > > > > 2 files changed, 20 insertions(+), 1 deletion(-) > > > > > > > > > > Hi Rafael, > > > > > > > > > > This is getting reported for quite some time. Let me know if you have > > > > > better solution to fix this harmless yet annoying warnings during system > > > > > resume. > > > > > > > > I'd rather have a flag in struct dev_pm_info that will cause the message to > > > > be suppressed if set. > > > > > > > > It could be used for other purposes too then in princple (like skipping the > > > > creation of empty "power" attr groups in sysfs for devices that don't > > > > need them etc.). > > > > > > > Thanks for the suggestion. I did quick hack and came up with something > > > below. I wanted to run through you once before I materialise it into > > > a formal patch to check if I understood your suggestion correctly. > > > We can move no_pm_required outside dev_pm_info struct and rename with > > > any better names. > > > > > > > Sorry for the nag, since the title has RFC, thought there are chances of > > this getting lost. Let me know if the below idea aligns with your suggestion ? > > Personally, I ignore RFC patches unless I'm accidentally interested in > them, as it shows that the author doesn't feel good enough to propose > them as a real solution :) > I understand. Since Rafael did suggest alternate approach, just thought of pinging him to check if I understood his idea. > But that's just me... > :) Regards, Sudeep