Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp4052199ima; Mon, 4 Feb 2019 09:23:50 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib0MyxNiYTzh9bZssP6MLasqWpyPyLdzkSYwTGl4Z7XvwmAe62LFhgLQC1/+p4m9x+YVUnZ X-Received: by 2002:a17:902:784d:: with SMTP id e13mr495316pln.188.1549301030121; Mon, 04 Feb 2019 09:23:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549301030; cv=none; d=google.com; s=arc-20160816; b=LTB0hDUCUcSR0ZlpLRmTWvwtBB2CvFjXcg4U0omKe+owkBhnLr5k4v131EYrWZ8a4k 4yOuahjdDnTp5ZJU4xUOpe2yT1+Fhy+g8ABUGVFBbg9zL5qL117FzPzQLpFCP4mowTRs Q9iwEY3Otobefl97HfczsY+lFEujFvu2ohwZxYOx9I6UlDJ+6mWyAM/0Gjn/FNWOfHIi IKqZ4yoMW+TMAAJaLSvoGmSBM8czGumdtVqyUTzESz8B7p4wIcxGDxJlY2akF5gcmsc0 nnM9YPfIez2zb3gh80iKaD60eMz9HpE1N9PifkQT4BGnCIKaFC5FtZnIlM2Y5HSBJ78K FgMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=wmadUp5uXQ3//o/wv8oYjb9U7ft+DuzU2023Jj7pW48=; b=E0/+GTgBhI4fGvtGa9Lgi4B1y2JG64zNoq4xA+cTrXNWJDlMfx0wa5tQrXgazM4fhB POGKsErbATtzlhhBchUREtK1vBoQAli8wcMq84Lxxg65HW100SlbEfbiM260SX14iXT9 EslkUMN6Dt9hQlG+HEabDACHsPvdUDgjFpbxqd1A+dkvAPGi1wpQ9dWoU8y13rPZuiYI 7BJX3gX9vjTgMpOa4FXvG6XnqMuV0TAULY6dY1HFAjdF3erM8fna3mjesVLvRNfSX4jY L9BPkmcgtuiUE33Z34SQfCzHQnn7U5seVSHZwRlplvvOOYC8V61FIMp6u8UuSd45UFva 82aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=NXuYOIaB; dkim=pass header.i=@codeaurora.org header.s=default header.b=NxujD+ev; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f20si443805pgv.228.2019.02.04.09.23.33; Mon, 04 Feb 2019 09:23:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=NXuYOIaB; dkim=pass header.i=@codeaurora.org header.s=default header.b=NxujD+ev; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729994AbfBDQmz (ORCPT + 99 others); Mon, 4 Feb 2019 11:42:55 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:54112 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727062AbfBDQmz (ORCPT ); Mon, 4 Feb 2019 11:42:55 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 86E0860734; Mon, 4 Feb 2019 16:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549298574; bh=1GPTfXBbZXobE8F8AvnVuiGEwNBmTM4TvMVOTyfE+P4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=NXuYOIaB6ej8f/Ewm9H2j7F4cQdgrI+9q/30F195Jt4VlRO1ckpNSJy7HNdzPpSry +clYMKQFmnPSNSyWO9NVkO/ikaeI9xWZh95T3AxqoiZ5Sbmqu5uRGGHocGPgfmW9ia aI7RMnw6/uW8xuUsLGctp1H+yexh/EWy9ZxE02y4= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3A83E6043F; Mon, 4 Feb 2019 16:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549298574; bh=1GPTfXBbZXobE8F8AvnVuiGEwNBmTM4TvMVOTyfE+P4=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=NxujD+evLaB+vqqSdTu9zxkQYVfHcn6LaAu6tHt7I1EMBnwzKIk/qJK/rBSe7cwIU b18Dme2oFfokpEn5eN9VyT+CKRS1uV5qfduqI0xzZOPMWsWp19KU1unRX05Lsd0EGY MtCbPym0R0j9IDwBUWf4tl2W4hdY2yQ8wWcZnb2A= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3A83E6043F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377" From: Kalle Valo In-Reply-To: <20181107185643.240346-1-briannorris@chromium.org> References: <20181107185643.240346-1-briannorris@chromium.org> To: Brian Norris Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, , Brian Norris , Yu Wang , Rakesh Pillai , Govind Singh , stable@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190204164254.86E0860734@smtp.codeaurora.org> Date: Mon, 4 Feb 2019 16:42:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brian Norris wrote: > This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3. > > WCN3990 firmware does not yet implement this feature, and so it crashes > like this: > > fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0 > > This feature can be re-implemented with a proper service bitmap or other > feature-discovery mechanism in the future. But it should not break > working boards. > > Fixes: cfb353c0dc05 ("ath10k: add quiet mode support for QCA6174/QCA9377") > Cc: Yu Wang > Cc: Rakesh Pillai > Cc: Govind Singh > Cc: > Signed-off-by: Brian Norris This regression should be fixed by (which is in v4.20): 53884577fbce ath10k: skip sending quiet mode cmd for WCN3990 So this revert should not be needed anymore and I'll drop this. -- https://patchwork.kernel.org/patch/10672903/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches