Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp4054780ima; Mon, 4 Feb 2019 09:26:10 -0800 (PST) X-Google-Smtp-Source: AHgI3Ian1jtRzytbdvJGFqJeTUA8RHU1Y1INS6vUJq9K7e2F3XWfgs9Qm6/PkC7rAq/DwtAeciGD X-Received: by 2002:a62:5444:: with SMTP id i65mr438749pfb.193.1549301170160; Mon, 04 Feb 2019 09:26:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549301170; cv=none; d=google.com; s=arc-20160816; b=XOeIxJIJJBWsqyBrUJuCxRvLrf6czfG4S5JtvBiDGyZsRUGKoz3V5C90g7SUuv6bUH bC+PehAP33iq+msECmOktcXlXsYIHLxy5LRoLLfv6exv7XREDmuf4fGHS0DkowUc+eE+ hPvNaN0lKDiTpq4vmU912gE7h9KtkT/TIaGOLqCBTviazsCaOaM+pVt+jqX06hsB3kXO pP8QVChcBMQ7kOENda64KA16oWvjvw5qKliNkDLPNfpO43YNo0KP3xtsUT+i6tzNNk2k mCxlkCx1AaBXYLZbkCKZZ4bXQUlMGvgDte7YEzV0NCnUalmBuCrhTZrEAQV3uH9vm08A Ucpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=9N8TY0i2V+YP6xT0Vhw/uRnuKOAYll8O9RuzmZTyAs8=; b=ubumH65Ac+V+UInSLT5mvI9QcxbkU0cs62HZqUje5cOmkBc26V9NqEtWWrb5tfpiKP YnwnNxkk0Oc3Zqu7PLpxNPymu9oR+Dzvnt6yBiiPp2tcnkzdhHXTkfVYT38djY1Vy+QT piFFiC9W0lSiSLHsCLZWX0IgthckOMDdmhnj+i6Jho27j7CggOIqTEL4aGJ09uVSwS8H w5UXK5m0mDlEiXPdTFL6vG4VzdmlKic3g5hs5KW3v/zRdNXN97pp1gRf5/kOtFGiSrAA mj9KVPUvK2frFG5/9saoFVHaOYHHL/DibaysWkTUVVZjmQRsWaVDubEABg2uSXxpsElL 3GSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=ralV0nb1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3si498293pgq.139.2019.02.04.09.25.53; Mon, 04 Feb 2019 09:26:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=ralV0nb1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728538AbfBDQ7I (ORCPT + 99 others); Mon, 4 Feb 2019 11:59:08 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:38222 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727057AbfBDQ7I (ORCPT ); Mon, 4 Feb 2019 11:59:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9N8TY0i2V+YP6xT0Vhw/uRnuKOAYll8O9RuzmZTyAs8=; b=ralV0nb1Iu5VbjbaTBc15q0Tyr RRuvhzv6RuVDmU12JCsWURbnSsBHEuhCoiRBwr9jvLEDP1VVdsvsNvbjTePl+avIoB3092bnQnmpi dXhvvnKyJKYcS6A8OIqTkdPqr8iGukfY5YaQYMaVQve8d9OUBZKYCMkbSuHlDpEjtRyM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gqhaI-0007Ma-KS; Mon, 04 Feb 2019 17:59:02 +0100 Date: Mon, 4 Feb 2019 17:59:02 +0100 From: Andrew Lunn To: Thierry Reding Cc: "David S. Miller" , Heiner Kallweit , Realtek linux nic maintainers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing Message-ID: <20190204165902.GB24989@lunn.ch> References: <20190204164213.30727-1-thierry.reding@gmail.com> <20190204164213.30727-2-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204164213.30727-2-thierry.reding@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 04, 2019 at 05:42:13PM +0100, Thierry Reding wrote: > From: Thierry Reding > > Read MAC address 32-bit at a time and manually extract the individual > bytes. This avoids pointer aliasing and gives the compiler a better > chance of optimizing the operation. > > Suggested-by: Andrew Lunn > Signed-off-by: Thierry Reding Reviewed-by: Andrew Lunn Andrew