Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Mani, Rajmohan" <rajmohan.mani@intel.com>
To:     Sakari Ailus <sakari.ailus@linux.intel.com>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Jacopo Mondi <jacopo@jmondi.org>,
        "Qiu, Tian Shu" <tian.shu.qiu@intel.com>,
        "Cao, Bingbu" <bingbu.cao@intel.com>,
        "Zhi@paasikivi.fi.intel.com" <Zhi@paasikivi.fi.intel.com>,
        "Zhi, Yong" <yong.zhi@intel.com>,
        "hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
        "tfiga@chromium.org" <tfiga@chromium.org>
Subject: RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream
 on/off operations
Thread-Topic: [PATCH] media: staging/intel-ipu3: Implement lock for stream
 on/off operations
Thread-Index: AQHUuCOItqk09SukTkm5qxVbw0DkOqXICeuAgAACepCAA6IgAP//oZBwgAShetA=
Date:   Mon, 4 Feb 2019 17:43:30 +0000
Message-ID: <6F87890CF0F5204F892DEA1EF0D77A599B325D85@fmsmsx122.amr.corp.intel.com>
References: <20190129222736.6216-1-rajmohan.mani@intel.com>
 <20190130085901.w2ogdoax7t4yfyj6@paasikivi.fi.intel.com>
 <6F87890CF0F5204F892DEA1EF0D77A599B325222@fmsmsx122.amr.corp.intel.com>
 <20190201163655.ufrazkvsabsp6gmv@paasikivi.fi.intel.com> 
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sakari,

[snip]

> > > > >  fail_stop_pipeline:
> > > > > @@ -543,6 +546,8 @@ static void ipu3_vb2_stop_streaming(struct
> > > > vb2_queue *vq)
> > > > >  		dev_err(&imgu->pci_dev->dev,
> > > > >  			"failed to stop subdev streaming\n");
> > > > >
> > > > > +	mutex_lock(&imgu->streaming_lock);
> > > > > +
> > > > >  	/* Was this the first node with streaming disabled? */
> > > > >  	if (imgu->streaming && ipu3_all_nodes_streaming(imgu, node)) {
> > > > >  		/* Yes, really stop streaming now */ @@ -552,6 +557,7 @@
> > > > static
> > > > > void ipu3_vb2_stop_streaming(struct vb2_queue *vq)
> > > > >  			imgu->streaming = false;
> > > > >  	}
> > > > >
> > > > > +	mutex_unlock(&imgu->streaming_lock);
> > > > >  	ipu3_return_all_buffers(imgu, node, VB2_BUF_STATE_ERROR);
> >
> > I'd also call ipu3_return_all_buffers() before releasing the lock: in
> > principle the user may have queued new buffers on the devices before
> > the driver marks the buffers as faulty.
> >

Ack
(Somehow I missed this comment.)

[snip]