Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp4127554ima; Mon, 4 Feb 2019 10:39:41 -0800 (PST) X-Google-Smtp-Source: AHgI3IZlOXPcf579o4wc0G3ZsRHndcUOxwi2gB/SXbreWX2yyI99cXYlFjVtHjcJVXldEFq/70sL X-Received: by 2002:a62:fc52:: with SMTP id e79mr808732pfh.8.1549305581765; Mon, 04 Feb 2019 10:39:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549305581; cv=none; d=google.com; s=arc-20160816; b=vm9qiX9PwD0109puDgeF079OceQE8rBaW1V6/uynVeoJhMA869BSS/j52odaFDIBtZ C4HK9ybAiuknhvu1D+i5Z7zv9AVhjFOjP98ZAp5hatJRN02Ek0CSQ2JeJp6haTwwqDv1 fCobDmoHptNl1DwDqVPRzeON7XEODRekY/PiBdqTO/snuv3WKpvC29+vIovqlx59dQ3y OlPReqMHIxMTuA2CutBVopNiNeTwumG6oxN6Uya+2aiFLBHXIe2lGOT22lcGGJmYu+2H 171Zi4jWL1H0YrbZJlzhdeI6sH+7HNmm4oVMU/ZZAVpMRR8eqaU/KgkpeOlNYMpYEVUY wrUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=7fDn+FG1w96gHkFCgonXf8BH4M1vLrL9FIzK4dui8Yo=; b=OHIvATSTPzcRG8qnBQ+Fa3LV7k27gxEgglFUyezmzTlpbqt2tTvTsIYsMvyOA6J/52 bV9YbHDHpP5vJDeCJxnAUux9IYLX+yeRJ7LZLtWFidoufjlAWJFadk3K2+bL0TC2uVRW aW+CrnjIBb876wUoaXaD0jm0MVLosaTCqWf5d8fSs8lLQ5YZs8AlbN3VORZENou/jWsn Wy/sxSGhYh6MuDT5uTOUCW2K0selMwGryqM+/fS0o9noYlwtZeZBX+krgqggAkeuQj6W U5bG1ym9iawVv6pNIFGvnWoNfwfSpIgsmnrmCOEWPIbFa5iY66nreRj1ZWs2Y5eaWxJU 97vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 87si699948pfs.7.2019.02.04.10.39.25; Mon, 04 Feb 2019 10:39:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729300AbfBDSjF (ORCPT + 99 others); Mon, 4 Feb 2019 13:39:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33936 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727917AbfBDSjF (ORCPT ); Mon, 4 Feb 2019 13:39:05 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9BEFF58E40; Mon, 4 Feb 2019 18:39:04 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-249.ams2.redhat.com [10.36.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E872100191D; Mon, 4 Feb 2019 18:38:59 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9C061A1E3; Mon, 4 Feb 2019 19:38:58 +0100 (CET) From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: Gerd Hoffmann , David Airlie , Daniel Vetter , virtualization@lists.linux-foundation.org (open list:DRM DRIVER FOR BOCHS VIRTUAL GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/bochs: fix bochs_gem_prime_mmap Date: Mon, 4 Feb 2019 19:38:58 +0100 Message-Id: <20190204183858.8976-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 04 Feb 2019 18:39:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ttm_fbdev_mmap() just doesn't work. It appears to work fine, mmap() returns success, but any attempt to actually access the mapping causes a SIGBUS. We can just use drm_gem_prime_mmap() instead. Almost. We have to copy over the start offset from the ttm_buffer_object vm_node to the drm_gem_object vm_node so the offset math in drm_gem_prime_mmap() works correctly for us even though we use ttm to manage our objects. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_mm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c index 641a33f134..49463348a0 100644 --- a/drivers/gpu/drm/bochs/bochs_mm.c +++ b/drivers/gpu/drm/bochs/bochs_mm.c @@ -442,5 +442,6 @@ int bochs_gem_prime_mmap(struct drm_gem_object *obj, { struct bochs_bo *bo = gem_to_bochs_bo(obj); - return ttm_fbdev_mmap(vma, &bo->bo); + bo->gem.vma_node.vm_node.start = bo->bo.vma_node.vm_node.start; + return drm_gem_prime_mmap(obj, vma); } -- 2.9.3