Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush
 timeout issue
To:     Ray Jui <ray.jui@broadcom.com>,
        Jassi Brar <jassisinghbrar@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
References: <20190204192129.93533-1-ray.jui@broadcom.com>
From:   Scott Branden <scott.branden@broadcom.com>
Message-ID: <dc8e7d9b-51fb-d216-d85c-915dda7d18ae@broadcom.com>
Date:   Mon, 4 Feb 2019 11:22:57 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190204192129.93533-1-ray.jui@broadcom.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Fix looks good.

On 2019-02-04 11:21 a.m., Ray Jui wrote:
> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>
> RING_CONTROL reg was not written due to wrong address, hence all
> the subsequent ring flush was timing out.
>
> Fixes: a371c10ea4b3 ("mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush sequence")
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
>   drivers/mailbox/bcm-flexrm-mailbox.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index d713271ebf7c..a64116586b4c 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -1396,9 +1396,9 @@ static void flexrm_shutdown(struct mbox_chan *chan)
>   
>   	/* Clear ring flush state */
>   	timeout = 1000; /* timeout of 1s */
> -	writel_relaxed(0x0, ring + RING_CONTROL);
> +	writel_relaxed(0x0, ring->regs + RING_CONTROL);
>   	do {
> -		if (!(readl_relaxed(ring + RING_FLUSH_DONE) &
> +		if (!(readl_relaxed(ring->regs + RING_FLUSH_DONE) &
>   		      FLUSH_DONE_MASK))
>   			break;
>   		mdelay(1);