Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp4293331ima; Mon, 4 Feb 2019 13:47:57 -0800 (PST) X-Google-Smtp-Source: AHgI3IYSd3tYyWIxX/i13Sizku8yzE2yYPP9vaHVjAXU/hiWhGE0bQJ55fIiZYpGhzN5tfeg4V/U X-Received: by 2002:a17:902:112c:: with SMTP id d41mr1531369pla.144.1549316877410; Mon, 04 Feb 2019 13:47:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549316877; cv=none; d=google.com; s=arc-20160816; b=hzMX9McgMZlec+tRBSvHZjFXzW6BbjTNSHXLkShsUxzXkxTlVU8kYqJIkVEUgnB/KJ 3rwrH2TblMny7ahYmaGPeghxQbKEptvXiGDNwCllUeuhhAnC0k90H5p3s8l5v2H1Qeqa KHqcREcCqk/RuDI0TIf06vbwDymS1TcEDqdAiOhy/1xFyf1MDcXTR24LcFd8j42pFwO6 wyeJVa438O+145GZgBw+5nGpDdO1OA7rDvAnXyGwfE9WfuOItWxWsbDjRQOzaS3cBnTL spl4aK0QWOcYDS6ot6WQgnNogae1mtJI+tzgSMWHHFNstnpUhzpt+7fOlmfgmG0LbCj+ 19gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=IThkOLzbJ9ZOD7sq/FGD2FdoM38PsbmUwnGGy+6IP7w=; b=LzzPtbtWrXowVS/5ggDi1+FIKYAxCr0MhMV56m8dAX7oPscehtm5C0km72ufuN7R09 1fssQ8HQZpLc5TticQ60yYAITdgkxL3SqD1SzRPQY1MurbvIiBwDrHlpUnphWpDNwFPW osUIDGNW2bBUw1ZRxEQ19WsB5nn7FnTK1SCXgeyMHeRULFaLfqgkS+hsVaEU+fW+i+Pu 0uXsned3kWcQpF/FznXNGitmCHppjo8A1Mpg7EtKJky5oGg/rnejuRF2Mk5CYvmtmlgE MYo57BbpXsZmqDahQzdQNZNAS7oFwg+UROSl8KNcZ/dDDJPHVKPT+guDtbsGyLwMr18J 5abQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e8si1097900pgn.325.2019.02.04.13.47.41; Mon, 04 Feb 2019 13:47:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728434AbfBDU2X (ORCPT + 99 others); Mon, 4 Feb 2019 15:28:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56272 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727963AbfBDU2W (ORCPT ); Mon, 4 Feb 2019 15:28:22 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 69DA0C057F34; Mon, 4 Feb 2019 20:28:22 +0000 (UTC) Received: from krava (ovpn-204-43.brq.redhat.com [10.40.204.43]) by smtp.corp.redhat.com (Postfix) with SMTP id 7FC445D9CA; Mon, 4 Feb 2019 20:28:19 +0000 (UTC) Date: Mon, 4 Feb 2019 21:28:18 +0100 From: Jiri Olsa To: Stephane Eranian Cc: Arnaldo Carvalho de Melo , Alexey Budankov , Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Adrian Hunter , Andi Kleen Subject: Re: [RFC/PATCH 00/14] perf record: Add support to store data in directory Message-ID: <20190204202818.GC4794@krava> References: <20190203153018.9650-1-jolsa@kernel.org> <8d8b3f0d-cea8-2daf-249f-29f485c49a46@linux.intel.com> <20190204103643.GA18141@krava> <6bf24b7d-2bd3-8091-cf49-363c91e4e864@linux.intel.com> <20190204114144.GC18141@krava> <20190204192721.GI5593@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 04 Feb 2019 20:28:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 04, 2019 at 12:05:38PM -0800, Stephane Eranian wrote: SNIP > > > > > > > > > > > > [jolsa@krava perf]$ ll result_1/ > > > > > > total 348 > > > > > > -rw-------. 1 jolsa jolsa 27624 Feb 4 11:35 data.0 > > > > > > -rw-------. 1 jolsa jolsa 56672 Feb 4 11:35 data.1 > > > > > > -rw-------. 1 jolsa jolsa 30824 Feb 4 11:35 data.2 > > > > > > -rw-------. 1 jolsa jolsa 49136 Feb 4 11:35 data.3 > > > > > > -rw-------. 1 jolsa jolsa 22712 Feb 4 11:35 data.4 > > > > > > -rw-------. 1 jolsa jolsa 53392 Feb 4 11:35 data.5 > > > > > > -rw-------. 1 jolsa jolsa 43352 Feb 4 11:35 data.6 > > > > > > -rw-------. 1 jolsa jolsa 46688 Feb 4 11:35 data.7 > > > > > > -rw-------. 1 jolsa jolsa 9068 Feb 4 11:35 header > > > > > > > > > > Awesome. What do you think about having it like this: > > > > > > > > > > $ perf record --output result_1.data ... - writes data to a file > > > > > > > > > > $ perf record --dir result_1 ... - or even > > > > > $ perf record --output_dir result_1 ... - writes data into a directory > > > > > > > > > > IMHO, this interface is simpler for a user. > > > > > > > > yep, seems more convenient.. I'll add it > > > > > > > But what happens if you do: perf record -o foo --output_dir foo.d? > > > > Should fail, i.e. either you use single-file or directory output, I > > think. > > > Agreed ok, will do that thanks, jirka