Message-Id: <200403082200.i28M0F2k009714@turing-police.cc.vt.edu>
To: Andrew Morton <akpm@osdl.org>
cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.4-rc2-mm1 
In-reply-to: Your message of "Sun, 07 Mar 2004 22:32:21 PST."
             <20040307223221.0f2db02e.akpm@osdl.org> 
From: Valdis.Kletnieks@vt.edu
References: <20040307223221.0f2db02e.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Mon, 08 Mar 2004 17:00:15 -0500
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1258
Lines: 37

On Sun, 07 Mar 2004 22:32:21 PST, Andrew Morton <akpm@osdl.org>  said:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.4-rc2/2.6.4
-rc2-mm1/

> Changes since 2.6.4-rc1-mm2:
> 
> 
>  linus.patch

The Linus patch apparently has a half-done fix - it does it in smp.c but not
in io_apic.c - so building non-SMP we get:

arch/i386/kernel/io_apic.c:703: error: conflicting types for 'send_IPI_self'
include/asm/hw_irq.h:54: error: previous declaration of 'send_IPI_self' was here
arch/i386/kernel/io_apic.c:703: error: conflicting types for 'send_IPI_self'
include/asm/hw_irq.h:54: error: previous declaration of 'send_IPI_self' was here

Fix:

--- linux-2.6.4-rc2-mm1/arch/i386/kernel/io_apic.c.akpm	2004-03-08 16:53:02.337724358 -0500
+++ linux-2.6.4-rc2-mm1/arch/i386/kernel/io_apic.c	2004-03-08 16:53:20.950171060 -0500
@@ -699,7 +699,7 @@
 #endif /* CONFIG_IRQBALANCE */
 
 #ifndef CONFIG_SMP
-void send_IPI_self(int vector)
+void fastcall send_IPI_self(int vector)
 {
 	unsigned int cfg;
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/