Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Feb 2019 22:07:09 +0100 (CET)
From:   David Kozub <zub@linux.fjfi.cvut.cz>
To:     Christoph Hellwig <hch@infradead.org>
cc:     Jens Axboe <axboe@kernel.dk>,
        Jonathan Derrick <jonathan.derrick@intel.com>,
        Scott Bauer <sbauer@plzdonthack.me>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Subject: Re: [PATCH v4 03/16] block: sed-opal: unify space check in
 add_token_*
In-Reply-To: <20190204144418.GC31132@infradead.org>
Message-ID: <alpine.LRH.2.21.1902042145330.10661@linux.fjfi.cvut.cz>
References: <1549054223-12220-1-git-send-email-zub@linux.fjfi.cvut.cz> <1549054223-12220-4-git-send-email-zub@linux.fjfi.cvut.cz> <20190204144418.GC31132@infradead.org>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 4 Feb 2019, Christoph Hellwig wrote:

> On Fri, Feb 01, 2019 at 09:50:10PM +0100, David Kozub wrote:
>> From: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
>>
>> All add_token_* functions have a common set of conditions that have to
>> be checked. Use a common function for those checks in order to avoid
>> different behaviour as well as code duplication.
>>
>> Co-authored-by: David Kozub <zub@linux.fjfi.cvut.cz>
>> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
>> Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz>
>> Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>
>> ---
>>  block/sed-opal.c | 30 +++++++++++++++++++++---------
>>  1 file changed, 21 insertions(+), 9 deletions(-)
>>
>> diff --git a/block/sed-opal.c b/block/sed-opal.c
>> index 5c123a5b4ab1..980705681806 100644
>> --- a/block/sed-opal.c
>> +++ b/block/sed-opal.c
>> @@ -510,15 +510,29 @@ static int opal_discovery0(struct opal_dev *dev, void *data)
>>  	return opal_discovery0_end(dev);
>>  }
>>
>> -static void add_token_u8(int *err, struct opal_dev *cmd, u8 tok)
>> +static size_t remaining_size(struct opal_dev *cmd)
>> +{
>> +	return IO_BUFFER_LENGTH - cmd->pos;
>> +}
>
> This function seem a little pointless to me, at least as of this patch
> where it only has a single user just below.

It is eventually used for the second time in 11/16 block: sed-opal: ioctl 
for writing to shadow mbr.

If you feel strongly about this I can exclude it from this commit and 
introduce it in 11/16 (where it then will called from here and from 
write_shadow_mbr).

Best regards,
David