Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Feb 2019 13:09:11 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     David Kozub <zub@linux.fjfi.cvut.cz>
Cc:     Christoph Hellwig <hch@infradead.org>,
        Jens Axboe <axboe@kernel.dk>,
        Jonathan Derrick <jonathan.derrick@intel.com>,
        Scott Bauer <sbauer@plzdonthack.me>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Subject: Re: [PATCH v4 03/16] block: sed-opal: unify space check in
 add_token_*
Message-ID: <20190204210911.GA18821@infradead.org>
References: <1549054223-12220-1-git-send-email-zub@linux.fjfi.cvut.cz>
 <1549054223-12220-4-git-send-email-zub@linux.fjfi.cvut.cz>
 <20190204144418.GC31132@infradead.org>
 <alpine.LRH.2.21.1902042145330.10661@linux.fjfi.cvut.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LRH.2.21.1902042145330.10661@linux.fjfi.cvut.cz>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 04, 2019 at 10:07:09PM +0100, David Kozub wrote:
> It is eventually used for the second time in 11/16 block: sed-opal: ioctl
> for writing to shadow mbr.
> 
> If you feel strongly about this I can exclude it from this commit and
> introduce it in 11/16 (where it then will called from here and from
> write_shadow_mbr).

No problem, just keep it.