Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [RFC PATCH 3/4] kvm: Add guest side support for free memory hints
From:   Nadav Amit <nadav.amit@gmail.com>
In-Reply-To: <20190204181552.12095.46287.stgit@localhost.localdomain>
Date:   Mon, 4 Feb 2019 15:00:18 -0800
Cc:     Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>,
        kvm list <kvm@vger.kernel.org>,
        Radim Krcmar <rkrcmar@redhat.com>,
        Alexander Duyck <alexander.h.duyck@linux.intel.com>,
        X86 ML <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
        bp@alien8.de, hpa@zytor.com, pbonzini@redhat.com,
        tglx@linutronix.de, akpm@linux-foundation.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4E64E8CA-6741-47DF-87DE-88D01B01B15D@gmail.com>
References: <20190204181118.12095.38300.stgit@localhost.localdomain>
 <20190204181552.12095.46287.stgit@localhost.localdomain>
To:     Alexander Duyck <alexander.duyck@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Feb 4, 2019, at 10:15 AM, Alexander Duyck =
<alexander.duyck@gmail.com> wrote:
>=20
> From: Alexander Duyck <alexander.h.duyck@linux.intel.com>
>=20
> Add guest support for providing free memory hints to the KVM =
hypervisor for
> freed pages huge TLB size or larger. I am restricting the size to
> huge TLB order and larger because the hypercalls are too expensive to =
be
> performing one per 4K page. Using the huge TLB order became the =
obvious
> choice for the order to use as it allows us to avoid fragmentation of =
higher
> order memory on the host.
>=20
> I have limited the functionality so that it doesn't work when page
> poisoning is enabled. I did this because a write to the page after =
doing an
> MADV_DONTNEED would effectively negate the hint, so it would be =
wasting
> cycles to do so.
>=20
> Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> ---
> arch/x86/include/asm/page.h |   13 +++++++++++++
> arch/x86/kernel/kvm.c       |   23 +++++++++++++++++++++++
> 2 files changed, 36 insertions(+)
>=20
> diff --git a/arch/x86/include/asm/page.h b/arch/x86/include/asm/page.h
> index 7555b48803a8..4487ad7a3385 100644
> --- a/arch/x86/include/asm/page.h
> +++ b/arch/x86/include/asm/page.h
> @@ -18,6 +18,19 @@
>=20
> struct page;
>=20
> +#ifdef CONFIG_KVM_GUEST
> +#include <linux/jump_label.h>
> +extern struct static_key_false pv_free_page_hint_enabled;
> +
> +#define HAVE_ARCH_FREE_PAGE
> +void __arch_free_page(struct page *page, unsigned int order);
> +static inline void arch_free_page(struct page *page, unsigned int =
order)
> +{
> +	if (static_branch_unlikely(&pv_free_page_hint_enabled))
> +		__arch_free_page(page, order);
> +}
> +#endif

This patch and the following one assume that only KVM should be able to =
hook
to these events. I do not think it is appropriate for __arch_free_page() =
to
effectively mean =E2=80=9Ckvm_guest_free_page()=E2=80=9D.

Is it possible to use the paravirt infrastructure for this feature,
similarly to other PV features? It is not the best infrastructure, but =
at least
it is hypervisor-neutral.