Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp4386405ima; Mon, 4 Feb 2019 15:48:45 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ2REqb8gHN90XoWBTjgyFnKWJZTfdAlkTu/Ekr2CSy7kArbZOUkkOSZDD1kMwT8oZm2LYo X-Received: by 2002:a63:1c09:: with SMTP id c9mr1667832pgc.200.1549324125008; Mon, 04 Feb 2019 15:48:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549324125; cv=none; d=google.com; s=arc-20160816; b=yAZKO2NebZMqbL6vj4Y6BV/Q84+BKbMV2i8Frry0fKqT/Ehs/cQhrdAfd7lbLfjGcs DBCe0n82V+WCh1U3hER3Gu6rRFely5lJpTMn2q6jlChAICGwx8Q77FOpNNk40Q0zlERL zbqQnbGelkxBE00a0gXKf1T8/BO2WV9oQjOG79JnE4N1zsmCocsNuq7nnqk6xAckbneY TWYXPJT2hfBsIkFr5miIK+pk4R7lZXzd1IZvNaYJHXVI1BpeLb9Mt94yMmRuaMYdHTZp z0H9xQZD4TVTITUy0+BUJwNvxUCYIs/eMsj240sfManNmdlLC73C4UhfAPZzRowQW7cj CfiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=zc6AH7Pz3U6i+U5+dFjbOxhR8OTwLXWNovDldCJiwoQ=; b=mYtwyXBdgKaTqy0L8b6rSistiw1MrArjnFZctzr4IhjX8RS0g0B2on26TCU2h/1VBj nVTAJbdvKwSxqe0iVhnerorgG2wSi1UZ8h1YrADQNUJBeF4q7C4jNQWSjerL/RL2hojk 6qBb2V3CWvXv+KAoN11oLbNeJdoICSrqgfrM7Z8n+eir+xRKyTXyK4ylFmQJbUY3cBaH NQ9bm8clN9vwKRFAZ9nwFaIAeATiSlXmtg3vDNcvegcttqFjI7GfaOV56GsvnYZIGm8I MxPmX8MmXqohKYoGJUZQeSZDJsQN3+0j3Ol64usvNg8UcrMf4TAO+yRogLuzbCfmdfrI WjUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b=P82dzIa7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 10si1475619pfy.206.2019.02.04.15.48.28; Mon, 04 Feb 2019 15:48:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b=P82dzIa7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727211AbfBDXsX (ORCPT + 99 others); Mon, 4 Feb 2019 18:48:23 -0500 Received: from vern.gendns.com ([98.142.107.122]:51172 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726083AbfBDXsX (ORCPT ); Mon, 4 Feb 2019 18:48:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zc6AH7Pz3U6i+U5+dFjbOxhR8OTwLXWNovDldCJiwoQ=; b=P82dzIa72mBfhDV8YpO9P+VKrp ewVn0QHPBGhRJToigtMDiLFfRZG0WIj5W1o+QXmo1g0kQx0buMvyk/vYP8hSu9kBSpx5jcQVbQl3H JqGnR+a2xPvOvVkCTMa1ruNqD47HZ2+/E1jYmXKWvxzC0kcEgMSgVg+y0hHhti3Adhk+0KBVwIUHD EXY4a+H5RKYWGASEa9hdNQZThBOVkef2HfvX+GfkjZG5VmGJGTmNpDVjtpTUl/sLgxxp6tD6hHCA9 KQbPjjk9/G7hxF5G9CT3/87jwyEc+iOPL0m55pU1TDEpXJNkXuh0c/iudwkfxcLSwaQVphLmc25bl iuPuxYdA==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:59682 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gqnuw-00072e-1p; Mon, 04 Feb 2019 18:44:46 -0500 Subject: Re: [PATCH 19/35] ARM: davinci: cp-intc: remove cp_intc.h To: Bartosz Golaszewski , Sekhar Nori , Kevin Hilman , Thomas Gleixner , Jason Cooper , Marc Zyngier Cc: Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20190131133928.17985-1-brgl@bgdev.pl> <20190131133928.17985-20-brgl@bgdev.pl> From: David Lechner Message-ID: Date: Mon, 4 Feb 2019 17:48:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190131133928.17985-20-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/19 7:39 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > There's no need to have a local header for cp-intc. Move the only > declaration for a public function to common.h. Move all register > offsets into the driver source file and drop all unused defines. > Make cp_intc_of_init() static. > > Signed-off-by: Bartosz Golaszewski > --- Reviewed-by: David Lechner