Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp4511200ima; Mon, 4 Feb 2019 18:38:39 -0800 (PST) X-Google-Smtp-Source: AHgI3IbtvVL5uBHe3bS5hl3ZHNaCP7IPbGNQ0wWAV1mLLNn6LGSlxR0lIYWwtbZlj7oSLp5FBcv/ X-Received: by 2002:a63:6ecf:: with SMTP id j198mr2412324pgc.3.1549334319718; Mon, 04 Feb 2019 18:38:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549334319; cv=none; d=google.com; s=arc-20160816; b=WUkfQpXo8Vyan209EdfLpceAx9L/ellX8IPfA13xUw5ozc4uFRKGT9yJnoZp3PLwUA pGb54bzgbdt3xW6qjKQ4E59PK+/BdGTS8y4kRyh1RTrtgYK+FWThq6ztWdM50Pv2kVoT zhok7jALFdz4iXsZyZcg749N2x97rDS0zHZdVdnNHlSWTeHNgHE+GNYNfvKpG4FZ1aqf PnXaVQhh45CBUbtqsnKwZHudLfnAmr510B6lSLLeMjFm2eOQxYhaQcO93cnHwjl7FObe OqGoRlXBPqPx65XOGHooewlzMypO63BYM0FRlmd7PptNwnGSOuqCZ8s2eqFzppdqCKDX dazA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=R9UkLfdgvyCBzr2dwRvBxCIf8dscsvUaA9fcVhxkDkw=; b=GOhBCpOcCLyNuW8DMSAzANtqWpWKOfDq/VsO0K/KnzkkSvvJTanjOm+GwEh4/H4cKO xVJI93e7PSgsSDkluC4Tuft7A2hsHnMgUS0xCivOw4qI+3S0Lduli8L05fMJphFpXLrW mWuhhcvu6JGS5wFwHvZcMu/9S75aSDh1zLE79bohq6Qswb8QSbVw8oRJ+5HAL/XRAsix h/cK76lnbVYULdactWBWqxI1ubvClRdchtEKYF5X5y7fpwRPqpluyddtrBixo8DBJvrU HlJ9tz3nQCQL6yiJGSQLvODfEpRJZZ35KIr0LlOt98jQA5K2O91gayJmlX6DLXn2aGhf NNKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pkV86TRF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 85si2041314pfc.145.2019.02.04.18.38.20; Mon, 04 Feb 2019 18:38:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pkV86TRF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbfBECdw (ORCPT + 99 others); Mon, 4 Feb 2019 21:33:52 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:45989 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbfBECdw (ORCPT ); Mon, 4 Feb 2019 21:33:52 -0500 Received: by mail-lj1-f194.google.com with SMTP id s5-v6so1597671ljd.12; Mon, 04 Feb 2019 18:33:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R9UkLfdgvyCBzr2dwRvBxCIf8dscsvUaA9fcVhxkDkw=; b=pkV86TRF6rziuDnwGcEaMbnZ/mZUH7PwFsKlP7AOC7F3LY6/Z3dX6mmgd+efstCbT3 GFUemIlmfc6o55IiT3RGmSISjcI+FyW56WdLg069WJSJfx9RZ6gLwog2Qul0AcsbvHZt p3kJulJHk3/kAr/lB2mcVMAwSD1QgmMjQotr6hanXW0o6CCl5/MVWaODk+OmmMLfKBQp bJDvl+Gxlocg1xqEf6HyQNXWdAMdqjPUqBS866lPJckcgwBUlUzkfdbvWR24ExClB4zt 9J35xt4m+5WNDg/pOzniaLydYBWseMiY/Np+z4mx2XfjFLHXJEKKvWvQ9JLSiX9/McHY 06NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R9UkLfdgvyCBzr2dwRvBxCIf8dscsvUaA9fcVhxkDkw=; b=pgZDcJ2W1/XDxHbb25DOAws/jyxQ3z7FQPd7fNNkfArgpTiqWSyPiEEwC+zvrFgzz4 xyPlB15KpridVdyBJPdx4U1uaHFC/7l2UcP5lS27fmE7OmF7I0XB7zi84ZcqwbogogLJ sHCGzYNZyCTc9/glWwcfulCGDEjBplnp2fTldJJ8nlTkmv//dZlV7mAKwhBUP9qKkb4I fajNhh1ddVyWtuJ/BDEWzz86KrpUlb3TJSzTEBX0OZejz39Lv2XurhCoL+uU4uVtVy9u VSdVdarP5yfyo2hiSDUeckhPdB2nA40M+71Rgq1Ci2N4Uq2RzMJ/rGkrPU4UqBIzeJF9 Ap0A== X-Gm-Message-State: AHQUAua78/K1f84rWqekWbRssOFgsX4sN9D/XpkUtAM+antggM+UfziB SCvi9EPbdlh2Op6pob5wme8uGDLXu0UgWsiU2sVKcw== X-Received: by 2002:a2e:1552:: with SMTP id 18-v6mr1395230ljv.68.1549334030090; Mon, 04 Feb 2019 18:33:50 -0800 (PST) MIME-Version: 1.0 References: <20190104192410.GA11084@jordon-HP-15-Notebook-PC> <20190114085839.GA13316@quack2.suse.cz> In-Reply-To: From: Souptick Joarder Date: Tue, 5 Feb 2019 08:03:43 +0530 Message-ID: Subject: Re: [PATCH] fs/dax: Convert to use vmf_error() To: Dan Williams Cc: Jan Kara , Matthew Wilcox , Ross Zwisler , Al Viro , linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On Tue, Jan 15, 2019 at 4:00 AM Dan Williams wrote: > > On Mon, Jan 14, 2019 at 12:59 AM Jan Kara wrote: > > > > On Sat 05-01-19 00:54:11, Souptick Joarder wrote: > > > This code is converted to use vmf_error(). > > > > > > Signed-off-by: Souptick Joarder > > > > Dan, you are merging DAX patches these days. So probably you should add > > yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs. > > Sounds good, I'll merge this and get MAINTAINERs fixed up. This is not reflecting in linux-next. Is this queued for 5.1 ? > > > Or I can start > > picking patches for fsdax to my tree if you are too busy but I think your > > tree is easier as there are less chances for conflicts etc. > > > > In either case this patch looks OK to me so feel free to add > > > > Reviewed-by: Jan Kara > > > > Honza > > > > > --- > > > fs/dax.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/fs/dax.c b/fs/dax.c > > > index 48132ec..ed39161 100644 > > > --- a/fs/dax.c > > > +++ b/fs/dax.c > > > @@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error) > > > { > > > if (error == 0) > > > return VM_FAULT_NOPAGE; > > > - if (error == -ENOMEM) > > > - return VM_FAULT_OOM; > > > - return VM_FAULT_SIGBUS; > > > + return vmf_error(error); > > > } > > > > > > /* > > > -- > > > 1.9.1 > > > > > -- > > Jan Kara > > SUSE Labs, CR