Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp4800133ima; Tue, 5 Feb 2019 01:19:43 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ8hhZbd6q1mQMpmiCaUCvhXVmDJC068+BBncdGUyn4mUnROBPz9oyzpuZSzl/LBcEBiAs9 X-Received: by 2002:a63:e247:: with SMTP id y7mr3499313pgj.84.1549358383396; Tue, 05 Feb 2019 01:19:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549358383; cv=none; d=google.com; s=arc-20160816; b=d5uqZEafntr1l3MttzMNgkYzFeASH5byxNQMv5n6IEDbzI80shnxrItqIp9Xk6U/7r /lH5C18A0ImASQ3e/jHCFFOSks1gJXqeORZRGa6Qh5V3xZ4QYfxsUBCukxd1Do0ovhuo YicrfNh2T0+w1rXWt5AvaUhkcqMLkhwHqdv3J5WBhl3BkTn+KszqVLiN99hQaVMxbK9M K9UjaQhgTuw06TDNSruZLflf1S2q/yHY8je6CFh5s+S3aKyY+/E9N9u1i3WHrh5EImIv NsHIE0EPpghiJfxJreSpjtwJ/s4eYZf2ruM5XUquhbnyqVIt1XO2uRxCS2v+vjnrklzf ++0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=27z0ZYNcv37KAn9EWdpLBTvefC4+qLAJthht315+v24=; b=ppRLlxCfzba3OEZS3Snb2s5bSgu8hifxPgSm5ykzibrK+qgOzlt91gqHI8iRHpSJAM 2TWJDES/4ZsD2QSLYrNXWfbmCPAj5zaWXNngKxPLPwBNrPst7u2xwm/P6YaO2ZaFGwoh h61xCBoFISQ5GedbUrqGOWwHpTHPOWGbTrfBfGzuQujzVyo74LktDXli2iQpuSy0R95S ATHIBHLzgpTPmIQh1+fAyNsPnuHHCb5Wf2Oo9hXRiLWUF/Tf19jMTpqjW+NdX4Fig1Xv UEtodfxdt2WzJmMvkTCQBRqxRilRJh9L+MCcbsisf4419uZoYoI2M5jzSgLl/qUyg6Zl OwUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=lHmUoXPY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b21si2737731pfc.49.2019.02.05.01.19.27; Tue, 05 Feb 2019 01:19:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=lHmUoXPY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728592AbfBEJSx (ORCPT + 99 others); Tue, 5 Feb 2019 04:18:53 -0500 Received: from mail.skyhub.de ([5.9.137.197]:49502 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728068AbfBEJSx (ORCPT ); Tue, 5 Feb 2019 04:18:53 -0500 Received: from zn.tnic (p200300EC2BCB6B0041C3B5D5EB4D55D2.dip0.t-ipconnect.de [IPv6:2003:ec:2bcb:6b00:41c3:b5d5:eb4d:55d2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C4CA01EC02AE; Tue, 5 Feb 2019 10:18:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1549358330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=27z0ZYNcv37KAn9EWdpLBTvefC4+qLAJthht315+v24=; b=lHmUoXPYkWLZS/JSO0PVbQzoLRAdR0EjlaGqBzoguPTBfePCmw46XVjYaic1MT6q92G6I6 JRB/OdTUe32hWMX2ytZm5EDzC9y4VLLamRgY2c333m92lAfUlzBCTXfy1SDy+YCiil6x9G 6ps4QH+9C5H1UYRDZu1yx+DDOiyUr+M= Date: Tue, 5 Feb 2019 10:18:41 +0100 From: Borislav Petkov To: Rick Edgecombe Cc: Andy Lutomirski , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, Thomas Gleixner , Nadav Amit , Dave Hansen , Peter Zijlstra , linux_dti@icloud.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, akpm@linux-foundation.org, kernel-hardening@lists.openwall.com, linux-mm@kvack.org, will.deacon@arm.com, ard.biesheuvel@linaro.org, kristen@linux.intel.com, deneen.t.dock@intel.com, Nadav Amit , Kees Cook , Dave Hansen Subject: Re: [PATCH v2 05/20] x86/alternative: initializing temporary mm for patching Message-ID: <20190205091841.GI21801@zn.tnic> References: <20190129003422.9328-1-rick.p.edgecombe@intel.com> <20190129003422.9328-6-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190129003422.9328-6-rick.p.edgecombe@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just nitpicks: Subject: [PATCH v2 05/20] x86/alternative: initializing temporary mm for patching s/initailizing/Initialize/ On Mon, Jan 28, 2019 at 04:34:07PM -0800, Rick Edgecombe wrote: > From: Nadav Amit > > To prevent improper use of the PTEs that are used for text patching, we > want to use a temporary mm struct. We initailize it by copying the init Please remove the "we" from commit messages and use impartial, passive formulations. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.