Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp4926366ima; Tue, 5 Feb 2019 03:43:06 -0800 (PST) X-Google-Smtp-Source: AHgI3IaH8dbN7USSnYXR6sqgLLueHth06DeeRoEDs0R7bn7/5fW3AoWdHzY4kO7osIgYSSbnt6Do X-Received: by 2002:a17:902:be11:: with SMTP id r17mr4737442pls.308.1549366986146; Tue, 05 Feb 2019 03:43:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549366986; cv=none; d=google.com; s=arc-20160816; b=zUANoqGSqP42qIat7Ilqsyx4YZKIS8fNtkcWvyDIpuLTk05+V9gepb8jYHByWcX7qb 8sw7UhVFMEvMIfeXhtXPrPtP5kwYSjKIrXfgR7lfQd1xD1kWqD7afgUOLWQyZR6Jxd9K SuDTUis4+WyIvV1fhVeFVAstf6nJOO79+ilZ8dlVULz3dNelNRZ1DYOLW4rY9/2b9Kqu MuOqG/grVOtXt081fZUJg4dkLYvHG6NIuFfjFkNEfJz+9ioHvkACH4zZKZ8WMAzGL3tZ LMoUCU6sfnK8zjbAtbB8GiCaMvVvnR42yuyvkJNAFIuVAsJYAmmYwZAoxIc1vORNpg1J ZZeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:reply-to; bh=TXhA6gtazdey2gWZE5eWqiXZDtJEDewNpmh8KKofxHI=; b=Cn4yOjh9QBtGaO+iSqaoD5RoGzxf9dcgzm3P7g8dfZCi7tl3FGpVpQICPF7Pfbe9Jd l5is/LrNRebXaoWyYehfY3oRGLgOlAPK8unftXr9osbWgWs3HmAK5UAIo8LBdrvOvMQ3 YDNcJMfUonAcgRVhW64KQVM32wC9hoHBQqfTY+gwXAF+Ae3Q/cF/9Z7DDTDo+ol3y+GM uBe89hf2zWp1KmKrcuR3iM1J58jc2qPr7roPUyXuih0ia3cuqLgApDTN0ue5VI/x3cpr 8ArkPXC1WPR2iGz94Fzi7Nwp5hxE8sEYAxjf5C5vDwpah+r8Lo0hl5BGfELBmNIWrH6r 37bw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a2si2955572pgm.154.2019.02.05.03.42.49; Tue, 05 Feb 2019 03:43:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729034AbfBELii (ORCPT + 99 others); Tue, 5 Feb 2019 06:38:38 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60476 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728563AbfBELih (ORCPT ); Tue, 5 Feb 2019 06:38:37 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x15BYYA2102576 for ; Tue, 5 Feb 2019 06:38:36 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qf9h0guh3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 05 Feb 2019 06:38:36 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Feb 2019 11:38:34 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 5 Feb 2019 11:38:30 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x15BcT6V5767442 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 5 Feb 2019 11:38:29 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 26D4E11C04C; Tue, 5 Feb 2019 11:38:29 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A741B11C04A; Tue, 5 Feb 2019 11:38:28 +0000 (GMT) Received: from [9.152.224.140] (unknown [9.152.224.140]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 5 Feb 2019 11:38:28 +0000 (GMT) Reply-To: pmorel@linux.ibm.com Subject: Re: [PATCH v7 13/15] KVM: s390: add gib_alert_irq_handler() To: Michael Mueller , KVM Mailing List Cc: Linux-S390 Mailing List , linux-kernel@vger.kernel.org, Martin Schwidefsky , Heiko Carstens , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Halil Pasic References: <20190131085247.13826-1-mimu@linux.ibm.com> <20190131085247.13826-14-mimu@linux.ibm.com> From: Pierre Morel Date: Tue, 5 Feb 2019 12:38:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190131085247.13826-14-mimu@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19020511-0012-0000-0000-000002F18A9B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19020511-0013-0000-0000-00002128E56C Message-Id: <50f05038-f414-50f5-dbe7-e2bcca0b8433@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-05_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=838 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902050092 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/01/2019 09:52, Michael Mueller wrote: > The patch implements a handler for GIB alert interruptions > on the host. Its task is to alert guests that interrupts are > pending for them. > > A GIB alert interrupt statistic counter is added as well: > > $ cat /proc/interrupts > CPU0 CPU1 > ... > GAL: 23 37 [I/O] GIB Alert > ... > > Signed-off-by: Michael Mueller > Acked-by: Halil Pasic > --- The only thing that bother me is the short timer's expiration value. But it is optimization and it is working for me so. Reviewed-by: Pierre Morel -- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany