Date: Mon, 8 Mar 2004 16:32:06 -0800 (PST)
From: Linus Torvalds <torvalds@osdl.org>
To: Andrew Morton <akpm@osdl.org>
cc: Thomas Schlichter <thomas.schlichter@web.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix warning about duplicate 'const'
In-Reply-To: <20040308161410.49127bdf.akpm@osdl.org>
Message-ID: <Pine.LNX.4.58.0403081627450.9575@ppc970.osdl.org>
References: <200403090043.21043.thomas.schlichter@web.de>
 <20040308161410.49127bdf.akpm@osdl.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1030
Lines: 31


On Mon, 8 Mar 2004, Andrew Morton wrote:
> > 
> > This is done by removing the 'const' from the temporary variables of the min() 
> > and max() macros. For me it seems to have no negative impact, so please 
> > consider applying...
> 
> I think there was a reason for those consts in kernel.h's min() and max()
> macros, but memory fails me.  Linus, do you recall?

I'm not 100% sure, but I think they are required to make a few other 
warnings go away. The fact that gcc complains about "const typeof" is a 
gcc misfeature, I think, and should be fixed there.

The warnings the extra "const" fixes is something like:

	int a;
	const int b;

	min(a,b)

where otherwise it would complain about pointers to different types when
comparing the type of the pointer. Or something.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/