Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH v3 0/2] Bluetooth: Add NULL check for tiocmget() and
 tiocmset()
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <cover.1549346039.git.mhjungk@gmail.com>
Date:   Tue, 5 Feb 2019 14:55:50 +0100
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <0D421861-FCD6-4AFF-8A0F-DBEE520DB64B@holtmann.org>
References: <cover.1549346039.git.mhjungk@gmail.com>
To:     Myungho Jung <mhjungk@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Myungho,

> tiocmget() and tiocmset() operations are optional and some tty drivers
> like pty miss the operations. Add NULL checks to prevent from
> dereference.
> 
> Myungho Jung (2):
>  Bluetooth: hci_ath: Add NULL check for tiocmget() and tiocmset() in
>    ath_setup()
>  Bluetooth: hci_ldisc: Add NULL check for tiocmget() and tiocmset() in
>    hci_uart_set_flow_control()
> 
> drivers/bluetooth/hci_ath.c   | 6 ++++++
> drivers/bluetooth/hci_ldisc.c | 4 ++++
> 2 files changed, 10 insertions(+)

why are we not enforcing the availability of these in the hci_uart_tty_open?

Regards

Marcel