Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp5239062ima; Tue, 5 Feb 2019 08:29:22 -0800 (PST) X-Google-Smtp-Source: AHgI3IZd6revkz8YByw67fJ+E8hkGMLCyFZPTSYQbr4I8p3glPJNfcCiWOCX986vj8j91k0D3r09 X-Received: by 2002:a17:902:e012:: with SMTP id ca18mr5944348plb.218.1549384162393; Tue, 05 Feb 2019 08:29:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549384162; cv=none; d=google.com; s=arc-20160816; b=msxuRa3rWy0PaZ1dhCW3WEwsiBILmzXqQWrg/KVb2E8VLZqjHJrooABFdcdX3myN9S ie7AGL37QtUaLoFfSSPZnrK64ErYl3deNUVeA7JyO/LiGFlWJnrE+LtoV/N+P2/R+VCx Uv+hcv1ZrXI9V/LQq4RIBHQ//g80HxUfiCz6esDG2mxkIFofA/Ukx7YhSfcl6nddDM5T xH0XAaLl1VTvaM1TBirlRG/ORxkU5u+upf2J1Aat+9sRjn6SWwWF3fZsl6xEHM08u+9s Tbz/yTSfIvR7cgVwy4GDqMOnPl8s8J8OhG7pVvIzp9eCXCOI3g68lkd7Qh7M9l1Avvv/ hzGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=obC/o0x/Of+oiYvDNo+3FmUgPGJAQl+NE5x85eXAQHI=; b=kPCxHQjr0sklfsmxCKNrUKNNsvv4Cm37WYBQDCrzyUHKuUkikq9+iY6te3LAVHiJZi s7ykuOFyt7cLgML87wKRoPgjkfsZI1ZO64+XxEqJ+mM8QliCsQfA534Z3/tQ5HwO4G2b MMgtbsWuZW4Fe2V42W5yHQsjbBvVcE+rzKmqaQyB9tfW4bw/S5SLUKMdDbz1bAnY3OKn ev+GH5zcbDKoxWJ+u2cjgaw0W+jQRcLUx0WORMIkpNQszrK7ZeWORBeCxtzRgpWbldAk N7eNr3QxFUNgpzZ3bdBl226atqLNYNgg0EOiiDN1oJXimkHLZRNQcMO6koDJsJ0ZAVS8 PrbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=WSV81ETS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6si3607020plc.241.2019.02.05.08.29.05; Tue, 05 Feb 2019 08:29:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=WSV81ETS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730050AbfBEP7v (ORCPT + 99 others); Tue, 5 Feb 2019 10:59:51 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54925 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729547AbfBEP7v (ORCPT ); Tue, 5 Feb 2019 10:59:51 -0500 Received: by mail-wm1-f66.google.com with SMTP id a62so4197863wmh.4 for ; Tue, 05 Feb 2019 07:59:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version; bh=obC/o0x/Of+oiYvDNo+3FmUgPGJAQl+NE5x85eXAQHI=; b=WSV81ETS+kogLHB4BvEl6z/BdttOBfQ9jLyogcbwsk8O19p2eJ0F87NbLRjxhPSY5m jru04119WHfN5Ojw0FqEIYDTbm883PI2wFjbPV4qVeN6TE1SfV707mJos0aAAXrdVjGd UVZ5O98son0kInTPtFBdl31QBQT018TiJbDlPq7hHUXTPeGDswp1xUuOQQZ8kCCNFzvM 0jLnZk08zYrCG96BfpERA2AJPeweqEfm5iBeW6P6cOHy5hGmAzVKwOA3hR5EeQ1MzCL6 DacGQGFQCsj1er9+HxPHY6gwsKFFNujj76py9cyjFI5vhpJzinV5mzWrxZX+qJW771AT AZ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=obC/o0x/Of+oiYvDNo+3FmUgPGJAQl+NE5x85eXAQHI=; b=I6o5Bf+/JxPM9fGpvyYtbLWWjH1qxiSjnff+deQ8RXS6kriZhav6PPwylqLg+HdZn9 qP7DXKLbZvRV8r27I/rrZoyqLjU40+NgPGYH9h5gk1xAkY68bzcoMGrYZG+1+9Ym9J7/ DFW8bdatwiQEMJSxDvL/W7m8o97VK6miLWE6ZfNrJgYbQ1Cq5Qy3y+hLKH8dkk4v/H7h iWlE7UBwnZxazbi1Hva/qyvzdRtWpPvRc5lXmAYoFgGU6yJQpZMEUcjb/TyK/F4l9Oup YX/dpubcMxvxTBO+8S2GwLJwe2u0GS2BIURKMHz1UC1wzlLLLlyi0aa+KIpFo8bRkSxx eCBQ== X-Gm-Message-State: AHQUAubph1i/rKuGEB+7jOTrEZUG+avXjcnA5woMiX2oCfKnOzxBArNP nP5/sH45EFVr80QS/JhnRQ+CGw== X-Received: by 2002:a1c:d082:: with SMTP id h124mr4071012wmg.21.1549382388516; Tue, 05 Feb 2019 07:59:48 -0800 (PST) Received: from localhost ([2620:10d:c092:180::1:a0f9]) by smtp.gmail.com with ESMTPSA id s66sm11635832wmf.34.2019.02.05.07.59.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Feb 2019 07:59:47 -0800 (PST) From: Julien Masson To: Kevin Hilman , Greg Kroah-Hartman Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] tty: serial: meson_uart: Add support for kernel debugger Date: Fri, 1 Feb 2019 08:36:59 +0100 Message-ID: <864l9i1b0t.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The kgdb invokes the poll_put_char and poll_get_char when communicating with the host. This patch implement the serial polling hooks for the meson_uart to be used for KGDB debugging over serial line. Signed-off-by: Julien Masson --- drivers/tty/serial/meson_uart.c | 46 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c index 8a84259..49b20da 100644 --- a/drivers/tty/serial/meson_uart.c +++ b/drivers/tty/serial/meson_uart.c @@ -426,6 +426,48 @@ static void meson_uart_config_port(struct uart_port *port, int flags) } } +#ifdef CONFIG_CONSOLE_POLL +/* + * Console polling routines for writing and reading from the uart while + * in an interrupt or debug context (i.e. kgdb). + */ + +static int meson_uart_poll_get_char(struct uart_port *port) +{ + u32 c; + unsigned long flags; + + spin_lock_irqsave(&port->lock, flags); + + if (readl(port->membase + AML_UART_STATUS) & AML_UART_RX_EMPTY) + c = NO_POLL_CHAR; + else + c = readl(port->membase + AML_UART_RFIFO); + + spin_unlock_irqrestore(&port->lock, flags); + + return c; +} + +static void meson_uart_poll_put_char(struct uart_port *port, unsigned char c) +{ + unsigned long flags; + + spin_lock_irqsave(&port->lock, flags); + + while (!(readl(port->membase + AML_UART_STATUS) & AML_UART_TX_EMPTY)) + cpu_relax(); + + writel(c, port->membase + AML_UART_WFIFO); + + while (!(readl(port->membase + AML_UART_STATUS) & AML_UART_TX_EMPTY)) + cpu_relax(); + + spin_unlock_irqrestore(&port->lock, flags); +} + +#endif /* CONFIG_CONSOLE_POLL */ + static const struct uart_ops meson_uart_ops = { .set_mctrl = meson_uart_set_mctrl, .get_mctrl = meson_uart_get_mctrl, @@ -441,6 +483,10 @@ static const struct uart_ops meson_uart_ops = { .request_port = meson_uart_request_port, .release_port = meson_uart_release_port, .verify_port = meson_uart_verify_port, +#ifdef CONFIG_CONSOLE_POLL + .poll_get_char = meson_uart_poll_get_char, + .poll_put_char = meson_uart_poll_put_char, +#endif }; #ifdef CONFIG_SERIAL_MESON_CONSOLE -- 2.7.4