Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 5 Feb 2019 18:21:54 +0100
From:   Sebastian Reichel <sre@kernel.org>
To:     Sven Van Asbroeck <thesven73@gmail.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Tejun Heo <tj@kernel.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Kees Cook <keescook@chromium.org>
Subject: Re: [RFC v1 2/3] max17042_battery: fix potential user-after-free on
 module unload
Message-ID: <20190205172154.j4zhucvnc7enadbc@earth.universe>
References: <20190204220952.30761-1-TheSven73@googlemail.com>
 <20190204220952.30761-3-TheSven73@googlemail.com>
 <20190205082727.GB118684@dtor-ws>
 <CAGngYiWJhja9bF5vL_4mwTjPMtzOwvsahHEpkntMPgMXdBNg9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="d2jrdxogdqjb3gzv"
Content-Disposition: inline
In-Reply-To: <CAGngYiWJhja9bF5vL_4mwTjPMtzOwvsahHEpkntMPgMXdBNg9g@mail.gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--d2jrdxogdqjb3gzv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Feb 05, 2019 at 09:27:49AM -0500, Sven Van Asbroeck wrote:
> On Tue, Feb 5, 2019 at 3:27 AM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > Are there many more instances of this?
>=20
> Unfortunately I think so.
> A simple grep brings up a couple of candidates, but I'm sure there are mo=
re:
>=20
> drivers/regulator/arizona-micsupp.c
> drivers/nfc/port100.c
> drivers/power/supply/max14656_charger_detector.c
> drivers/phy/broadcom/phy-bcm-ns2-usbdrd.c
>=20
> > I am unsure if we need
> > devm_init_work() when we can easily do the same in remove() call.
>=20
> The devm_init_work() suggestion only addresses the problem for those modu=
les
> that use devm_. The others will need fixes in remove(). But this is not as
> elegant and error-proof as using devm_init_work().
>=20
> [...]

I would for sure appreciate a devm_init_work(). There are a lot of
devm_ users in power-supply and this helper would definitely
simplify things.

-- Sebastian

--d2jrdxogdqjb3gzv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlxZxi8ACgkQ2O7X88g7
+prQuQ/9F542FnFizpWNTCBQFiEGR8h7hB4/iBdHPTqUiKInCVv//JcRxgrBMeDm
G7+V2J1iFdL/sRM/4qLHMh+q2b8nxSzqPBjE+0RPrV3EwFtO3NLXz1PfBzfupzS4
xdUPuE8eF1A2qhk1xjvPXvT8poptJHpMYs7mOfFOUdlDMYcdl6BdHhozitywxQ23
8FEFU4KLIYzeVP/gDvXM10+rkxuS1MVWmUnZ4c8aMJCIvTHw1oC5shjCCA/vxr7f
Yh+7OXaZFy7/2okjkgnPof+MnlEud9hGaI9pV5a2+/p29SeeZT/WolzMjqAo52Dx
IRVazKuBagH2n7xQAjgt/F/T47L/gjr+YRE3lc9hfznS9ZdPPB1OsmaojOO5V4tS
cBALSxm/AVluiwtcZGciWtCqAm6Zvy/biZtkspobZfFfe9+bHz68XtTGX8hfRMVl
wQse7xXA3QejDkLHjeL8Z8yImwo2ILS8Y8/uhpKPvCs51fJ0qRUeBDsF00Anda4R
HlWKrVODG/7oJyN3PGPKZ6brn8eX/ANosAY4jmUJpu3002VsLVitAme5YTcvJxia
Yx2PCd2CQcxxLFL497Sp4wNZibYmqBa21hi4+re/50n1tF5lMNTC5DjXaELuPh8D
FW+2su1x1Eh4RfUiaGfhwiQOzWKJ6jOQXVrzZZFHtClztJKYDdw=
=+Ulx
-----END PGP SIGNATURE-----

--d2jrdxogdqjb3gzv--