Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp5343008ima; Tue, 5 Feb 2019 10:08:23 -0800 (PST) X-Google-Smtp-Source: AHgI3IY7ZwcO0GpR1KgP4Vwikg7KkFYlJpK6loDkFjHVlyDevs1nYyiDwpPIh2FcOj+Xk5jhlL5w X-Received: by 2002:a63:83:: with SMTP id 125mr5523758pga.343.1549390103343; Tue, 05 Feb 2019 10:08:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549390103; cv=none; d=google.com; s=arc-20160816; b=YCxdrYdDHdhyyp2TTBOuCmPfXkt35d9mo1/+h8rfxEPtQLGi6jZ4kzsRamuL/w8xeT uMZ2IeK+tQmepn3W7K9Veul/8S3kmXWUBV5dQIim05RX48QShfDjxjyLmR4Z1YNnWYx+ IeinbKW1EYLirblQ73RPDpW76hDewlc3rMkj6Q0odcVQ6hbkHl4XHfNQFjYcLT8sZYbP D7G5DqZLt7A9gA+0VzpyZtgHOhCNOG8sTY500sJGdWpCur/A+oiHA9LbxXsmYf0JP+WA ss4DhXzG5scvL00by9jnjO4sIlfmf7FRqchr6H7pLcKZi8DACTvvGUnERX9aPWtDb+R3 h0BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wt6hD0eCAsQc4zllEHco38QshoC/JGJZy0TCdJssmfw=; b=NnV8yRfRJQDdEgKDkksBS7upt0StHUDokGq7DvyPxn95cSfF7O2JmKz+CzII67wY13 nfhyAmJR9zSmidz/RiO8xKNfxHyAazWrWEomVffKmYr9s0TIhFwAhsmFH1sEgyUvhaV0 6fAmZ4Vz2YzybWZH6EPQHGl0s1I0dYUqFdZdkZ07RCWWHXPXoux2lvFXxRCZDNnUcOy0 z18ebX6Z7Yuu8LY+3gVlT4PNMg2Q0gRXsTpFDjjsKdxsJCG1xEEUWOUm+5oOCvcCKsoR GG2nqZ8viF0CU08fMrxVU5/edmxaicIkE+RRoouHAzY+LqejNGLPyPb3Zr8lU7ROOtkW aBPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="agq6/Qtw"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j61si3723013plb.232.2019.02.05.10.08.05; Tue, 05 Feb 2019 10:08:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="agq6/Qtw"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729380AbfBESHD (ORCPT + 99 others); Tue, 5 Feb 2019 13:07:03 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36411 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727413AbfBESHC (ORCPT ); Tue, 5 Feb 2019 13:07:02 -0500 Received: by mail-pf1-f193.google.com with SMTP id b85so1835123pfc.3; Tue, 05 Feb 2019 10:07:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wt6hD0eCAsQc4zllEHco38QshoC/JGJZy0TCdJssmfw=; b=agq6/QtwmmkAXDskC28UNcbL5Fxc1bnNqlyTnkFGBn9ZI0aCO6X2gOY3n+11+Fd3xQ ZCIcb94t2Id7gSw4ynEV7VshZgI/jPJWAeHqBQEZuT9BfI/XqPZsMDepQ9eUB7Mdi+g/ RM1sH2bSKhfVs3ACt5hvApfA/qDl9i+7FBNqlcjo8dD+scn5X3wZK9OUWADqqBNIltt6 iqK/PAjTjlPATbPsBQcQ4Rvn+JyRVnAI2DiAZL9RJqgpA5SbZR9Xxp2US49rvhypMTcL TAPo3qyCq+fmn79g4d87Xv0RwQwrnLfdo2ZdiQn8YW6sgJhTYf6HV3tfc9L5XYsGbFO0 5Yeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wt6hD0eCAsQc4zllEHco38QshoC/JGJZy0TCdJssmfw=; b=K8kNgCi5Mu/43vA322hpNt3TXiR9RmERNLJG1tCCySLrlyOMTHVsSIvzr877WVnG46 uJ7GcdmonbUAV/SwtHRvl7/6mLayxOztcsr8yJjDZRTBdM5lv49MoUGX/gXapW9rRe9D MWTTrkzAYzq9EmvdEj46zsVGfa688AtewK45YdDZR9ba9qP5kYGZOu/R1YAC2LXb+IRH nTTpsFuiL0ibyuHTo0xxo56HEnByfltPpR9QCWZYZd0vr63GHM5H3ovCC7vdoRryFnFI Gmxqx02Ma//A1DcrzYkabLgaoG7wP8X3QM5xqMbKLc2vxnIhuL6WkylATKvZ0KhGHDdS Bvmw== X-Gm-Message-State: AHQUAuZ0+Mv4Rjvv9cqlu7qndESoO9NOn77NoTJTiW8tC6grmBjAX0D+ LCvrCZwP0mXZbn5ZS/d3IMXYWrQMAFY+Bfsku3s= X-Received: by 2002:a63:20e:: with SMTP id 14mr5664042pgc.161.1549390021843; Tue, 05 Feb 2019 10:07:01 -0800 (PST) MIME-Version: 1.0 References: <20190201073234.13280-1-rajneesh.bhardwaj@linux.intel.com> In-Reply-To: <20190201073234.13280-1-rajneesh.bhardwaj@linux.intel.com> From: Andy Shevchenko Date: Tue, 5 Feb 2019 20:06:50 +0200 Message-ID: Subject: Re: [PATCH 00/10] ICL support and other enhancements for PMC Core To: Rajneesh Bhardwaj Cc: Platform Driver , Darren Hart , Andy Shevchenko , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 1, 2019 at 9:32 AM Rajneesh Bhardwaj wrote: > > This patch series provides Icelake support for PMC Core driver and while > doing so it introduces the Icelake Mobile to intel-family.h as per the > CPUID from below Coreboot link > https://github.com/coreboot/coreboot/blob/5ebcea3aaaa3cd358bc5bccaa156b13a6ef25df6/src/soc/intel/common/block/include/intelblocks/mp_init.h > and provides some fixes and enhancements to the driver. > I have applied first 5 patches (fixes) to my review and testing queue, thanks! I'll wait for the next version next week, based on what would be promoted to our for-next branch and addressed comments from reviewers. > This series: > -adds ICL U/Y CPUID to intel-family.h > -enable PMC driver for ICL. > -introduce a new "package cstate show" feature > -fixes a customer issue related to S0ix on latest HP laptops. > -fixes some minor bugs > > Rajneesh Bhardwaj (10): > platform/x86: intel_pmc_core: Handle CFL regmap properly > platform/x86: intel_pmc_core: Fix PCH IP sts reading > platform/x86: intel_pmc_core: Fix PCH IP name > platform/x86: intel_pmc_core: Fix file permissions for ltr_show > platform/x86: intel_pmc_core: Include Reserved IP for LTR > x86/cpu: Add Icelake to Intel family > platform/x86: intel_pmc_core: Convert to INTEL_CPU_FAM6 macro > platform/x86: intel_pmc_core: Add ICL platform support > platform/x86: intel_pmc_core: Add Package cstates residency info > platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown > > arch/x86/include/asm/intel-family.h | 2 + > drivers/platform/x86/intel_pmc_core.c | 155 +++++++++++++++++++++----- > drivers/platform/x86/intel_pmc_core.h | 14 ++- > 3 files changed, 145 insertions(+), 26 deletions(-) > > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko