Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp5389119ima; Tue, 5 Feb 2019 10:55:55 -0800 (PST) X-Google-Smtp-Source: AHgI3IZh6o0UvrLVW2/yEM1XsBelDlJtLK27zPVeFjxvaZiPoegfIMMJRd0FCS1PEWCaC9IrM6A/ X-Received: by 2002:a62:9913:: with SMTP id d19mr6421744pfe.107.1549392955242; Tue, 05 Feb 2019 10:55:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549392955; cv=none; d=google.com; s=arc-20160816; b=tfN9dzgOc3aUl+C0x9pZXNY+QULMTJId1Hqczqs6D1izFGuz3myRabLpMConT27Ku4 XrUxX2x/lOhkNOifpDVjRZ6ybaCZTRZlmxrpkir2JwJ6sKSaRR1ZWPGDVTakLjjnxH1w bOK54SL05D0t0kVZkwbpl2FBw3r9OAmhBXmMv5x3Wg81oYFoX5iRE4kdDopjkp2Jbkva qq7mz2RBownaf/Xvhi4wYF4c3T1uyluj9sLnKhvGA7zXGkgBxgmgzNRkFKQQKU0/UVmn FKRjd+1r2/LuK6cZFEIsLKiRD/9+jlKINTLyTMYOECIxvEo2JzMGd9DRR5udjI/FS++X 9IIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=3TiWkUpvs8QracilJ4QWMIBgZ113jn/XDkT60PVQBrM=; b=sVX4qIfXsNd2gUVXVkeAMX2uF6x25FbhchiRTwX86aqvBS0UaQjUBXkcns+8t9riXD Y8C0xGbvR2qTQ/x2VZZuwTb2xPxQJSYd1/qHN/13K7Arso49vKVlUEmWM+yvkVKzsUic EBrc5l0hM4ws/78xFNJKHUI2GotrUKhWlfoHVtoJj8YvPbgd2u9Fz7y0t3paPFhmXIRX 384rDpvhtgbUWAnvo0uCqPpYqi/2WLypOdoLz63tdLajQYhnI0Q6f2yiKZrFs7QvCkIA n4IEv0DMhySQCDkkbU/uRVOQQfWBOuTTmuAEEAWP6iSN+YfXVPyf8kGWrSPt85ywkPRw x3dA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3si3611342pgc.354.2019.02.05.10.55.38; Tue, 05 Feb 2019 10:55:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729484AbfBESPQ (ORCPT + 99 others); Tue, 5 Feb 2019 13:15:16 -0500 Received: from mga04.intel.com ([192.55.52.120]:30235 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbfBESN5 (ORCPT ); Tue, 5 Feb 2019 13:13:57 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2019 10:13:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,336,1544515200"; d="scan'208";a="317869081" Received: from rbhardw1-mobl.gar.corp.intel.com (HELO [10.252.74.67]) ([10.252.74.67]) by fmsmga005.fm.intel.com with ESMTP; 05 Feb 2019 10:13:55 -0800 Subject: Re: [PATCH 00/10] ICL support and other enhancements for PMC Core To: Andy Shevchenko Cc: Platform Driver , Darren Hart , Andy Shevchenko , Linux Kernel Mailing List References: <20190201073234.13280-1-rajneesh.bhardwaj@linux.intel.com> From: "Bhardwaj, Rajneesh" Message-ID: Date: Tue, 5 Feb 2019 23:43:53 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05-Feb-19 11:36 PM, Andy Shevchenko wrote: > On Fri, Feb 1, 2019 at 9:32 AM Rajneesh Bhardwaj > wrote: >> This patch series provides Icelake support for PMC Core driver and while >> doing so it introduces the Icelake Mobile to intel-family.h as per the >> CPUID from below Coreboot link >> https://github.com/coreboot/coreboot/blob/5ebcea3aaaa3cd358bc5bccaa156b13a6ef25df6/src/soc/intel/common/block/include/intelblocks/mp_init.h >> and provides some fixes and enhancements to the driver. >> > I have applied first 5 patches (fixes) to my review and testing queue, thanks! Thank you Andy :) > > I'll wait for the next version next week, based on what would be > promoted to our for-next branch and addressed comments from reviewers. Fine, I'll look forward to submit remaining patches after addressing all received feedback thus far, next week. > >> This series: >> -adds ICL U/Y CPUID to intel-family.h >> -enable PMC driver for ICL. >> -introduce a new "package cstate show" feature >> -fixes a customer issue related to S0ix on latest HP laptops. >> -fixes some minor bugs >> >> Rajneesh Bhardwaj (10): >> platform/x86: intel_pmc_core: Handle CFL regmap properly >> platform/x86: intel_pmc_core: Fix PCH IP sts reading >> platform/x86: intel_pmc_core: Fix PCH IP name >> platform/x86: intel_pmc_core: Fix file permissions for ltr_show >> platform/x86: intel_pmc_core: Include Reserved IP for LTR >> x86/cpu: Add Icelake to Intel family >> platform/x86: intel_pmc_core: Convert to INTEL_CPU_FAM6 macro >> platform/x86: intel_pmc_core: Add ICL platform support >> platform/x86: intel_pmc_core: Add Package cstates residency info >> platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown >> >> arch/x86/include/asm/intel-family.h | 2 + >> drivers/platform/x86/intel_pmc_core.c | 155 +++++++++++++++++++++----- >> drivers/platform/x86/intel_pmc_core.h | 14 ++- >> 3 files changed, 145 insertions(+), 26 deletions(-) >> >> -- >> 2.17.1 >> >