Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp5394081ima; Tue, 5 Feb 2019 11:01:11 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ7dV9OJHjcOhIepUiYUQifoZ7A1q5PhXL9v6TG3CoQZgRangBHjx0BQMWKSF73zTm6rOIe X-Received: by 2002:a17:902:6948:: with SMTP id k8mr6529878plt.2.1549393271892; Tue, 05 Feb 2019 11:01:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549393271; cv=none; d=google.com; s=arc-20160816; b=i4urdOD51GF1nVgLvFdiisasLWsJHEZRBfG41jYOUHLTE8CMbOBr+7qbT0proiOhaV a0O+aKQ6KEH9uAWhbmIb4sbwFcgFBuPn9kL+J3VXjcAdefqyE27W6KGl6aemlx6dBnHU aEmimLzj+NCSA802+cu4/6+HkV4XJM515UoPhn0T5ZDSgrdIpxujBFwZgAimqhUpJjGN Opz+AiE3q+pFJ6klmUFGejmPs+PHLB3y6zgOMs61zF3FuiEsqZ6q1RLs91qcl40uSplH Nu/dAl58bvzNOOq2N3sVbN3CiI8Sp4PNawkgWyVJzGnNdPfsMAbN2LHiXTOWm0me/OB1 qHdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=FVlBFbZ/Rf8EhhvuHPQNiF+bYJe2E/F4dl2//NQxB6s=; b=ITW0LoW3GftneFfmwY3mb+zRuKFV6BgZMg1RjgakHbzVHLY6aUs4bGF6NpGdFa+jbL 1JtIBmPh+KMGQWYzpxy1sA0Df9I2l5vM89q+KSVSd9x3nnke+iRrnrpvdCdTkCzlhx9w pZOzIFrAezHx8XpdhCZEy8+q25DsEzb+wGqdZwjjO6VNuJVs6z5YbL6JFdx519fmwnKw jeGZnJ0XYGUSfM6gY6R/DiG2HZJgPPLVgftimPNpRfnNgWTpO2mkLn8GxkMN2AHIIjVM nB3gC2bJCNfTmyYw4GrwX2ot0Cct5hyaxlELeOv2UAELvPHUgyWOqMKbJZfu8t1KMpc5 TLpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r184si3656732pgr.266.2019.02.05.11.00.56; Tue, 05 Feb 2019 11:01:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730008AbfBEScI (ORCPT + 99 others); Tue, 5 Feb 2019 13:32:08 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:33987 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727379AbfBEScH (ORCPT ); Tue, 5 Feb 2019 13:32:07 -0500 Received: from mail-yw1-f70.google.com ([209.85.161.70]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1gr5Vs-0008Kh-OR for linux-kernel@vger.kernel.org; Tue, 05 Feb 2019 18:32:04 +0000 Received: by mail-yw1-f70.google.com with SMTP id q82so2855474ywg.22 for ; Tue, 05 Feb 2019 10:32:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=FVlBFbZ/Rf8EhhvuHPQNiF+bYJe2E/F4dl2//NQxB6s=; b=lF4fC2nUCsBwh66GwVcZe+W1h/RuOZX5yMHwS6WVuCjsZMH8SwD1KgrCHaxjU9UG+q i+yspnA06QVjeLxKaQ/mVQumoLWwrc+pM4e9rg3N3mjbBWxryrNOGB/NwfqB27fhYdJj GB1rUaJoP0sCHc3FPqY8jmj6oJGgMsfYcMxrUv3Skctce2GFMucDqxBzljHYmorD9liT bKaUx5g3wTrb5wxtoATpnWG8YLAsXGjJ2bedjE0mmN0IhWqVo6ovZiDLnlFFyBWonDdG x04U4wMotkxO724/0HHG1wcfZNI3XEw4+nNPU2I5imlFUjsM7R7AxV6HPDr2DNxZolGY wSFQ== X-Gm-Message-State: AHQUAua42E4vxdtzRTB6cRRWEzMj9KSDLJi8rJjAMmVnK1N9RUPyidDO kedjF/D5MJ9TriwCf7N5bR+A2YTJv1UXqwaJkSq5npo2bB05nnOxl+rbzrd/xjdPpnPgsqtPM6z LBVl/F/K/kKzLiD4W3a1eUTXRp0DeH4R/8dAHAKIu8Q== X-Received: by 2002:a25:ca83:: with SMTP id a125mr3034486ybg.45.1549391523664; Tue, 05 Feb 2019 10:32:03 -0800 (PST) X-Received: by 2002:a25:ca83:: with SMTP id a125mr3034447ybg.45.1549391523309; Tue, 05 Feb 2019 10:32:03 -0800 (PST) Received: from localhost ([2605:a601:ac2:fb20:ac97:1957:a992:bb67]) by smtp.gmail.com with ESMTPSA id t129sm1748534ywe.11.2019.02.05.10.32.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 10:32:02 -0800 (PST) Date: Tue, 5 Feb 2019 12:32:01 -0600 From: Seth Forshee To: Mimi Zohar Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu , Luis Chamberlain , David Howells , Justin Forbes , Matthew Garrett Subject: Re: [PATCH] x86/ima: require signed kernel modules Message-ID: <20190205183201.GA3218@ubuntu-xps13> References: <1548962339-10681-1-git-send-email-zohar@linux.ibm.com> <1548962339-10681-2-git-send-email-zohar@linux.ibm.com> <20190205151859.GD16362@ubuntu-xps13> <1549385244.4146.148.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1549385244.4146.148.camel@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 05, 2019 at 11:47:24AM -0500, Mimi Zohar wrote: > Hi Seth, > > On Tue, 2019-02-05 at 09:18 -0600, Seth Forshee wrote: > > On Thu, Jan 31, 2019 at 02:18:59PM -0500, Mimi Zohar wrote: > > > Require signed kernel modules on systems with secure boot mode enabled. > > > > > > To coordinate between appended kernel module signatures and IMA > > > signatures, only define an IMA MODULE_CHECK policy rule if > > > CONFIG_MODULE_SIG is not enabled. > > > > > > This patch defines a function named set_module_sig_required() and renames > > > is_module_sig_enforced() to is_module_sig_enforced_or_required(). The > > > call to set_module_sig_required() is dependent on CONFIG_IMA_ARCH_POLICY > > > being enabled. > > > > > > Signed-off-by: Mimi Zohar > > > > With respect to interactions with the kernel lockdown patches, this > > looks better than the patches I saw previously. I don't feel like I know > > enough about what's going on with IMA to ack the patch, but I feel > > confident that it's at least not going to break signature enforcement > > for us. > > Thank you for testing!  Could this be translated into a "tested-by" > "(for w/lockdown patches)"? Yeah, that's fine. To be clear about what I tested, I've confirmed that it doesn't interfere with requiring signed modules under lockdown with CONFIG_IMA_ARCH_POLICY=n and IMA appraisal enabled. Tested-by: Seth Forshee