Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp5401605ima; Tue, 5 Feb 2019 11:07:46 -0800 (PST) X-Google-Smtp-Source: AHgI3IaQNH3XfomksRtcOI5zfWxeLmR9UkDF3Ku44HsFeF/JDhKz7mwvasmnu1rldEBvV8klv4lK X-Received: by 2002:a17:902:fa2:: with SMTP id 31mr6650977plz.75.1549393666599; Tue, 05 Feb 2019 11:07:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549393666; cv=none; d=google.com; s=arc-20160816; b=RySCXiYV7GkltqIpCYryXP5lDpLTO7RH91lS5Iwmd8zulyIkRwBFjtO/MwNjfgDA5s BEAvLx4Hq2E21ZcEWMPaRuqD/OCI6MusnLRqpPpmuN/ZYlKX9JXXLBiVhoi2Q/owJ5PS 0x2JUzyPE1O2TKFDBIGQ8ZTLRyR00AF5acz/60zaHFdzj8qCSA43eGygtk42SDodMfzz 6xAguLlHWFr+S/gbn/anDV7CG+/hO641NmPOwv8SW/re0QTdUPk9gPZzZ3LrjA3/xEoR LxJKRU97WZvyw3yCB7JQH3UZi5zDabQtFCgNyGTPnAfiWdYNCN+0rTu1TLFXk+soRVlz s44A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=frNeLKNRzdgI2p/15nT/ZhnC3CQz6PGA0jCAmIQj1Hw=; b=cTm9Kx1XrPq5ARscUUPNOVls060+DD9v9fW3LvzEurRFq0YNYRqtitLRAd2H3qkDIf i/2JRQRqMwrD8CbVm4+P7iz4z8JdDKoYKxjqKeI/0mrk1Iss/jY9BE+j62ZviPi1/INE Yq6YVo1kgwBWkHl2QnFF05goJ7V2fFgqhm/M06OVvzMKYNWHuVl5rNVl+nP2ZtzmOSTB 1WsY50sTrVLkO1U9BUAL68Yya+N5rRUeFsnLOqzv1BexunvwEMLLeL949ekkvdSTI4a/ uVg3OsLSg25PfAN8OMSdVa0rpkbOn6oxpRRvtRYBUft3UzY2RL3LlSVF4tNa2Mhz2qsn yCgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a17si1261483pfn.213.2019.02.05.11.07.30; Tue, 05 Feb 2019 11:07:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728993AbfBETFw convert rfc822-to-8bit (ORCPT + 99 others); Tue, 5 Feb 2019 14:05:52 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:39565 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbfBETFv (ORCPT ); Tue, 5 Feb 2019 14:05:51 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2EB2760008; Tue, 5 Feb 2019 19:05:47 +0000 (UTC) Date: Tue, 5 Feb 2019 20:05:45 +0100 From: Miquel Raynal To: Colin King Cc: Liang Yang , Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Kevin Hilman , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Message-ID: <20190205200545.2952f548@xps13> In-Reply-To: <20190129105757.19138-1-colin.king@canonical.com> References: <20190129105757.19138-1-colin.king@canonical.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, Colin King wrote on Tue, 29 Jan 2019 10:57:57 +0000: > From: Colin Ian King > > The call to meson_chip_buffer_init is not assigning ret, however, ret > is being checked for failure. Fix this by adding in the missing assignment. > > Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") > Signed-off-by: Colin Ian King > --- > drivers/mtd/nand/raw/meson_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Merged in nand/next with the original commit. Thanks, Miquèl