Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 5 Feb 2019 20:06:41 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Nathan Chancellor <natechancellor@gmail.com>
Cc:     Liang Yang <liang.yang@amlogic.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Richard Weinberger <richard@nod.at>,
        Kevin Hilman <khilman@baylibre.com>,
        linux-mtd@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: meson: Fix linking error on 32-bit
 platforms
Message-ID: <20190205200641.1c97f9fe@xps13>
In-Reply-To: <20190129214657.5877-1-natechancellor@gmail.com>
References: <20190129214657.5877-1-natechancellor@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Nathan,

Nathan Chancellor <natechancellor@gmail.com> wrote on Tue, 29 Jan 2019
14:46:57 -0700:

> On arm little endian allyesconfig:
> 
>   ld.lld: error: undefined symbol: __aeabi_uldivmod
>   >>> referenced by meson_nand.c
>   >>> mtd/nand/raw/meson_nand.o:(meson_nfc_setup_data_interface) in archive drivers/built-in.a  
> 
> The dividend tBERS_max is u64, meaning we need to use DIV_ROUND_UP_ULL
> (which wraps do_div) to prevent the compiler from emitting
> __aebi_uldivmod.
> 
> Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---

Merged in nand/next with the original commit.


Thanks,
Miquèl